Adding support for terraform private module source for git #7167

vishwahiremat · 2024-02-13T08:59:31Z

Description

Added a RecipeConfig property to the environment
- Typesspec changes
- Conversion and unit tests
- Datamodel changes
Adding changes to the config to append the template path with credential informaiton
- changes to query list secret to get secret information
- creating credential appended template path

Design Doc: radius-project/design-notes#37

Type of change

This pull request adds or changes features of Radius and has an approved issue (issue link required).
This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #6911

Signed-off-by: Vishwanath Hiremath <[email protected]>

sk593 · 2024-02-13T15:35:43Z

pkg/corerp/api/v20231001preview/environment_conversion.go

+	recipeConfig := src.Properties.RecipeConfig
+	if recipeConfig != nil {
+		if recipeConfig.Terraform != nil {
+			if recipeConfig.Terraform.Authentication != nil {


Can these conditions be collapsed? Or do we expect that there may be future logic that's unique to each config level?

In any case i think we still need to check nil at every level to avoid null pointer. Let me know if you think otherwise

sk593 · 2024-02-13T15:38:01Z

pkg/corerp/api/v20231001preview/environment_conversion.go

@@ -63,6 +64,24 @@ func (src *EnvironmentResource) ConvertTo() (v1.DataModelInterface, error) {
 	}
 	converted.Properties.Compute = *envCompute

+	recipeConfig := src.Properties.RecipeConfig
+	if recipeConfig != nil {
+		if recipeConfig.Terraform != nil {


Since these lines are specific to Terraform, maybe we should move this logic to a helper function?

I agree with @sk593. We can have a function that takes care of the recipeConfig conversion and that function can make a call to another function which takes care of terraform related stuff conversion. With this approach we could keep things simple. It would be more readable, easier to debug and write unit tests.

sk593 · 2024-02-13T15:38:31Z

pkg/corerp/api/v20231001preview/environment_conversion.go

@@ -151,6 +170,27 @@ func (dst *EnvironmentResource) ConvertFrom(src v1.DataModelInterface) error {
 		dst.Properties.Recipes = recipes
 	}

+	if !reflect.DeepEqual(env.Properties.RecipeConfig, datamodel.RecipeConfigProperties{}) {
+		recipeConfig := &RecipeConfigProperties{}
+		if !reflect.DeepEqual(env.Properties.RecipeConfig.Terraform, datamodel.TerraformConfigProperties{}) {


Same as above, since this logic is specific to Terraform, maybe we can move it to a helper function

We can apply the same thing as I mentioned above but this time in reverse.

This function -> RecipeConfig conversion function -> Terraform related conversion function

In future, it would be very easy to add new types of provider conversions.

created a separate func

I agree with the suggestion of creating a Terraform related conversion function. @vishwahiremat I know you have updated it to recipe config specific conversion, have you considered adding Terraform specific function to make it easy to extend the recipe config function in the future?

Vishwa and I discussed offline, we will abstract it out into Terraform specific function once we add support for other types.

Signed-off-by: Vishwanath Hiremath <[email protected]>

ytimocin · 2024-02-13T18:09:43Z

pkg/corerp/api/v20231001preview/environment_conversion.go

@@ -63,6 +64,24 @@ func (src *EnvironmentResource) ConvertTo() (v1.DataModelInterface, error) {
 	}
 	converted.Properties.Compute = *envCompute

+	recipeConfig := src.Properties.RecipeConfig
+	if recipeConfig != nil {
+		if recipeConfig.Terraform != nil {


I agree with @sk593. We can have a function that takes care of the recipeConfig conversion and that function can make a call to another function which takes care of terraform related stuff conversion. With this approach we could keep things simple. It would be more readable, easier to debug and write unit tests.

ytimocin · 2024-02-13T18:11:04Z

pkg/corerp/api/v20231001preview/environment_conversion.go

@@ -151,6 +170,27 @@ func (dst *EnvironmentResource) ConvertFrom(src v1.DataModelInterface) error {
 		dst.Properties.Recipes = recipes
 	}

+	if !reflect.DeepEqual(env.Properties.RecipeConfig, datamodel.RecipeConfigProperties{}) {
+		recipeConfig := &RecipeConfigProperties{}
+		if !reflect.DeepEqual(env.Properties.RecipeConfig.Terraform, datamodel.TerraformConfigProperties{}) {


We can apply the same thing as I mentioned above but this time in reverse.

This function -> RecipeConfig conversion function -> Terraform related conversion function

In future, it would be very easy to add new types of provider conversions.

ytimocin · 2024-02-13T18:12:34Z

pkg/corerp/api/v20231001preview/environment_conversion_test.go

@@ -117,6 +117,19 @@ func TestConvertVersionedToDataModel(t *testing.T) {
 							Scope: "/planes/aws/aws/accounts/140313373712/regions/us-west-2",
 						},
 					},
+					RecipeConfig: datamodel.RecipeConfigProperties{


This needs a few different layers and we could run into nil pointer exception easily. We should test it thoroughly.

If we remove the PAT map from this test, we can see if we run into nil pointer exception above in the original conversion logic.

ytimocin · 2024-02-13T18:13:11Z

pkg/corerp/api/v20231001preview/testdata/environmentresource.json

+            "pat": {
+              "dev.azure.com":{
+                "secretStore":"/planes/radius/local/resourcegroups/default/providers/Applications.Core/secretStores/github"
+              }
+            }


What if this part doesn't exist (by mistake of the operator), would this cause a nil pointer exception?

I dont think it will nil pointer if pat property doesnt exist

Can we add a unit test for this?

ytimocin · 2024-02-13T18:14:02Z

pkg/corerp/datamodel/environment.go

+	Compute      rpv1.EnvironmentCompute                           `json:"compute,omitempty"`
+	Recipes      map[string]map[string]EnvironmentRecipeProperties `json:"recipes,omitempty"`
+	Providers    Providers                                         `json:"providers,omitempty"`
+	RecipeConfig RecipeConfigProperties                            `json:"recipeConfig,omitempty"`


I am a fan of adding new properties to the end. Would the order matter here?

not really but i added before recipes because recipeConfig is usually configured before recipes.

pkg/recipes/configloader/environment.go

ytimocin · 2024-02-13T18:19:52Z

pkg/recipes/terraform/config/config.go

+	// Getting the module source path with credentials information if its a private source.
+	path, _ := getModuleSource(ctx, envConfig, envRecipe.TemplatePath, armOptions)


Are we ignoring the error here?

good catch! i handled it my latest pr

ytimocin · 2024-02-13T18:25:15Z

pkg/recipes/terraform/config/config.go

+	if secretStore != "" {
+		secretStoreID, err := resources.ParseResource(secretStore)
+		if err != nil {
+			return "", err
+		}
+		client, err := v20231001preview.NewSecretStoresClient(secretStoreID.RootScope(), &aztoken.AnonymousCredential{}, armOptions)
+		if err != nil {
+			return "", err
+		}
+		secrets, err := client.ListSecrets(ctx, secretStoreID.Name(), map[string]any{}, nil)
+		if err != nil {
+			return "", err
+		}
+		url, err := getGitURL(templatePath)
+		if err != nil {
+			return "", err
+		}
+		var username, pat *string
+		path := "git::https://"
+		user, ok := secrets.Data["username"]
+		if ok {
+			username = user.Value
+			path += fmt.Sprintf("%s:", *username)
+		}
+		token, ok := secrets.Data["pat"]
+		if ok {
+			pat = token.Value
+			path += *pat
+		}
+		path += fmt.Sprintf("@%s", strings.TrimPrefix(url.String(), "https://"))
+		return path, err
+	}
+
+	return templatePath, err


You could do the other case first: if secretStore != "" { return templatePath, err }. Then the rest doesn't need to be within an if case. I find this more readable: first exit cases then the actual logic.

ytimocin · 2024-02-13T18:25:43Z

pkg/recipes/terraform/config/config_test.go


 	err := tfconfig.Save(testcontext.New(t), testDir)
 	require.Error(t, err)
 	require.Equal(t, fmt.Sprintf("error creating file: open %s/main.tf.json: no such file or directory", testDir), err.Error())
 }
+
+func Test_getSecretStoreID(t *testing.T) {


We should add unit tests for all the new functions.

I dont if we can add unit for getGitSource func but i added for the other ones

ytimocin · 2024-02-13T18:26:23Z

pkg/recipes/terraform/execute.go

@@ -268,6 +271,8 @@ func downloadAndInspect(ctx context.Context, tf *tfexec.Terraform, options Optio
 	// Download the Terraform module to the working directory.
 	logger.Info(fmt.Sprintf("Downloading Terraform module: %s", options.EnvRecipe.TemplatePath))
 	downloadStartTime := time.Now()
+
+	//path := options.EnvRecipe.TemplatePath


Can be removed.

radius-functional-tests · 2024-02-13T18:30:45Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	vishwahiremat/radius
Commit ref	`d1a7ab7`
Unique ID	569195a7cb
Image tag	pr-569195a7cb

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-569195a7cb
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-569195a7cb
controller test image location: ghcr.io/radius-project/dev/controller:pr-569195a7cb
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-569195a7cb
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting kubernetes functional tests...
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

sk593 · 2024-02-13T20:13:55Z

pkg/recipes/terraform/config/config.go

+func getModuleSource(ctx context.Context, envConfig *recipes.Configuration, templatePath string, armOptions *arm.ClientOptions) (string, error) {
+	var source string
+	var err error
+	if strings.HasPrefix(templatePath, "git::") {


Are we only supporting private registries that are accessed over HTTPS? Terraform supports other Git URLS (just looking at this: https://developer.hashicorp.com/terraform/language/modules/sources#github) so I'm wondering what the expected behavior would be if a user passed one of these formats

thats correct, today we don't support private registries that are accessed over ssh. And for private git repository we expect user to provide the source in generic git format so all git platforms are supported.

Signed-off-by: Vishwanath Hiremath <[email protected]>

typespec/Applications.Core/environments.tsp

...tion/applications/resource-manager/Applications.Core/preview/2023-10-01-preview/openapi.json

Signed-off-by: Vishwanath Hiremath <[email protected]>

ytimocin · 2024-02-16T20:04:37Z

pkg/corerp/api/v20231001preview/environment_conversion.go

+				}
+			}
+		}
+		for k, v := range config.Terraform.Authentication.Git.PAT {


Would this throw a nil pointer exception if config doesn't have Terraform map? Or Terraform map doesn't have Authentication and so on. We can add unit tests for those cases.

I think this for loop should move to the last if in above. See: if config.Terraform.Authentication.Git.PAT != nil.

ytimocin · 2024-02-16T20:06:47Z

pkg/corerp/api/v20231001preview/environment_conversion_test.go

@@ -117,6 +117,19 @@ func TestConvertVersionedToDataModel(t *testing.T) {
 							Scope: "/planes/aws/aws/accounts/140313373712/regions/us-west-2",
 						},
 					},
+					RecipeConfig: datamodel.RecipeConfigProperties{


If we remove the PAT map from this test, we can see if we run into nil pointer exception above in the original conversion logic.

ytimocin · 2024-02-16T20:08:31Z

pkg/recipes/configloader/environment.go

-		if providers.Azure != nil {
-			config.Providers.Azure.Scope = to.String(providers.Azure.Scope)
-		}
+	env, err := environment.ConvertTo()


Is ConvertTo a new function? It doesn't make a lot of sense to me. We want to convert environment to what specifically? Not in the scope of this PR, but we should check this function.

i am using the existing convertTo() function from environment_conversions

ytimocin · 2024-02-16T20:09:23Z

pkg/recipes/configloader/environment_test.go

+					RecipeConfig: &model.RecipeConfigProperties{
+						Terraform: &model.TerraformConfigProperties{
+							Authentication: &model.AuthConfig{
+								Git: &model.GitAuthConfig{
+									Pat: map[string]*model.Secret{
+										"dev.azure.com": &model.Secret{
+											SecretStore: to.Ptr("secretStoreID"),
+										},
+									},
+								},
+							},
+						},
+					},


We should have a few cases that would cause errors. Like what happens if we remove the PAT?

typespec/Applications.Core/environments.tsp

pending review

pkg/corerp/datamodel/environment.go

pkg/corerp/api/v20231001preview/environment_conversion.go

pkg/recipes/configloader/environment.go

pkg/recipes/configloader/environment_test.go

pkg/recipes/terraform/config/config.go

Signed-off-by: Vishwanath Hiremath <[email protected]>

typespec/Applications.Core/environments.tsp

AaronCrawfis · 2024-02-20T18:52:02Z

typespec/Applications.Core/environments.tsp

+
+@doc("Specifies authentication information needed to access private terraform modules from Git repository sources.")
+model GitAuthConfig{
+  @doc("Specifies the secret details of type personal access token for each different git platforms")  


Suggested change

@doc("Specifies the secret details of type personal access token for each different git platforms")

@doc("Personal Access Token (PAT) configuration used to authenticate to Git platforms.")

AaronCrawfis · 2024-02-20T18:52:30Z

typespec/Applications.Core/environments.tsp

+  pat?: Record<SecretConfig>;
+}
+
+@doc("Specifies the secret details of type personal access token for each different git platforms")


Suggested change

@doc("Specifies the secret details of type personal access token for each different git platforms")

@doc("Personal Access Token (PAT) configuration used to authenticate to Git platforms.")

AaronCrawfis · 2024-02-20T18:56:37Z

typespec/Applications.Core/environments.tsp

+
+@doc("Specifies the secret details of type personal access token for each different git platforms")
+model SecretConfig {
+  @doc("The resource id for the Applications.Core/SecretStore resource containing credentials.")


Could you add some information about what the secret name is required to be in the secret store? Do we expect that there needs to be a secret with a specific name?

radius-functional-tests · 2024-02-20T20:23:34Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	vishwahiremat/radius
Commit ref	`e2d4936`
Unique ID	02fd1fbd43
Image tag	pr-02fd1fbd43

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-02fd1fbd43
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-02fd1fbd43
controller test image location: ghcr.io/radius-project/dev/controller:pr-02fd1fbd43
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-02fd1fbd43
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting daprrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting samples functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting ucp functional tests...
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

pkg/corerp/datamodel/environment.go

Signed-off-by: Vishwanath Hiremath <[email protected]>

pkg/corerp/api/v20231001preview/environment_conversion.go

pkg/recipes/engine/engine.go

pkg/recipes/configloader/secrets.go

pkg/recipes/controllerconfig/config.go

pkg/recipes/driver/gitconfig.go

Signed-off-by: Vishwanath Hiremath <[email protected]>

pkg/recipes/driver/gitconfig.go

pkg/recipes/engine/engine.go

pkg/recipes/types_test.go

kachawla

Looks good overall. A few minor comments.

kachawla · 2024-02-23T06:24:07Z

typespec/Applications.Core/environments.tsp

Should the example be updated as well https://github.com/radius-project/radius/blob/main/typespec/Applications.Core/examples/2023-10-01-preview/Environments_CreateOrUpdate.json?

updated with examples

Signed-off-by: Vishwanath Hiremath <[email protected]>

AaronCrawfis

Type descriptions look good to me!

Signed-off-by: Vishwanath Hiremath <[email protected]>

radius-functional-tests · 2024-02-23T19:27:30Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	vishwahiremat/radius
Commit ref	`81e5598`
Unique ID	30dce63262
Image tag	pr-30dce63262

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-30dce63262
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-30dce63262
controller test image location: ghcr.io/radius-project/dev/controller:pr-30dce63262
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-30dce63262
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting daprrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting samples functional tests...
⌛ Starting shared functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting msgrp functional tests...
✅ samples functional tests succeeded
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ daprrp functional tests succeeded
✅ ucp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

Signed-off-by: Vishwanath Hiremath <[email protected]>

radius-functional-tests · 2024-02-23T20:42:04Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	vishwahiremat/radius
Commit ref	`c7091f0`
Unique ID	83024f0068
Image tag	pr-83024f0068

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-83024f0068
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-83024f0068
controller test image location: ghcr.io/radius-project/dev/controller:pr-83024f0068
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-83024f0068
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting daprrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting shared functional tests...
⌛ Starting datastoresrp functional tests...
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

…oject#7167) - Added a RecipeConfig property to the environment - Typesspec changes - Conversion and unit tests - Datamodel changes - Adding changes to the config to append the template path with credential informaiton - changes to query list secret to get secret information - creating credential appended template path Design Doc: radius-project/design-notes#37  - This pull request adds or changes features of Radius and has an approved issue (issue link required). - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).  Fixes: radius-project#6911 --------- Signed-off-by: Vishwanath Hiremath <[email protected]>

…oject#7167) # Description - Added a RecipeConfig property to the environment - Typesspec changes - Conversion and unit tests - Datamodel changes - Adding changes to the config to append the template path with credential informaiton - changes to query list secret to get secret information - creating credential appended template path Design Doc: radius-project/design-notes#37 ## Type of change  - This pull request adds or changes features of Radius and has an approved issue (issue link required). - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).  Fixes: radius-project#6911 --------- Signed-off-by: Vishwanath Hiremath <[email protected]>

…oject#7167) # Description - Added a RecipeConfig property to the environment - Typesspec changes - Conversion and unit tests - Datamodel changes - Adding changes to the config to append the template path with credential informaiton - changes to query list secret to get secret information - creating credential appended template path Design Doc: radius-project/design-notes#37 ## Type of change  - This pull request adds or changes features of Radius and has an approved issue (issue link required). - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).  Fixes: radius-project#6911 --------- Signed-off-by: Vishwanath Hiremath <[email protected]> Signed-off-by: willdavsmith <[email protected]>

vishwahiremat added 4 commits February 7, 2024 00:50

initial commit

8c41565

Signed-off-by: Vishwanath Hiremath <[email protected]>

adding changes to support private git repo

d212a66

Signed-off-by: Vishwanath Hiremath <[email protected]>

refactor

de5399d

Signed-off-by: Vishwanath Hiremath <[email protected]>

adding comments

ce877cc

Signed-off-by: Vishwanath Hiremath <[email protected]>

vishwahiremat requested review from a team as code owners February 13, 2024 08:59

sk593 reviewed Feb 13, 2024

View reviewed changes

Merge branch 'main' into vishwahiremat/private-repo-support

d1a7ab7

Signed-off-by: Vishwanath Hiremath <[email protected]>

ytimocin reviewed Feb 13, 2024

View reviewed changes

vishwahiremat temporarily deployed to functional-tests February 13, 2024 18:30 — with GitHub Actions Inactive

sk593 reviewed Feb 13, 2024

View reviewed changes

addressing comments

3b29b9e

Signed-off-by: Vishwanath Hiremath <[email protected]>

kachawla reviewed Feb 16, 2024

View reviewed changes

vishwahiremat added 3 commits February 15, 2024 23:45

Merge branch 'main' into vishwahiremat/private-repo-support

70a6bfe

Signed-off-by: Vishwanath Hiremath <[email protected]>

addressing comments

188e3d8

Signed-off-by: Vishwanath Hiremath <[email protected]>

changing the field name secretstore->secret

e717d11

Signed-off-by: Vishwanath Hiremath <[email protected]>

ytimocin reviewed Feb 16, 2024

View reviewed changes

kachawla previously approved these changes Feb 16, 2024

View reviewed changes

typespec/Applications.Core/environments.tsp Outdated Show resolved Hide resolved

kachawla reviewed Feb 17, 2024

View reviewed changes

pkg/corerp/datamodel/environment.go Outdated Show resolved Hide resolved

pkg/corerp/api/v20231001preview/environment_conversion.go Outdated Show resolved Hide resolved

pkg/corerp/api/v20231001preview/environment_conversion.go Show resolved Hide resolved

kachawla reviewed Feb 17, 2024

View reviewed changes

pkg/recipes/configloader/environment.go Show resolved Hide resolved

pkg/recipes/configloader/environment_test.go Outdated Show resolved Hide resolved

pkg/recipes/terraform/config/config.go Outdated Show resolved Hide resolved

addressing comments

e2d4936

Signed-off-by: Vishwanath Hiremath <[email protected]>

AaronCrawfis suggested changes Feb 20, 2024

View reviewed changes

vishwahiremat temporarily deployed to functional-tests February 20, 2024 20:22 — with GitHub Actions Inactive

lakshmimsft reviewed Feb 21, 2024

View reviewed changes

pkg/corerp/datamodel/environment.go Show resolved Hide resolved

adding change to add url config to gitconfig

4b6b8b9

Signed-off-by: Vishwanath Hiremath <[email protected]>

kachawla reviewed Feb 22, 2024

View reviewed changes

addressing comments

b843bc7

Signed-off-by: Vishwanath Hiremath <[email protected]>

kachawla reviewed Feb 23, 2024

View reviewed changes

kachawla requested a review from AaronCrawfis February 23, 2024 06:16

kachawla reviewed Feb 23, 2024

View reviewed changes

addressing comments

6023202

Signed-off-by: Vishwanath Hiremath <[email protected]>

AaronCrawfis previously approved these changes Feb 23, 2024

View reviewed changes

vishwahiremat added 2 commits February 23, 2024 10:57

adding typespec examples

7f89d77

Signed-off-by: Vishwanath Hiremath <[email protected]>

adding typespec examples

81e5598

Signed-off-by: Vishwanath Hiremath <[email protected]>

vishwahiremat dismissed AaronCrawfis’s stale review via 81e5598 February 23, 2024 19:22

kachawla previously approved these changes Feb 23, 2024

View reviewed changes

vishwahiremat temporarily deployed to functional-tests February 23, 2024 19:27 — with GitHub Actions Inactive

vishwahiremat added 3 commits February 23, 2024 12:05

Trigger Build

2ada35f

Signed-off-by: Vishwanath Hiremath <[email protected]>

Trigger Build

fcdc510

Signed-off-by: Vishwanath Hiremath <[email protected]>

adding error for write file

8c178ca

Signed-off-by: Vishwanath Hiremath <[email protected]>

vishwahiremat dismissed kachawla’s stale review via 8c178ca February 23, 2024 20:16

fixing linter error

c7091f0

Signed-off-by: Vishwanath Hiremath <[email protected]>

vishwahiremat temporarily deployed to functional-tests February 23, 2024 20:41 — with GitHub Actions Inactive

kachawla approved these changes Feb 23, 2024

View reviewed changes

kachawla merged commit c0b50a5 into radius-project:main Feb 23, 2024
17 checks passed

		// Getting the module source path with credentials information if its a private source.
		path, _ := getModuleSource(ctx, envConfig, envRecipe.TemplatePath, armOptions)

	@doc("Specifies the secret details of type personal access token for each different git platforms")
	@doc("Personal Access Token (PAT) configuration used to authenticate to Git platforms.")

Adding support for terraform private module source for git #7167

Adding support for terraform private module source for git #7167

Conversation

vishwahiremat commented Feb 13, 2024 • edited by kachawla Loading

Description

Type of change

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sk593 Feb 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kachawla Feb 21, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

radius-functional-tests bot commented Feb 13, 2024 • edited Loading

Radius functional test overview

Test Status

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

radius-functional-tests bot commented Feb 20, 2024 • edited Loading

Radius functional test overview

Test Status

kachawla left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AaronCrawfis left a comment

Choose a reason for hiding this comment

radius-functional-tests bot commented Feb 23, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Feb 23, 2024 • edited Loading

Radius functional test overview

Test Status

vishwahiremat commented Feb 13, 2024 •

edited by kachawla

Loading

sk593 Feb 13, 2024 •

edited

Loading

kachawla Feb 21, 2024 •

edited

Loading

radius-functional-tests bot commented Feb 13, 2024 •

edited

Loading

radius-functional-tests bot commented Feb 20, 2024 •

edited

Loading

radius-functional-tests bot commented Feb 23, 2024 •

edited

Loading

radius-functional-tests bot commented Feb 23, 2024 •

edited

Loading