Updating release documentation for clarity #7150
Conversation
willdavsmith
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
willdavsmith
changed the title
Sure, I have updated the PR title and created a new PR for the release bug: #7150 |
| ```bash | ||
| git push origin <USERNAME>/<BRANCHNAME> | ||
| ``` | ||
| Each release belongs to a *channel* named `<major>.<minor>`. Releases will only interact with assets from their channel. For example, the `0.1` `rad` CLI will: |
There was a problem hiding this comment.
I'd suggest moving this section up to the top (in the definitions). The definitions explain a bunch of things, but then the real description of how we use releases is down here.
willdavsmith
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
| 1. Create a PR to merge into the release branch (format: release/x.y) in the radius repo. Cherry-pick the `version.yaml` changes and the release notes from the previous step in this PR. This will ensure that the version changes and release notes are included in the release branch. [Example](https://github.com/radius-project/radius/pull/6114/files) | ||
| 1. Clone the [radius-project/radius](https://github.com/radius-project/radius) repo locally, or use your existing local copy. | ||
| ``` | ||
| git clone [email protected]:radius-project/radius.git |
There was a problem hiding this comment.
Should this be a fork rather than the main repo? Are we counting on the release captain to have push permissions?
There was a problem hiding this comment.
Yes, for now we are counting on the release captain to have push permissions at the moment. This is because we require the GH token to create a comment on the PR. We could definitely change this but for now we should fork directly from the repo.
ref: #6927 (comment)
| 1. Go through steps 1-4 of "Creating an RC release" above on the `main` branch, substituting the patch release version instead of the final release version. For example, if the final release version number is 0.1.0, the patch release version would be 0.1.1. | ||
| 1. Clone the [radius-project/bicep](https://github.com/radius-project/bicep) repo locally, or use your existing local copy. | ||
| ``` | ||
| git clone [email protected]:radius-project/radius.git |
There was a problem hiding this comment.
Same question, should this be a fork?
This is a really big improvement. I had one question about whether the instructions should be talking about forks, or about the main repo. Other than that LGTM
willdavsmith
dismissed stale reviews from vinayada1, rynowak, and kachawla
via
e2f63c0
There was a problem hiding this comment.
@willdavsmith is this pending on addressing comments or ready for review?
ready for review! It was reviewed by @youngbupark during the last release and seems to be correct. |
willdavsmith
force-pushed
the
willdavsmith/0.30-release-fixes
branch
from
e2f63c0 to
954a3d7
Compare
Signed-off-by: willdavsmith <[email protected]>
willdavsmith
force-pushed
the
willdavsmith/0.30-release-fixes
branch
from
954a3d7 to
9a4c4f1
Compare
willdavsmith
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7150 +/- ##
==========================================
- Coverage 63.84% 63.83% -0.01%
==========================================
Files 417 417
Lines 23497 23497
==========================================
- Hits 15001 14999 -2
- Misses 7227 7228 +1
- Partials 1269 1270 +1 ☔ View full report in Codecov by Sentry. |
great, thanks! I'll merge it once all the workflows pass. |
kachawla
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
kachawla
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
# Description * Updating release process documentation to make it more clear ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional). <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Closes: #7106 Signed-off-by: willdavsmith <[email protected]> Co-authored-by: Karishma Chawla <[email protected]>
Description
Type of change
Closes: #7106