Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event logging for Terraform recipe publishing #7028

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

sk593
Copy link
Contributor

@sk593 sk593 commented Jan 16, 2024

Description

Adding logs to track pod failures during scheduled functional test runs

Type of change

Fixes: #6563

@sk593 sk593 requested review from a team as code owners January 16, 2024 17:07
@sk593 sk593 temporarily deployed to functional-tests January 18, 2024 04:35 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jan 18, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository sk593/radius
Commit ref e41201a
Unique ID 1a117a2308
Image tag pr-1a117a2308
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-1a117a2308
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-1a117a2308
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-1a117a2308
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-1a117a2308
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting shared functional tests...
⌛ Starting ucp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting datastoresrp functional tests...
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

kachawla
kachawla previously approved these changes Jan 18, 2024
with:
name: recipes-pod-logs
path: recipes/pod-logs
retention-days: 30
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the default value for retention? Wondering if we should this explicitly for other artifacts as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Default is 90

Copy link
Contributor

@kachawla kachawla Jan 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Aaron. Not sure why the artifacts are expiring sooner than 90 days, for example they are showing as expired on this week old run https://github.com/radius-project/radius/actions/runs/7484284145

@sk593 I think 30 days is the right limit for tf recipe pod logs given that we don't use them often. We can review other artifacts separately.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sk593 I think 30 days is the right limit for tf recipe pod logs given that we don't use them often. We can review other artifacts separately.

Agreed, I don't think 90 days is necessary since this is just for the recipe uploads

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe runs have different expiration days and the logs get archived somewhere else? Just thinking out loud... 🤣

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah just realized the repo had a retention period (7 days) which was overriding the org-level setting of 90 days. Just updated the repo to 90 days. We can remove this step-level retention period.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, updated to remove the retention value

Copy link
Contributor

@kachawla kachawla Jan 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks @AaronCrawfis, good to know, the increased duration will be helpful for investigations. Question unrelated to this PR - Do we have the ability to keep eye on the storage limits? If in case we start hitting them due to this increased retention and need to lower it below 90 days.

ytimocin
ytimocin previously approved these changes Jan 18, 2024
with:
name: recipes-pod-logs
path: recipes/pod-logs
retention-days: 30
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe runs have different expiration days and the logs get archived somewhere else? Just thinking out loud... 🤣

@sk593 sk593 temporarily deployed to functional-tests January 18, 2024 17:21 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jan 18, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository sk593/radius
Commit ref a5b7d81
Unique ID 94eba25985
Image tag pr-94eba25985
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-94eba25985
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-94eba25985
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-94eba25985
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-94eba25985
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting daprrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting ucp functional tests...
⌛ Starting datastoresrp functional tests...
✅ kubernetes functional tests succeeded
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ daprrp functional tests succeeded
✅ ucp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

@sk593 sk593 dismissed stale reviews from kachawla and ytimocin via eef3ab3 January 18, 2024 18:01
@sk593 sk593 temporarily deployed to functional-tests January 18, 2024 18:23 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jan 18, 2024

Radius functional test overview

🔍 Go to test action run

Name Value
Repository sk593/radius
Commit ref 0491e33
Unique ID 8c11f1b5f4
Image tag pr-8c11f1b5f4
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.12.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-8c11f1b5f4
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-8c11f1b5f4
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-8c11f1b5f4
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-8c11f1b5f4
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting msgrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting shared functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting kubernetes functional tests...
✅ msgrp functional tests succeeded
✅ ucp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

@sk593 sk593 merged commit 33a43ca into radius-project:main Jan 18, 2024
16 checks passed
willdavsmith pushed a commit to willdavsmith/radius that referenced this pull request Jan 26, 2024
# Description

Adding logs to track pod failures during scheduled functional test runs

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
radius-project#6563

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: radius-project#6563

Signed-off-by: sk593 <[email protected]>
willdavsmith pushed a commit to willdavsmith/radius that referenced this pull request Mar 4, 2024
# Description

Adding logs to track pod failures during scheduled functional test runs

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
radius-project#6563

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: radius-project#6563

Signed-off-by: sk593 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test: Publish Terraform test recipes (error: no matching resources found)
4 participants