Enable CLI container port expose test #7000

youngbupark · 2024-01-08T20:31:51Z

Description

This is to enable CLI container port expose test with the better retry.

Type of change

This pull request fixes a bug in Radius and has an approved issue (issue link required).

Fixes: #3232

Signed-off-by: Young Bu Park <[email protected]>

radius-functional-tests · 2024-01-08T22:39:03Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	youngbupark/radius
Commit ref	`3d220a5`
Unique ID	cd5f77bdb4
Image tag	pr-cd5f77bdb4

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-cd5f77bdb4
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-cd5f77bdb4
controller test image location: ghcr.io/radius-project/dev/controller:pr-cd5f77bdb4
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-cd5f77bdb4
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting samples functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting datastoresrp functional tests...
✅ samples functional tests succeeded
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded

Signed-off-by: Young Bu Park <[email protected]>

radius-functional-tests · 2024-01-08T22:45:43Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	youngbupark/radius
Commit ref	`de5ceaa`
Unique ID	882d847e4e
Image tag	pr-882d847e4e

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-882d847e4e
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-882d847e4e
controller test image location: ghcr.io/radius-project/dev/controller:pr-882d847e4e
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-882d847e4e
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting daprrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting ucp functional tests...
⌛ Starting samples functional tests...
⌛ Starting datastoresrp functional tests...
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ daprrp functional tests succeeded
✅ ucp functional tests succeeded
✅ datastoresrp functional tests succeeded
❌ shared functional test failed. Please check the logs for more details

Signed-off-by: Young Bu Park <[email protected]>

radius-functional-tests · 2024-01-08T22:54:50Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	youngbupark/radius
Commit ref	`73b0246`
Unique ID	5c54aded03
Image tag	pr-5c54aded03

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-5c54aded03
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-5c54aded03
controller test image location: ghcr.io/radius-project/dev/controller:pr-5c54aded03
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-5c54aded03
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting msgrp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting shared functional tests...
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ ucp functional tests succeeded
✅ samples functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
❌ shared functional test failed. Please check the logs for more details

Signed-off-by: Young Bu Park <[email protected]>

radius-functional-tests · 2024-01-09T22:22:30Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	youngbupark/radius
Commit ref	`07a8a3c`
Unique ID	82b6822d73
Image tag	pr-82b6822d73

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-82b6822d73
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-82b6822d73
controller test image location: ghcr.io/radius-project/dev/controller:pr-82b6822d73
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-82b6822d73
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting samples functional tests...
✅ msgrp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ ucp functional tests succeeded
✅ samples functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

Signed-off-by: Young Bu Park <[email protected]>

radius-functional-tests · 2024-01-10T00:02:05Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	youngbupark/radius
Commit ref	`59ef24f`
Unique ID	60ec6c4d7e
Image tag	pr-60ec6c4d7e

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-60ec6c4d7e
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-60ec6c4d7e
controller test image location: ghcr.io/radius-project/dev/controller:pr-60ec6c4d7e
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-60ec6c4d7e
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting daprrp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting ucp functional tests...
⌛ Starting datastoresrp functional tests...
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ daprrp functional tests succeeded
✅ ucp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

willdavsmith · 2024-01-10T00:43:37Z

test/functional/shared/cli/cli_test.go

@@ -228,7 +229,6 @@ func verifyCLIBasics(ctx context.Context, t *testing.T, test shared.RPTest) {
 	})

 	t.Run("Validate rad resource expose Container", func(t *testing.T) {
-		t.Skip("https://github.com/radius-project/radius/issues/3232")


do you think this test is still flaky?

Don't know, but I believe it will barely happen. The previous retry logic was linear back-off with 1 second interval. total 10 seconds might be too short to run container or app up completely in some cases. in new change, I used 5 second interval with jitter. This will give enough time to run container or app up.

Signed-off-by: Young Bu Park <[email protected]>

radius-functional-tests · 2024-01-10T01:54:48Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	youngbupark/radius
Commit ref	`60ee783`
Unique ID	5651afb342
Image tag	pr-5651afb342

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.12.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location ghcr.io/radius-project/dev/test/functional/shared/recipes/<name>:pr-5651afb342
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-5651afb342
controller test image location: ghcr.io/radius-project/dev/controller:pr-5651afb342
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-5651afb342
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting daprrp functional tests...
⌛ Starting datastoresrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting kubernetes functional tests...
⌛ Starting shared functional tests...
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ kubernetes functional tests succeeded
✅ daprrp functional tests succeeded
✅ ucp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ shared functional tests succeeded

vinayada1 · 2024-01-10T18:59:49Z

test/functional/shared/cli/cli_test.go

@@ -237,7 +237,8 @@ func verifyCLIBasics(ctx context.Context, t *testing.T, test shared.RPTest) {

 		done := make(chan error)
 		go func() {
-			_, err = cli.ResourceExpose(child, appName, containerName, port, 3000)
+			output, err := cli.ResourceExpose(child, appName, containerName, port, 3000)


The port could be a const

vinayada1 · 2024-01-10T19:01:53Z

test/functional/shared/cli/cli_test.go

+
+	retryClient := retryablehttp.NewClient()
+	retryClient.RetryMax = retries
+	retryClient.RetryWaitMin = 5 * time.Second


This looks much better than the old code!

# Description This is to enable CLI container port expose test with the better retry. ## Type of change - This pull request fixes a bug in Radius and has an approved issue (issue link required). Fixes: radius-project#3232 --------- Signed-off-by: Young Bu Park <[email protected]> Signed-off-by: willdavsmith <[email protected]>

youngbupark added 2 commits January 8, 2024 12:00

enable cli test

8864e99

Signed-off-by: Young Bu Park <[email protected]>

Merge branch 'main' into youngp/enable-cli-test

3d220a5

youngbupark marked this pull request as ready for review January 8, 2024 22:38

youngbupark requested review from a team as code owners January 8, 2024 22:38

youngbupark temporarily deployed to functional-tests January 8, 2024 22:38 — with GitHub Actions Inactive

fix test

de5ceaa

Signed-off-by: Young Bu Park <[email protected]>

youngbupark temporarily deployed to functional-tests January 8, 2024 22:45 — with GitHub Actions Inactive

adjust retry

73b0246

Signed-off-by: Young Bu Park <[email protected]>

youngbupark temporarily deployed to functional-tests January 8, 2024 22:54 — with GitHub Actions Inactive

revert

c8c4be8

Signed-off-by: Young Bu Park <[email protected]>

youngbupark temporarily deployed to functional-tests January 9, 2024 22:00 — with GitHub Actions Inactive

youngbupark added 2 commits January 9, 2024 14:20

add more log

a692894

Signed-off-by: Young Bu Park <[email protected]>

adjust

07a8a3c

Signed-off-by: Young Bu Park <[email protected]>

youngbupark temporarily deployed to functional-tests January 9, 2024 22:21 — with GitHub Actions Inactive

youngbupark added 2 commits January 9, 2024 15:59

improve code

94c4397

Signed-off-by: Young Bu Park <[email protected]>

reorder

59ef24f

Signed-off-by: Young Bu Park <[email protected]>

youngbupark temporarily deployed to functional-tests January 10, 2024 00:01 — with GitHub Actions Inactive

youngbupark changed the title ~~[WIP] Enable CLI container port expose test~~ Enable CLI container port expose test Jan 10, 2024

willdavsmith previously approved these changes Jan 10, 2024

View reviewed changes

adjust

60ee783

Signed-off-by: Young Bu Park <[email protected]>

youngbupark dismissed willdavsmith’s stale review via 60ee783 January 10, 2024 01:52

youngbupark temporarily deployed to functional-tests January 10, 2024 01:54 — with GitHub Actions Inactive

willdavsmith approved these changes Jan 10, 2024

View reviewed changes

vinayada1 reviewed Jan 10, 2024

View reviewed changes

vinayada1 approved these changes Jan 10, 2024

View reviewed changes

youngbupark merged commit be2bc0c into radius-project:main Jan 10, 2024
16 checks passed

youngbupark deleted the youngp/enable-cli-test branch January 10, 2024 19:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable CLI container port expose test #7000

Enable CLI container port expose test #7000

youngbupark commented Jan 8, 2024

radius-functional-tests bot commented Jan 8, 2024 •

edited

Loading

radius-functional-tests bot commented Jan 8, 2024 •

edited

Loading

radius-functional-tests bot commented Jan 8, 2024 •

edited

Loading

radius-functional-tests bot commented Jan 9, 2024 •

edited

Loading

radius-functional-tests bot commented Jan 10, 2024 •

edited

Loading

willdavsmith Jan 10, 2024

youngbupark Jan 10, 2024 •

edited

Loading

radius-functional-tests bot commented Jan 10, 2024 •

edited

Loading

vinayada1 Jan 10, 2024

vinayada1 Jan 10, 2024

Enable CLI container port expose test #7000

Enable CLI container port expose test #7000

Conversation

youngbupark commented Jan 8, 2024

Description

Type of change

radius-functional-tests bot commented Jan 8, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Jan 8, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Jan 8, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Jan 9, 2024 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Jan 10, 2024 • edited Loading

Radius functional test overview

Test Status

willdavsmith Jan 10, 2024

Choose a reason for hiding this comment

youngbupark Jan 10, 2024 • edited Loading

Choose a reason for hiding this comment

radius-functional-tests bot commented Jan 10, 2024 • edited Loading

Radius functional test overview

Test Status

vinayada1 Jan 10, 2024

Choose a reason for hiding this comment

vinayada1 Jan 10, 2024

Choose a reason for hiding this comment

radius-functional-tests bot commented Jan 8, 2024 •

edited

Loading

radius-functional-tests bot commented Jan 8, 2024 •

edited

Loading

radius-functional-tests bot commented Jan 8, 2024 •

edited

Loading

radius-functional-tests bot commented Jan 9, 2024 •

edited

Loading

radius-functional-tests bot commented Jan 10, 2024 •

edited

Loading

youngbupark Jan 10, 2024 •

edited

Loading

radius-functional-tests bot commented Jan 10, 2024 •

edited

Loading