Make the properties field of tracked resource required #6889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rynowak
reviewed
Nov 30, 2023
rynowak
reviewed
Nov 30, 2023
vinayada1
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
vinayada1
force-pushed
the
env-required
branch
from
e982e0a to
3b6ab41
Compare
vinayada1
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
vinayada1
force-pushed
the
env-required
branch
from
3b6ab41 to
22ff718
Compare
vinayada1
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
vinayada1
force-pushed
the
env-required
branch
from
22ff718 to
c9db4f8
Compare
vinayada1
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
vinayada1
force-pushed
the
env-required
branch
from
c9db4f8 to
7fd6670
Compare
kachawla
reviewed
Dec 8, 2023
pkg/corerp/api/v20231001preview/testdata/applicationresource-no-env.json
Outdated
Show resolved
Hide resolved
vinayada1
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
vinayada1
force-pushed
the
env-required
branch
from
7fd6670 to
0e27eb9
Compare
vinayada1
commented
Dec 11, 2023
vinayada1
force-pushed
the
env-required
branch
from
0e27eb9 to
d9ce0ad
Compare
vinayada1
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
vinayada1
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
vinayada1
force-pushed
the
env-required
branch
from
3b62cd6 to
3041552
Compare
vinayada1
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
youngbupark
reviewed
Dec 18, 2023
vinayada1
force-pushed
the
env-required
branch
2 times, most recently
from
328b1f5 to
40ce690
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Signed-off-by: vinayada1 <[email protected]>
vinayada1
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
vinayada1
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
youngbupark
reviewed
Jan 17, 2024
|
Can you please update the title of PR? e.g. |
ytimocin
reviewed
Jan 17, 2024
typespec/radius/v1/radius.tsp
Outdated
| @doc("Concrete tracked resource types can be created by aliasing this type using a specific property type.") | ||
| @Azure.ResourceManager.Private.armResourceInternal(TProperties) | ||
| @TypeSpec.Http.includeInapplicableMetadataInPayload(false) | ||
| model TrackedResourceRequired< |
There was a problem hiding this comment.
Can adding required to the properties be enough?
There was a problem hiding this comment.
Yes....this should give an error if someone specifies no properties
There was a problem hiding this comment.
I meant like do we need the Required in the model name? Why not just TrackedResource (with required properties) instead of TrackedResourceRequired?
There was a problem hiding this comment.
TrackedResource defined by arm specs has properties as an optional property which we do not want.
vinayada1
changed the title
vinayada1
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
vinayada1
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
youngbupark
reviewed
Jan 23, 2024
vinayada1
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
youngbupark
approved these changes
Jan 23, 2024
vinayada1
temporarily deployed
to
functional-tests
GitHub Actions
Inactive
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
sk593
pushed a commit
to sk593/radius
that referenced
this pull request
Jan 24, 2024
…t#6889) # Description Return an error if application properties or properties.environment have not been specified ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request fixes a bug in Radius and has an approved issue (issue link required). <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: radius-project#6882 ## Auto-generated summary <!-- GitHub Copilot for docs will auto-generate a summary of the PR --> <!-- copilot:all --> ### <samp>🤖[[deprecated]](https://githubnext.com/copilot-for-prs-sunset) Generated by Copilot at e982e0a</samp> ### Summary :sparkles::bug::wastebasket: <!-- 1. :sparkles: - This emoji represents the addition of new features or enhancements, such as the new custom actions, the new approval workflow, the new API version, and the new test cases. 2. :bug: - This emoji represents the fixing of bugs or errors, such as the error handling for the application conversion, and the typo in the bug report body. 3. :wastebasket: - This emoji represents the removal of unused or deprecated code, such as the `/ok-to-test` command and its related functions. --> This pull request introduces a new approval mechanism for the functional tests workflow, a new API version for the application resource with new validations, and some error handling and testing improvements. The pull request modifies the `radius-bot.js` script, the `.github` folder, the `docs` folder, and the `pkg/corerp` folder. The pull request aims to enhance the security, quality, and usability of the radius project. > _To test PRs with more care_ > _We added approval and error_ > _We saved PR number_ > _With a custom actioner_ > _And fixed a typo in bug reporter_ ### Walkthrough * Add a new API version for the application resource with new features and validations ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-d2cea876bc0e0849a386e79c8cb75b19c1a69022482c4c09b683ed4651fd673fR29-R37), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-dc0244afef9b2619d0a7837f85235bf32273a15673eb4ba1271b0ebb91f21728R51-R60), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-219a76ac16a85c0d41806b70a3554a25882b7ba8a132da7bfe169d2330e7d51cL1-R23), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-87c7befd7dc89411996a7e8259a3b11e586c14d1c80a823c863f0d069f215c17L1-R2), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-c69758755a898a2bf2a9e897278d1fbf63138f41cba6c166c11fd775aab89c53R49-R51)) - Validate that the properties and environment fields are not nil in the versioned model `pkg/corerp/api/v20231001preview/application_conversion.go` ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-d2cea876bc0e0849a386e79c8cb75b19c1a69022482c4c09b683ed4651fd673fR29-R37)) - Return an error if the conversion from the versioned to the data model fails in `pkg/corerp/datamodel/converter/application_converter.go` ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-c69758755a898a2bf2a9e897278d1fbf63138f41cba6c166c11fd775aab89c53R49-R51)) - Add test cases and test data files for the application conversion logic in `pkg/corerp/api/v20231001preview/application_conversion_test.go` and `pkg/corerp/api/v20231001preview/testdata` ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-dc0244afef9b2619d0a7837f85235bf32273a15673eb4ba1271b0ebb91f21728R51-R60), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-219a76ac16a85c0d41806b70a3554a25882b7ba8a132da7bfe169d2330e7d51cL1-R23), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-87c7befd7dc89411996a7e8259a3b11e586c14d1c80a823c863f0d069f215c17L1-R2)) * Change the trigger and approval process for the functional tests workflow ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-b94c0e124b5b65fb6fa8785928c5331547c124a96ecc225f93df9445a29a5109L47-L49), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-b94c0e124b5b65fb6fa8785928c5331547c124a96ecc225f93df9445a29a5109L79-L144), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-c79f364a9293abaaa8595776b74674e24bec6287834e63ab8aa7aec6a42f0dbcL26-R30), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-c79f364a9293abaaa8595776b74674e24bec6287834e63ab8aa7aec6a42f0dbcL98-R118), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-336842f9ad3be6e33759449fb701d721641268b444401b71c63a4e371ae91598R1-R17), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-fb0f7798935160052ab4612b954c50fb8f31d3825cce346f5feb693c418f2abaR83-R84)) - Remove the /ok-to-test command and its logic from the issue comment create event handler and the functions in `pkg/corerp/scripts/radius-bot.js` ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-b94c0e124b5b65fb6fa8785928c5331547c124a96ecc225f93df9445a29a5109L47-L49), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-b94c0e124b5b65fb6fa8785928c5331547c124a96ecc225f93df9445a29a5109L79-L144)) - Add a new workflow for approving the functional tests run for a pull request in `.github/workflows/functional-tests-approval.yaml` ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-336842f9ad3be6e33759449fb701d721641268b444401b71c63a4e371ae91598R1-R17)) - Modify the trigger conditions and the steps for setting up the checkout target for the functional tests workflow in `.github/workflows/functional-test.yaml` ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-c79f364a9293abaaa8595776b74674e24bec6287834e63ab8aa7aec6a42f0dbcL26-R30), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-c79f364a9293abaaa8595776b74674e24bec6287834e63ab8aa7aec6a42f0dbcL98-R118)) - Add a documentation section to explain the new approval process for the functional tests workflow in `docs/contributing/contributing-pull-requests/README.md` ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-fb0f7798935160052ab4612b954c50fb8f31d3825cce346f5feb693c418f2abaR83-R84)) * Add custom actions to save and download the PR number as an artifact ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-47021e538b3451866b8d8aa608664649ca716a99718bbaa9472a3af67dcd0610R1-R43), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-a06147d654903226b1bb5a4635b89fa5f7e0bd2168a3590f05bdbe65c2c0e2d4R1-R17)) - Add an action to save the PR number as an artifact in `.github/actions/save-pr-as-artifact/action.yaml` ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-a06147d654903226b1bb5a4635b89fa5f7e0bd2168a3590f05bdbe65c2c0e2d4R1-R17)) - Add an action to download the PR number from the artifact in `.github/actions/download-pr-data-artifact/action.yaml` ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-47021e538b3451866b8d8aa608664649ca716a99718bbaa9472a3af67dcd0610R1-R43)) * Fix a typo in the bug report body generated by the functional tests workflow ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-c79f364a9293abaaa8595776b74674e24bec6287834e63ab8aa7aec6a42f0dbcL579-L578)) --------- Signed-off-by: vinayada1 <[email protected]> Signed-off-by: sk593 <[email protected]>
willdavsmith
pushed a commit
to willdavsmith/radius
that referenced
this pull request
Jan 26, 2024
…t#6889) # Description Return an error if application properties or properties.environment have not been specified ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request fixes a bug in Radius and has an approved issue (issue link required). <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: radius-project#6882 ## Auto-generated summary <!-- GitHub Copilot for docs will auto-generate a summary of the PR --> <!-- copilot:all --> ### <samp>🤖[[deprecated]](https://githubnext.com/copilot-for-prs-sunset) Generated by Copilot at e982e0a</samp> ### Summary :sparkles::bug::wastebasket: <!-- 1. :sparkles: - This emoji represents the addition of new features or enhancements, such as the new custom actions, the new approval workflow, the new API version, and the new test cases. 2. :bug: - This emoji represents the fixing of bugs or errors, such as the error handling for the application conversion, and the typo in the bug report body. 3. :wastebasket: - This emoji represents the removal of unused or deprecated code, such as the `/ok-to-test` command and its related functions. --> This pull request introduces a new approval mechanism for the functional tests workflow, a new API version for the application resource with new validations, and some error handling and testing improvements. The pull request modifies the `radius-bot.js` script, the `.github` folder, the `docs` folder, and the `pkg/corerp` folder. The pull request aims to enhance the security, quality, and usability of the radius project. > _To test PRs with more care_ > _We added approval and error_ > _We saved PR number_ > _With a custom actioner_ > _And fixed a typo in bug reporter_ ### Walkthrough * Add a new API version for the application resource with new features and validations ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-d2cea876bc0e0849a386e79c8cb75b19c1a69022482c4c09b683ed4651fd673fR29-R37), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-dc0244afef9b2619d0a7837f85235bf32273a15673eb4ba1271b0ebb91f21728R51-R60), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-219a76ac16a85c0d41806b70a3554a25882b7ba8a132da7bfe169d2330e7d51cL1-R23), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-87c7befd7dc89411996a7e8259a3b11e586c14d1c80a823c863f0d069f215c17L1-R2), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-c69758755a898a2bf2a9e897278d1fbf63138f41cba6c166c11fd775aab89c53R49-R51)) - Validate that the properties and environment fields are not nil in the versioned model `pkg/corerp/api/v20231001preview/application_conversion.go` ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-d2cea876bc0e0849a386e79c8cb75b19c1a69022482c4c09b683ed4651fd673fR29-R37)) - Return an error if the conversion from the versioned to the data model fails in `pkg/corerp/datamodel/converter/application_converter.go` ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-c69758755a898a2bf2a9e897278d1fbf63138f41cba6c166c11fd775aab89c53R49-R51)) - Add test cases and test data files for the application conversion logic in `pkg/corerp/api/v20231001preview/application_conversion_test.go` and `pkg/corerp/api/v20231001preview/testdata` ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-dc0244afef9b2619d0a7837f85235bf32273a15673eb4ba1271b0ebb91f21728R51-R60), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-219a76ac16a85c0d41806b70a3554a25882b7ba8a132da7bfe169d2330e7d51cL1-R23), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-87c7befd7dc89411996a7e8259a3b11e586c14d1c80a823c863f0d069f215c17L1-R2)) * Change the trigger and approval process for the functional tests workflow ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-b94c0e124b5b65fb6fa8785928c5331547c124a96ecc225f93df9445a29a5109L47-L49), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-b94c0e124b5b65fb6fa8785928c5331547c124a96ecc225f93df9445a29a5109L79-L144), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-c79f364a9293abaaa8595776b74674e24bec6287834e63ab8aa7aec6a42f0dbcL26-R30), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-c79f364a9293abaaa8595776b74674e24bec6287834e63ab8aa7aec6a42f0dbcL98-R118), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-336842f9ad3be6e33759449fb701d721641268b444401b71c63a4e371ae91598R1-R17), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-fb0f7798935160052ab4612b954c50fb8f31d3825cce346f5feb693c418f2abaR83-R84)) - Remove the /ok-to-test command and its logic from the issue comment create event handler and the functions in `pkg/corerp/scripts/radius-bot.js` ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-b94c0e124b5b65fb6fa8785928c5331547c124a96ecc225f93df9445a29a5109L47-L49), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-b94c0e124b5b65fb6fa8785928c5331547c124a96ecc225f93df9445a29a5109L79-L144)) - Add a new workflow for approving the functional tests run for a pull request in `.github/workflows/functional-tests-approval.yaml` ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-336842f9ad3be6e33759449fb701d721641268b444401b71c63a4e371ae91598R1-R17)) - Modify the trigger conditions and the steps for setting up the checkout target for the functional tests workflow in `.github/workflows/functional-test.yaml` ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-c79f364a9293abaaa8595776b74674e24bec6287834e63ab8aa7aec6a42f0dbcL26-R30), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-c79f364a9293abaaa8595776b74674e24bec6287834e63ab8aa7aec6a42f0dbcL98-R118)) - Add a documentation section to explain the new approval process for the functional tests workflow in `docs/contributing/contributing-pull-requests/README.md` ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-fb0f7798935160052ab4612b954c50fb8f31d3825cce346f5feb693c418f2abaR83-R84)) * Add custom actions to save and download the PR number as an artifact ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-47021e538b3451866b8d8aa608664649ca716a99718bbaa9472a3af67dcd0610R1-R43), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-a06147d654903226b1bb5a4635b89fa5f7e0bd2168a3590f05bdbe65c2c0e2d4R1-R17)) - Add an action to save the PR number as an artifact in `.github/actions/save-pr-as-artifact/action.yaml` ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-a06147d654903226b1bb5a4635b89fa5f7e0bd2168a3590f05bdbe65c2c0e2d4R1-R17)) - Add an action to download the PR number from the artifact in `.github/actions/download-pr-data-artifact/action.yaml` ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-47021e538b3451866b8d8aa608664649ca716a99718bbaa9472a3af67dcd0610R1-R43)) * Fix a typo in the bug report body generated by the functional tests workflow ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-c79f364a9293abaaa8595776b74674e24bec6287834e63ab8aa7aec6a42f0dbcL579-L578)) --------- Signed-off-by: vinayada1 <[email protected]>
willdavsmith
pushed a commit
to willdavsmith/radius
that referenced
this pull request
Mar 4, 2024
…t#6889) # Description Return an error if application properties or properties.environment have not been specified ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request fixes a bug in Radius and has an approved issue (issue link required). <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: radius-project#6882 ## Auto-generated summary <!-- GitHub Copilot for docs will auto-generate a summary of the PR --> <!-- copilot:all --> ### <samp>🤖[[deprecated]](https://githubnext.com/copilot-for-prs-sunset) Generated by Copilot at e982e0a</samp> ### Summary :sparkles::bug::wastebasket: <!-- 1. :sparkles: - This emoji represents the addition of new features or enhancements, such as the new custom actions, the new approval workflow, the new API version, and the new test cases. 2. :bug: - This emoji represents the fixing of bugs or errors, such as the error handling for the application conversion, and the typo in the bug report body. 3. :wastebasket: - This emoji represents the removal of unused or deprecated code, such as the `/ok-to-test` command and its related functions. --> This pull request introduces a new approval mechanism for the functional tests workflow, a new API version for the application resource with new validations, and some error handling and testing improvements. The pull request modifies the `radius-bot.js` script, the `.github` folder, the `docs` folder, and the `pkg/corerp` folder. The pull request aims to enhance the security, quality, and usability of the radius project. > _To test PRs with more care_ > _We added approval and error_ > _We saved PR number_ > _With a custom actioner_ > _And fixed a typo in bug reporter_ ### Walkthrough * Add a new API version for the application resource with new features and validations ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-d2cea876bc0e0849a386e79c8cb75b19c1a69022482c4c09b683ed4651fd673fR29-R37), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-dc0244afef9b2619d0a7837f85235bf32273a15673eb4ba1271b0ebb91f21728R51-R60), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-219a76ac16a85c0d41806b70a3554a25882b7ba8a132da7bfe169d2330e7d51cL1-R23), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-87c7befd7dc89411996a7e8259a3b11e586c14d1c80a823c863f0d069f215c17L1-R2), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-c69758755a898a2bf2a9e897278d1fbf63138f41cba6c166c11fd775aab89c53R49-R51)) - Validate that the properties and environment fields are not nil in the versioned model `pkg/corerp/api/v20231001preview/application_conversion.go` ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-d2cea876bc0e0849a386e79c8cb75b19c1a69022482c4c09b683ed4651fd673fR29-R37)) - Return an error if the conversion from the versioned to the data model fails in `pkg/corerp/datamodel/converter/application_converter.go` ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-c69758755a898a2bf2a9e897278d1fbf63138f41cba6c166c11fd775aab89c53R49-R51)) - Add test cases and test data files for the application conversion logic in `pkg/corerp/api/v20231001preview/application_conversion_test.go` and `pkg/corerp/api/v20231001preview/testdata` ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-dc0244afef9b2619d0a7837f85235bf32273a15673eb4ba1271b0ebb91f21728R51-R60), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-219a76ac16a85c0d41806b70a3554a25882b7ba8a132da7bfe169d2330e7d51cL1-R23), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-87c7befd7dc89411996a7e8259a3b11e586c14d1c80a823c863f0d069f215c17L1-R2)) * Change the trigger and approval process for the functional tests workflow ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-b94c0e124b5b65fb6fa8785928c5331547c124a96ecc225f93df9445a29a5109L47-L49), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-b94c0e124b5b65fb6fa8785928c5331547c124a96ecc225f93df9445a29a5109L79-L144), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-c79f364a9293abaaa8595776b74674e24bec6287834e63ab8aa7aec6a42f0dbcL26-R30), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-c79f364a9293abaaa8595776b74674e24bec6287834e63ab8aa7aec6a42f0dbcL98-R118), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-336842f9ad3be6e33759449fb701d721641268b444401b71c63a4e371ae91598R1-R17), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-fb0f7798935160052ab4612b954c50fb8f31d3825cce346f5feb693c418f2abaR83-R84)) - Remove the /ok-to-test command and its logic from the issue comment create event handler and the functions in `pkg/corerp/scripts/radius-bot.js` ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-b94c0e124b5b65fb6fa8785928c5331547c124a96ecc225f93df9445a29a5109L47-L49), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-b94c0e124b5b65fb6fa8785928c5331547c124a96ecc225f93df9445a29a5109L79-L144)) - Add a new workflow for approving the functional tests run for a pull request in `.github/workflows/functional-tests-approval.yaml` ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-336842f9ad3be6e33759449fb701d721641268b444401b71c63a4e371ae91598R1-R17)) - Modify the trigger conditions and the steps for setting up the checkout target for the functional tests workflow in `.github/workflows/functional-test.yaml` ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-c79f364a9293abaaa8595776b74674e24bec6287834e63ab8aa7aec6a42f0dbcL26-R30), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-c79f364a9293abaaa8595776b74674e24bec6287834e63ab8aa7aec6a42f0dbcL98-R118)) - Add a documentation section to explain the new approval process for the functional tests workflow in `docs/contributing/contributing-pull-requests/README.md` ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-fb0f7798935160052ab4612b954c50fb8f31d3825cce346f5feb693c418f2abaR83-R84)) * Add custom actions to save and download the PR number as an artifact ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-47021e538b3451866b8d8aa608664649ca716a99718bbaa9472a3af67dcd0610R1-R43), [link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-a06147d654903226b1bb5a4635b89fa5f7e0bd2168a3590f05bdbe65c2c0e2d4R1-R17)) - Add an action to save the PR number as an artifact in `.github/actions/save-pr-as-artifact/action.yaml` ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-a06147d654903226b1bb5a4635b89fa5f7e0bd2168a3590f05bdbe65c2c0e2d4R1-R17)) - Add an action to download the PR number from the artifact in `.github/actions/download-pr-data-artifact/action.yaml` ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-47021e538b3451866b8d8aa608664649ca716a99718bbaa9472a3af67dcd0610R1-R43)) * Fix a typo in the bug report body generated by the functional tests workflow ([link](https://github.com/radius-project/radius/pull/6889/files?diff=unified&w=0#diff-c79f364a9293abaaa8595776b74674e24bec6287834e63ab8aa7aec6a42f0dbcL579-L578)) --------- Signed-off-by: vinayada1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Return an error if application properties or properties.environment have not been specified
Type of change
Fixes: #6882
Auto-generated summary
🤖[deprecated] Generated by Copilot at e982e0a
Summary
✨🐛🗑️
This pull request introduces a new approval mechanism for the functional tests workflow, a new API version for the application resource with new validations, and some error handling and testing improvements. The pull request modifies the
radius-bot.jsscript, the.githubfolder, thedocsfolder, and thepkg/corerpfolder. The pull request aims to enhance the security, quality, and usability of the radius project.Walkthrough
pkg/corerp/api/v20231001preview/application_conversion.go(link)pkg/corerp/datamodel/converter/application_converter.go(link)pkg/corerp/api/v20231001preview/application_conversion_test.goandpkg/corerp/api/v20231001preview/testdata(link, link, link)pkg/corerp/scripts/radius-bot.js(link, link).github/workflows/functional-tests-approval.yaml(link).github/workflows/functional-test.yaml(link, link)docs/contributing/contributing-pull-requests/README.md(link).github/actions/save-pr-as-artifact/action.yaml(link).github/actions/download-pr-data-artifact/action.yaml(link)