Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Add logs for kubernetes events #6655

Closed
wants to merge 1 commit into from
Closed

Conversation

sk593
Copy link
Contributor

@sk593 sk593 commented Nov 7, 2023

Description

Adding logs to track pod failures during schedule func test runs

Type of change

  • This pull request fixes a bug in Radius and has an approved issue (issue link required).
  • This pull request adds or changes features of Radius and has an approved issue (issue link required).
  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Auto-generated summary

🤖 Generated by Copilot at 4b779ec

Summary

🐛🚀🔧

Add error handling and debugging to functional-test workflow. Upload pod logs and events as an artifact if .github/workflows/functional-test.yaml fails.

When the test workflow fails
We don't give up or bail
We grab the logs and events
From the publish-tf-recipes step

Walkthrough

  • Add an id to the recipe publishing step to enable conditional execution of subsequent steps (link)
  • Add two steps to collect and upload pod logs and events as an artifact if the recipe publishing step fails (link)

Copy link

github-actions bot commented Nov 7, 2023

Test Results

2 980 tests  ±0   2 968 ✔️ ±0   2m 39s ⏱️ -11s
   256 suites ±0        12 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit 4b779ec. ± Comparison against base commit 97e22b8.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.
github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/2491bf2d-83f6-45ca-9c69-4022c99a1c55
github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/2491bf2d-83f6-45ca-9c69-4022c99a1c55#01
github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/1e266454-e59e-4a97-a3dd-9ecffe2db377
github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/1e266454-e59e-4a97-a3dd-9ecffe2db377#01

Copy link

github-actions bot commented Nov 7, 2023

64.9

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 64.9 %
  • main branch coverage: 64.9 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@sk593
Copy link
Contributor Author

sk593 commented Nov 16, 2023

Moving to forks and addressing here: #6793

@sk593 sk593 closed this Nov 16, 2023
@youngbupark youngbupark deleted the shruku/publish-tf-recipes branch February 27, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant