-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate cloud/non-cloud tests #6587
Conversation
Test Results2 975 tests ±0 2 963 ✔️ ±0 2m 47s ⏱️ -11s Results for commit df845df. ± Comparison against base commit d680f7d. This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
7561093
to
5c7f2bb
Compare
b5e5f17
to
a448e6a
Compare
⌛ Starting datastoresrp functional tests... ⌛ Starting ucp functional tests... |
/ok-to-test |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
/ok-to-test |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
a32cb7e
to
cb9581b
Compare
/ok-to-test |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
⌛ Starting datastoresrp functional tests... ⌛ Starting msgrp functional tests... |
cb9581b
to
64538c2
Compare
⌛ Starting daprrp functional tests... ⌛ Starting datastoresrp functional tests... |
⌛ Starting ucp functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
/ok-to-test |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
31152af
to
9597e44
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
/ok-to-test |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Looks like /ok-to-test still runs the old workflow and a PR merge would be needed for it to run only the cloud tests |
Signed-off-by: vinayada1 <[email protected]>
9597e44
to
fc72b0f
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
/ok-to-test |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for kicking this off!
As I mentioned in the design discussion, from this PR it looks like all the UCP tests only run on cloud resources, in which case we should add more tests for UCP that can run as a part of functional tests workflow. Can you please confirm this?
This pull request has been automatically marked as stale because it has been inactive for 90 days. Remove stale label or comment or this PR will be closed in 7 days. |
Description
Currently, all the functional tests run only with an approved "/ok-to-test" command. Only tests that deploy cloud resources or publish stuff really require an approval. This PR separates out the tests that do not need an approval to run as a part of the regular build workflow. The /ok-to-test command will now run only tests that deploy cloud resources
Type of change
Fixes: #6588
Auto-generated summary
🤖 Generated by Copilot at efaffae
Summary
🧪☁️🛠️
This pull request adds support for running functional tests that require cloud resources for the radius project. It modifies the GitHub workflows and the make targets to run different types of tests. It also moves the existing cloud-based tests to a new
test/functional-cloud
directory and adds new test files for the extender and Terraform recipe features.Walkthrough
test-functional-cloud
directory (link, link, link)test-functional-cloud/README.md
file (link)test/functional-cloud/shared/resources/extender_test.go
, link)test/functional-cloud/shared/resources/recipe_terraform_test.go
, link)test/functional
totest/functional-cloud
to reflect the cloud resource requirement (link, link, link, link, link, link, link, link, link, link, link, link, link, link)