Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graph alias for rad app connections #6489

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Conversation

AaronCrawfis
Copy link
Contributor

@AaronCrawfis AaronCrawfis commented Oct 16, 2023

Description

This PR adds an alias for rad app graph that points to rad app connections.

It is a temporary update until we permanently update the command.

Type of change

  • This pull request fixes a bug in Radius and has an approved issue (issue link required).

Partially addresses: #6473

Auto-generated summary

🤖 Generated by Copilot at b5b8f0c

Summary

✨♻️📝

Add "graph" alias for "connections" command in pkg/cli/cmd/app/connections/connections.go. This enables users to view a graphical representation of the connections for an application.

NewCommand adds
alias for connections
graph in the spring

Walkthrough

  • Add an alias "graph" for the "connections" command (link)

Signed-off-by: Aaron Crawfis <[email protected]>
@AaronCrawfis AaronCrawfis requested review from a team as code owners October 16, 2023 23:07
Signed-off-by: Aaron Crawfis <[email protected]>
@github-actions
Copy link

github-actions bot commented Oct 16, 2023

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref refs/pull/6489/merge
Unique ID 06f82ecb70
Image tag pr-06f82ecb70
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.11.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location radiusdev.azurecr.io/test/functional/shared/recipes/<name>:pr-06f82ecb70
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-06f82ecb70
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-06f82ecb70
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-06f82ecb70
  • deployment-engine test image location: radius.azurecr.io/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting samples functional tests...
✅ ucp functional tests succeeded
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ daprrp functional tests succeeded
✅ shared functional tests succeeded
⌛ Starting datastoresrp functional tests...
✅ datastoresrp functional tests succeeded

@github-actions
Copy link

github-actions bot commented Oct 16, 2023

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref refs/pull/6489/merge
Unique ID 6703489644
Image tag pr-6703489644
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.11.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location radiusdev.azurecr.io/test/functional/shared/recipes/<name>:pr-6703489644
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-6703489644
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-6703489644
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-6703489644
  • deployment-engine test image location: radius.azurecr.io/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting samples functional tests...
⌛ Starting ucp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting msgrp functional tests...
✅ ucp functional tests succeeded
✅ samples functional tests succeeded
✅ msgrp functional tests succeeded
✅ daprrp functional tests succeeded
✅ shared functional tests succeeded
⌛ Starting datastoresrp functional tests...
✅ datastoresrp functional tests succeeded

Signed-off-by: Aaron Crawfis <[email protected]>
@github-actions
Copy link

github-actions bot commented Oct 16, 2023

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref refs/pull/6489/merge
Unique ID 414dccae30
Image tag pr-414dccae30
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.11.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location radiusdev.azurecr.io/test/functional/shared/recipes/<name>:pr-414dccae30
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-414dccae30
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-414dccae30
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-414dccae30
  • deployment-engine test image location: radius.azurecr.io/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting samples functional tests...
⌛ Starting daprrp functional tests...
✅ ucp functional tests succeeded
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ daprrp functional tests succeeded
✅ shared functional tests succeeded
⌛ Starting datastoresrp functional tests...
✅ datastoresrp functional tests succeeded

@github-actions
Copy link

github-actions bot commented Oct 16, 2023

Test Results

3 018 tests  ±0   3 009 ✔️ ±0   3m 0s ⏱️ -3s
   256 suites ±0          9 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit 8b1162d. ± Comparison against base commit 32391b0.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.
github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/77f518b4-09cf-47f6-b65e-df2b254bd113
github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/77f518b4-09cf-47f6-b65e-df2b254bd113#01
github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/a07ebcfa-494e-4221-b249-dacb677e4db6
github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/a07ebcfa-494e-4221-b249-dacb677e4db6#01

♻️ This comment has been updated with latest results.

@github-actions
Copy link

65.7

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 65.7 %
  • main branch coverage: 65.7 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@github-actions
Copy link

github-actions bot commented Oct 17, 2023

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref refs/pull/6489/merge
Unique ID cee216e3fd
Image tag pr-cee216e3fd
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.11.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location radiusdev.azurecr.io/test/functional/shared/recipes/<name>:pr-cee216e3fd
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-cee216e3fd
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-cee216e3fd
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-cee216e3fd
  • deployment-engine test image location: radius.azurecr.io/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting kubernetes functional tests...
⌛ Starting ucp functional tests...
⌛ Starting shared functional tests...
⌛ Starting samples functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting msgrp functional tests...
✅ ucp functional tests succeeded
✅ kubernetes functional tests succeeded
✅ samples functional tests succeeded
✅ daprrp functional tests succeeded
✅ msgrp functional tests succeeded
✅ shared functional tests succeeded
⌛ Starting datastoresrp functional tests...
✅ datastoresrp functional tests succeeded

@github-actions
Copy link

65.6

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 65.6 %
  • main branch coverage: 65.6 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@AaronCrawfis AaronCrawfis merged commit 047da70 into main Oct 17, 2023
26 of 27 checks passed
@AaronCrawfis AaronCrawfis deleted the aacrawfi/rad-app-graph branch October 17, 2023 05:24
sk593 pushed a commit that referenced this pull request Oct 17, 2023
# Description

This PR adds an alias for `rad app graph` that points to `rad app
connections`.

It is a temporary update until we permanently update the command.

## Type of change

- This pull request fixes a bug in Radius and has an approved issue
(issue link required).

Partially addresses: #6473

## Auto-generated summary

<!--
GitHub Copilot for docs will auto-generate a summary of the PR
-->

<!--
copilot:all
-->
### <samp>🤖 Generated by Copilot at b5b8f0c</samp>

### Summary
:sparkles::recycle::memo:

<!--
1. :sparkles: This emoji represents the addition of a new feature or
enhancement, and can be used to highlight the main purpose of the pull
request, which is to implement a graphical view of the connections.
2. :recycle: This emoji represents the refactoring or improvement of
existing code, and can be used to indicate the modification of the
`NewCommand` function to add an alias for the existing command.
3. :memo: This emoji represents the addition or update of documentation,
and can be used to indicate the changes to the command help text and the
README file that explain the new alias and feature.
-->
Add "graph" alias for "connections" command in
`pkg/cli/cmd/app/connections/connections.go`. This enables users to view
a graphical representation of the connections for an application.

> _`NewCommand` adds_
> _alias for connections_
> _graph in the spring_

### Walkthrough
* Add an alias "graph" for the "connections" command
([link](https://github.com/radius-project/radius/pull/6489/files?diff=unified&w=0#diff-eb0083d8df9479acb2d5b36bf150aa410e371a26a01619d09c933a73994aa563L27-R31))

---------

Signed-off-by: Aaron Crawfis <[email protected]>
(cherry picked from commit 047da70)
sk593 pushed a commit that referenced this pull request Oct 18, 2023
# Description

This PR adds an alias for `rad app graph` that points to `rad app
connections`.

It is a temporary update until we permanently update the command.

## Type of change

- This pull request fixes a bug in Radius and has an approved issue
(issue link required).

Partially addresses: #6473

## Auto-generated summary

<!--
GitHub Copilot for docs will auto-generate a summary of the PR
-->

<!--
copilot:all
-->
### <samp>🤖 Generated by Copilot at b5b8f0c</samp>

### Summary
:sparkles::recycle::memo:

<!--
1. :sparkles: This emoji represents the addition of a new feature or
enhancement, and can be used to highlight the main purpose of the pull
request, which is to implement a graphical view of the connections.
2. :recycle: This emoji represents the refactoring or improvement of
existing code, and can be used to indicate the modification of the
`NewCommand` function to add an alias for the existing command.
3. :memo: This emoji represents the addition or update of documentation,
and can be used to indicate the changes to the command help text and the
README file that explain the new alias and feature.
-->
Add "graph" alias for "connections" command in
`pkg/cli/cmd/app/connections/connections.go`. This enables users to view
a graphical representation of the connections for an application.

> _`NewCommand` adds_
> _alias for connections_
> _graph in the spring_

### Walkthrough
* Add an alias "graph" for the "connections" command
([link](https://github.com/radius-project/radius/pull/6489/files?diff=unified&w=0#diff-eb0083d8df9479acb2d5b36bf150aa410e371a26a01619d09c933a73994aa563L27-R31))

---------

Signed-off-by: Aaron Crawfis <[email protected]>
(cherry picked from commit 047da70)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants