Pagination causing Dev Recipes to not be installed and Controller Pod permission fix #6466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Test Results3 006 tests ±0 2 997 ✔️ ±0 2m 41s ⏱️ +18s Results for commit d657892. ± Comparison against base commit 5756b33. This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both. |
|
For the detailed report, please go to
|
sk593
reviewed
Oct 13, 2023
sk593
reviewed
Oct 13, 2023
...ntributing/contributing-code/contributing-code-control-plane/running-controlplane-locally.md
Show resolved
Hide resolved
sk593
approved these changes
Oct 13, 2023
shalabhms
approved these changes
Oct 13, 2023
sk593
pushed a commit
that referenced
this pull request
Oct 13, 2023
… permission fix (#6466) # Description Bugs fixed: 1. Pagination causing Dev Recipes to not be installed 2. Controller Pod permission fix ## Type of change - This pull request fixes a bug in Radius and has an approved issue (issue link required). Fixes: #6464 #6465 ## Auto-generated summary <!-- copilot:all --> ### <samp>🤖 Generated by Copilot at d657892</samp> ### Summary 🚀🐛📝 <!-- 1. 🚀 - This emoji represents the functional change to the RBAC rules, which aligns them with the new domain name of the CRDs. This is a significant change that affects the authorization of the controller and the custom resources. The rocket emoji conveys the idea of launching or deploying something new or updated. 2. 🐛 - This emoji represents the functional change to the recipe fetching logic, which fixes a bug that prevented some recipes from being retrieved. This is a change that improves the functionality and reliability of the CLI. The bug emoji conveys the idea of fixing or squashing a bug or an issue. 3. 📝 - This emoji represents the formatting and stylistic changes to the launch.json and contributing-code-controlplane-locally.md files. These are changes that do not affect the functionality or behavior of the code, but rather improve its readability and consistency. The memo emoji conveys the idea of writing or editing something, such as documentation or configuration. --> This pull request makes some formatting and stylistic improvements to the `.vscode/launch.json` and the `docs/contributing` files. It also fixes a bug in the `pkg/cli/cmd/radinit/recipe.go` file that prevented some recipes from being fetched from the registry. Additionally, it updates the RBAC rules in the `deploy/Chart/templates/controller/rbac.yaml` file to match the new domain name of the Radius CRDs. > _Sing, O Muse, of the valiant deeds of the Rad app developers_ > _Who, with skill and wisdom, updated the `apiGroups` of their CRDs_ > _And who, with cunning and craft, fixed the bug in the `GetDevRecipes` function_ > _And who, with care and grace, polished the files of their code and docs_ ### Walkthrough * Align RBAC rules with new CRD domain name ([link](https://github.com/radius-project/radius/pull/6466/files?diff=unified&w=0#diff-0eb83f283dad161ea34486e10ead98d0c74fcaa93a13e8d182113ebb8de66c63L36-R36)) * Fix bug where some recipes were not fetched from registry ([link](https://github.com/radius-project/radius/pull/6466/files?diff=unified&w=0#diff-8d95f3c1fe28429c99ace05511baa39ad8209147381755da6007c8781ed17be2L66-R78)) * Add trailing comma to JSON array for consistency and ease of editing ([link](https://github.com/radius-project/radius/pull/6466/files?diff=unified&w=0#diff-bd5430ee7c51dc892a67b3f2829d1f5b6d223f0fd48b82322cfd45baf9f5e945L86-R91)) * Remove empty line and trailing whitespace from files ([link](https://github.com/radius-project/radius/pull/6466/files?diff=unified&w=0#diff-bd5430ee7c51dc892a67b3f2829d1f5b6d223f0fd48b82322cfd45baf9f5e945L7), [link](https://github.com/radius-project/radius/pull/6466/files?diff=unified&w=0#diff-9e2fd80b379a42830faf06edccddb5228ec9ade05d089345244394619fb9e805L17-R17)) * Add angle brackets around URLs in Markdown file ([link](https://github.com/radius-project/radius/pull/6466/files?diff=unified&w=0#diff-9e2fd80b379a42830faf06edccddb5228ec9ade05d089345244394619fb9e805L30-R37)) (cherry picked from commit af53d20)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bugs fixed:
Type of change
Fixes: #6464 #6465
Auto-generated summary
🤖 Generated by Copilot at d657892
Summary
🚀🐛📝
This pull request makes some formatting and stylistic improvements to the
.vscode/launch.jsonand thedocs/contributingfiles. It also fixes a bug in thepkg/cli/cmd/radinit/recipe.gofile that prevented some recipes from being fetched from the registry. Additionally, it updates the RBAC rules in thedeploy/Chart/templates/controller/rbac.yamlfile to match the new domain name of the Radius CRDs.Walkthrough