Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT REVIEW] Simplify API Registration - Applications.Datastores #6414

Closed
wants to merge 1 commit into from
Closed

[DO NOT REVIEW] Simplify API Registration - Applications.Datastores #6414

wants to merge 1 commit into from

Conversation

lakshmimsft
Copy link
Contributor

@lakshmimsft lakshmimsft commented Sep 28, 2023 •
edited by ghost
Loading

Description

Updating routes, operations and resource provider registration to be inline with recent updates for Applications.Core resource provider

Type of change

Fixes: Part of #6269

Auto-generated summary

🤖 Generated by Copilot at 0db6559

Summary

🔄🚀🧹

This pull request adds support for Applications.Datastores resources to the applications-rp command and the datastoresrp package. It also removes redundant or obsolete operations and tests from the portableresources package and updates the port numbers for the Applications.Datastores endpoint in various files.

We're setting up the datastores for the applications
We're changing ports and operations for the applications-rp
We're testing all the routers and the converters
We're heaving on the line on the count of three

Walkthrough

  • Register and set up the Applications.Datastores resource provider namespace and its resources using the datastoresrp/setup package (link, link, link, link)
  • Test the routers for the Applications.Datastores resource provider using mock objects and the rpctest package (link)
  • Remove the Applications.Datastores operations from the portableresources/frontend/handler/getoperations.go file to avoid duplication (link, link, link)
  • Update the expected number of operations in the portableresources/frontend/handler/getoperations_test.go file (link)
  • Remove or comment out the test cases for the Applications.Datastores operations from the portableresources/frontend/handler/routes_test.go file, as they are handled by the datastoresrp handler (link, link, link, link)
  • Align the port for the Applications.Datastores endpoint with the applications-rp command in the ucpd/ucp-self-hosted-dev.yaml and deploy/Chart/templates/ucp/configmaps.yaml files (link, link)
  • Update the port for the Applications.Datastores endpoint in the docs/contributing/contributing-code/contributing-code-control-plane/configSettings.md file (link)

@lakshmimsft lakshmimsft requested review from a team as code owners September 28, 2023 17:23
@github-actions
Copy link

github-actions bot commented Sep 28, 2023 •
edited
Loading

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref refs/pull/6414/merge
Unique ID d2c84c6e9d
Image tag pr-d2c84c6e9d
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.11.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location radiusdev.azurecr.io/test/functional/shared/recipes/<name>:pr-d2c84c6e9d
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-d2c84c6e9d
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-d2c84c6e9d
  • deployment-engine test image location: radius.azurecr.io/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting samples functional tests...
❌ datastoresrp functional test failed. Please check the logs for more details
✅ samples functional tests succeeded

@github-actions
Copy link

github-actions bot commented Sep 28, 2023 •
edited
Loading

Test Results

2 960 tests   - 21   2 951 ✔️  - 21   2m 27s ⏱️ +15s
   253 suites +  1          9 💤 ±  0 
       1 files   ±  0          0 ❌ ±  0 

Results for commit 77bbae8. ± Comparison against base commit 2176ab8.

This pull request removes 45 and adds 24 tests. Note that renamed tests count towards both. 
github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/5a55fd8a-5593-40fe-8fb9-a9e617200630
github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/5a55fd8a-5593-40fe-8fb9-a9e617200630#01
github.com/radius-project/radius/pkg/portableresources/frontend/handler ‑ TestHandlers/Azure/DELETE|/resourcegroups/testrg/providers/applications.datastores/mongodatabases/mongo
github.com/radius-project/radius/pkg/portableresources/frontend/handler ‑ TestHandlers/Azure/DELETE|/resourcegroups/testrg/providers/applications.datastores/rediscaches/redis
github.com/radius-project/radius/pkg/portableresources/frontend/handler ‑ TestHandlers/Azure/DELETE|/resourcegroups/testrg/providers/applications.datastores/sqldatabases/sql
github.com/radius-project/radius/pkg/portableresources/frontend/handler ‑ TestHandlers/Azure/GET|/providers/applications.datastores/mongodatabases
github.com/radius-project/radius/pkg/portableresources/frontend/handler ‑ TestHandlers/Azure/GET|/providers/applications.datastores/operations
github.com/radius-project/radius/pkg/portableresources/frontend/handler ‑ TestHandlers/Azure/GET|/providers/applications.datastores/rediscaches
github.com/radius-project/radius/pkg/portableresources/frontend/handler ‑ TestHandlers/Azure/GET|/providers/applications.datastores/sqldatabases
github.com/radius-project/radius/pkg/portableresources/frontend/handler ‑ TestHandlers/Azure/GET|/resourcegroups/testrg/providers/applications.datastores/mongodatabases
…

github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/6c6abe1e-2452-4803-80e4-379cfedac498
github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/6c6abe1e-2452-4803-80e4-379cfedac498#01
github.com/radius-project/radius/pkg/datastoresrp/setup ‑ TestRouter
github.com/radius-project/radius/pkg/datastoresrp/setup ‑ TestRouter/DELETE|/resourcegroups/testrg/providers/applications.datastores/mongodatabases/mongo
github.com/radius-project/radius/pkg/datastoresrp/setup ‑ TestRouter/DELETE|/resourcegroups/testrg/providers/applications.datastores/rediscaches/redis
github.com/radius-project/radius/pkg/datastoresrp/setup ‑ TestRouter/DELETE|/resourcegroups/testrg/providers/applications.datastores/sqldatabases/sql
github.com/radius-project/radius/pkg/datastoresrp/setup ‑ TestRouter/GET|/providers/applications.datastores/mongodatabases
github.com/radius-project/radius/pkg/datastoresrp/setup ‑ TestRouter/GET|/providers/applications.datastores/rediscaches
github.com/radius-project/radius/pkg/datastoresrp/setup ‑ TestRouter/GET|/providers/applications.datastores/sqldatabases
github.com/radius-project/radius/pkg/datastoresrp/setup ‑ TestRouter/GET|/resourcegroups/testrg/providers/applications.datastores/mongodatabases
…

♻️ This comment has been updated with latest results.

@lakshmimsft lakshmimsft force-pushed the lakshmimsft/dsapiregistration branch from 0db6559 to 77bbae8 Compare September 28, 2023 18:23
@github-actions
Copy link

github-actions bot commented Sep 28, 2023 •
edited
Loading

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref refs/pull/6414/merge
Unique ID c283f1d292
Image tag pr-c283f1d292
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.11.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location radiusdev.azurecr.io/test/functional/shared/recipes/<name>:pr-c283f1d292
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-c283f1d292
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-c283f1d292
  • deployment-engine test image location: radius.azurecr.io/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting shared functional tests...
⌛ Starting ucp functional tests...
⌛ Starting msgrp functional tests...
❌ datastoresrp functional test failed. Please check the logs for more details

@github-actions
Copy link

66.2

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 66.2 %
  • main branch coverage: 66.2 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@lakshmimsft
Copy link
Contributor Author

Closing this. This was picked up post Public Release and is in new PR: #6522

@youngbupark youngbupark deleted the lakshmimsft/dsapiregistration branch February 27, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lakshmimsft