Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test: Test_Render_Multiple_Routes #6345

Closed
wants to merge 2 commits into from

Conversation

willdavsmith
Copy link
Contributor

@willdavsmith willdavsmith commented Sep 25, 2023

Description

  • Fixing flakt test

Type of change

  • This pull request fixes a bug in Radius and has an approved issue (issue link required).

Fixes: #6263

Auto-generated summary

🤖 Generated by Copilot at 2a9b619

Summary

📦🔧🧪

Improved test reliability for validateHTTPProxy function by sorting dependencies with slices.Sort in render_test.go.

Sing, O Muse, of the cunning code review
That sorted the dependencies of proxies
With the help of slices, a package new
And improved the tests of validateHTTPProxy.

Walkthrough

  • Import the slices package from the x/exp module to sort slices of any type (link)
  • Use the slices.Sort function to sort the dependencies of the expected and actual HTTPProxy resources in the validateHTTPProxy test function (link)

@willdavsmith willdavsmith requested review from a team as code owners September 25, 2023 14:40
@github-actions
Copy link

github-actions bot commented Sep 25, 2023

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref refs/pull/6345/merge
Unique ID 9d19b71802
Image tag pr-9d19b71802
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.11.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location radiusdev.azurecr.io/test/functional/shared/recipes/<name>:pr-9d19b71802
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-9d19b71802
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-9d19b71802
  • deployment-engine test image location: radius.azurecr.io/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting datastoresrp functional tests...
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ daprrp functional tests succeeded
✅ shared functional tests succeeded

@github-actions
Copy link

github-actions bot commented Sep 25, 2023

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref refs/pull/6345/merge
Unique ID c875e381d2
Image tag pr-c875e381d2
Click here to see the list of tools in the current test run
  • gotestsum 1.10.0
  • KinD: v0.20.0
  • Dapr: 1.11.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.1.0
  • Bicep recipe location radiusdev.azurecr.io/test/functional/shared/recipes/<name>:pr-c875e381d2
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-c875e381d2
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-c875e381d2
  • deployment-engine test image location: radius.azurecr.io/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting shared functional tests...
⌛ Starting ucp functional tests...
⌛ Starting daprrp functional tests...
✅ datastoresrp functional tests succeeded
✅ samples functional tests succeeded
✅ msgrp functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ shared functional tests succeeded

@github-actions
Copy link

Test Results

2 976 tests  ±0   2 967 ✔️ ±0   2m 5s ⏱️ -8s
   252 suites ±0          9 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit 0e2f72d. ± Comparison against base commit 6be2659.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.
github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/14206848-3812-4ecf-ad44-e60b56cacb0a
github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/14206848-3812-4ecf-ad44-e60b56cacb0a#01
github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/e0987554-c50f-4a54-9ca2-7384ffdbf5cf
github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/e0987554-c50f-4a54-9ca2-7384ffdbf5cf#01

@github-actions
Copy link

66.2

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 66.2 %
  • main branch coverage: 66.2 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@willdavsmith
Copy link
Contributor Author

I already fixed this... I completely forgot that it was already merged.

@youngbupark youngbupark deleted the willdavsmith/flaky-gateway-test branch February 27, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test: Test_Render_Multiple_Routes
1 participant