Update apiversion to 2023-10-01-preview #6332

vinayada1 · 2023-09-20T22:54:16Z

Description

Update API version to 2023-10-01-preview before public release

Type of change

This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #6226

Auto-generated summary

`🤖 Generated by Copilot at af09702`

Summary

🚀💥🧪

This pull request updates the API versions for the radius project and its dependencies to 2023-10-01-preview or 2023-10-01, depending on the service. This is to align with the new features and breaking changes in the RP and Azure contracts. The pull request also updates the test cases, test data, documentation, and bicep types generator to use the new API versions. Additionally, it moves the test-ucp-spec-examples target from test.mk to generate.mk to avoid running it in the CI pipeline.

API version
Changes with the autumn wind
Breaking old contracts

Walkthrough

Update the API versions for the core, datastores, messaging, dapr, ucp, and link RPs to 2023-10-01-preview, and for the sync RP to 2023-10-01, in the autorest tags for generating the CLI and RP clients (link, link)
Update the API versions for the core, datastores, messaging, dapr, ucp, and link RPs to 2023-10-01-preview, and for the sync RP to 2023-10-01, in the test cases, test data, and documentation for the armrpc package, which handles the ARM requests and responses for the RPs (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
Update the API versions for the Azure services to 2023-10-01 and 2023-10-01-preview in the clientv2 package, which provides the Azure clients for interacting with the services (link)
Update the type and API version for the env and app resources to 2023-10-01-preview in the test data for the bicep package, which provides the bicep file generation and injection for the CLI (link, link, link, link)
Update the regex for matching the swagger file paths in the bicep types generator, which generates the bicep types for the RPs, to allow the new preview suffix in the API version (link)
Move the test-ucp-spec-examples target from the test.mk file to the generate.mk file, to align the test with the generate targets for the other RPs, and to avoid running the test in the CI pipeline (link)
Update the URL for testing the ucp RP in the docs/ucp/developer_guide.md file, to use the new API version 2023-10-01-preview (link)
Update the path to the ucp swagger definition file in the docs/ucp/code_walkthrough.md file, to use the new API version 2023-10-01-preview (link)
Update the API version for the gateway and webapp resources in the bicep file example in the docs/contributing/contributing-code/contributing-code-tests/tests-naming-conventions.md file, to use the new API version 2023-10-01-preview (link, link)

github-actions · 2023-09-20T23:13:58Z

Test Results

2 973 tests ±0 2 964 ✔️ ±0 2m 0s ⏱️ -1s
  252 suites ±0       9 💤 ±0
      1 files ±0       0 ❌ ±0

Results for commit 39f33f9. ± Comparison against base commit bd84cd4.

This pull request removes 363 and adds 363 tests. Note that renamed tests count towards both.

github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/2ae462b8-9248-4978-aa55-d6cdd6780a0e
github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/2ae462b8-9248-4978-aa55-d6cdd6780a0e#01
github.com/radius-project/radius/pkg/corerp/api/v20220315privatepreview ‑ TestApplicationConvertDataModelToVersioned
github.com/radius-project/radius/pkg/corerp/api/v20220315privatepreview ‑ TestApplicationConvertDataModelToVersioned/applicationresourcedatamodel.json
github.com/radius-project/radius/pkg/corerp/api/v20220315privatepreview ‑ TestApplicationConvertFromValidation
github.com/radius-project/radius/pkg/corerp/api/v20220315privatepreview ‑ TestApplicationConvertVersionedToDataModel
github.com/radius-project/radius/pkg/corerp/api/v20220315privatepreview ‑ TestApplicationConvertVersionedToDataModel/applicationresource.json
github.com/radius-project/radius/pkg/corerp/api/v20220315privatepreview ‑ TestApplicationConvertVersionedToDataModel/applicationresourceemptyext.json
github.com/radius-project/radius/pkg/corerp/api/v20220315privatepreview ‑ TestApplicationConvertVersionedToDataModel/applicationresourceemptyext2.json
github.com/radius-project/radius/pkg/corerp/api/v20220315privatepreview ‑ TestContainerConvertDataModelToVersioned
…

github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/73f002f2-188d-42af-a24a-1577d4150cc6
github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/73f002f2-188d-42af-a24a-1577d4150cc6#01
github.com/radius-project/radius/pkg/corerp/api/v20231001preview ‑ TestApplicationConvertDataModelToVersioned
github.com/radius-project/radius/pkg/corerp/api/v20231001preview ‑ TestApplicationConvertDataModelToVersioned/applicationresourcedatamodel.json
github.com/radius-project/radius/pkg/corerp/api/v20231001preview ‑ TestApplicationConvertFromValidation
github.com/radius-project/radius/pkg/corerp/api/v20231001preview ‑ TestApplicationConvertVersionedToDataModel
github.com/radius-project/radius/pkg/corerp/api/v20231001preview ‑ TestApplicationConvertVersionedToDataModel/applicationresource.json
github.com/radius-project/radius/pkg/corerp/api/v20231001preview ‑ TestApplicationConvertVersionedToDataModel/applicationresourceemptyext.json
github.com/radius-project/radius/pkg/corerp/api/v20231001preview ‑ TestApplicationConvertVersionedToDataModel/applicationresourceemptyext2.json
github.com/radius-project/radius/pkg/corerp/api/v20231001preview ‑ TestContainerConvertDataModelToVersioned
…

♻️ This comment has been updated with latest results.

github-actions · 2023-09-20T23:14:32Z

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

Your PR branch coverage: 66.2 %
main branch coverage: 66.2 %
diff coverage: 0 %

The coverage result does not include the functional test coverage.

github-actions · 2023-09-21T18:58:50Z

⌛ Building Radius and pushing container images for functional tests...

✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting samples functional tests...
✅ datastoresrp functional tests succeeded
✅ ucp functional tests succeeded
✅ msgrp functional tests succeeded
❌ samples functional test failed. Please check the logs for more details
⌛ Starting samples functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting daprrp functional tests...
❌ samples functional test failed. Please check the logs for more details

github-actions · 2023-09-21T20:56:57Z

⌛ Building Radius and pushing container images for functional tests...

✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting ucp functional tests...
⌛ Starting msgrp functional tests...
✅ samples functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ ucp functional tests succeeded
✅ daprrp functional tests succeeded
✅ msgrp functional tests succeeded
✅ shared functional tests succeeded

github-actions · 2023-09-21T21:02:37Z

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

Your PR branch coverage: 66.2 %
main branch coverage: 66.2 %
diff coverage: 0 %

The coverage result does not include the functional test coverage.

github-actions · 2023-09-21T21:32:57Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	refs/pull/6332/merge
Unique ID	2474d90155
Image tag	pr-2474d90155

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.11.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location radiusdev.azurecr.io/test/functional/shared/recipes/<name>:pr-2474d90155
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-2474d90155
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-2474d90155
deployment-engine test image location: radius.azurecr.io/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting ucp functional tests...
✅ datastoresrp functional tests succeeded
✅ samples functional tests succeeded
✅ msgrp functional tests succeeded
✅ daprrp functional tests succeeded
✅ ucp functional tests succeeded
✅ shared functional tests succeeded

vinayada1 · 2023-09-21T21:44:29Z

The Validate Bicep code will require the samples repo to be merged. It's okay for this step to fail at this point.

github-actions · 2023-09-21T21:49:14Z

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

Your PR branch coverage: 66.2 %
main branch coverage: 66.2 %
diff coverage: 0 %

The coverage result does not include the functional test coverage.

.github/workflows/functional-test.yaml

nithyatsu · 2023-09-21T22:04:17Z

LGTM.. we should merge this + update samples and other repos before oct release correct?

pkg/cli/clients/management.go

vinayada1 requested a review from a team as a code owner September 20, 2023 22:54

vinayada1 added 6 commits September 20, 2023 15:54

Update API version

115635a

Run grep commands

ff5a41b

Rename files

4db6f78

Run make generate

8699981

Change typespec examples dir name

01eb1c5

make generate

f38ed11

vinayada1 force-pushed the update-apiversion branch from af09702 to f38ed11 Compare September 20, 2023 22:55

This comment has been minimized.

Sign in to view

Temporarily disabling running the samples test

8240a6a

This comment has been minimized.

Sign in to view

Merge branch 'main' into update-apiversion

39f33f9

lakshmimsft reviewed Sep 21, 2023

View reviewed changes

.github/workflows/functional-test.yaml Show resolved Hide resolved

nithyatsu self-requested a review September 21, 2023 22:04

nithyatsu approved these changes Sep 21, 2023

View reviewed changes

vinayada1 merged commit 97cc611 into main Sep 21, 2023
27 of 28 checks passed

vinayada1 deleted the update-apiversion branch September 21, 2023 22:14

lakshmimsft reviewed Sep 21, 2023

View reviewed changes

pkg/cli/clients/management.go Show resolved Hide resolved

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update apiversion to 2023-10-01-preview #6332

Update apiversion to 2023-10-01-preview #6332

vinayada1 commented Sep 20, 2023 •

edited

Loading

This comment has been minimized.

github-actions bot commented Sep 20, 2023 •

edited

Loading

github-actions bot commented Sep 20, 2023

github-actions bot commented Sep 21, 2023 •

edited

Loading

This comment has been minimized.

github-actions bot commented Sep 21, 2023 •

edited

Loading

github-actions bot commented Sep 21, 2023

github-actions bot commented Sep 21, 2023 •

edited

Loading

vinayada1 commented Sep 21, 2023

github-actions bot commented Sep 21, 2023

nithyatsu commented Sep 21, 2023

Update apiversion to 2023-10-01-preview #6332

Update apiversion to 2023-10-01-preview #6332

Conversation

vinayada1 commented Sep 20, 2023 • edited Loading

Description

Type of change

Auto-generated summary

🤖 Generated by Copilot at af09702

Summary

Walkthrough

This comment has been minimized.

github-actions bot commented Sep 20, 2023 • edited Loading

Test Results

github-actions bot commented Sep 20, 2023

github-actions bot commented Sep 21, 2023 • edited Loading

This comment has been minimized.

github-actions bot commented Sep 21, 2023 • edited Loading

github-actions bot commented Sep 21, 2023

github-actions bot commented Sep 21, 2023 • edited Loading

Radius functional test overview

Test Status

vinayada1 commented Sep 21, 2023

github-actions bot commented Sep 21, 2023

nithyatsu commented Sep 21, 2023

vinayada1 commented Sep 20, 2023 •

edited

Loading

`🤖 Generated by Copilot at af09702`

github-actions bot commented Sep 20, 2023 •

edited

Loading

github-actions bot commented Sep 21, 2023 •

edited

Loading

github-actions bot commented Sep 21, 2023 •

edited

Loading

github-actions bot commented Sep 21, 2023 •

edited

Loading