clean up routes from tests #6267

nithyatsu · 2023-09-13T18:54:53Z

Description

debugging cicd failure

Type of change

This pull request fixes a bug in Radius and has an approved issue (issue link required).
This pull request adds or changes features of Radius and has an approved issue (issue link required).
This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #issue_number

Auto-generated summary

`🤖 Generated by Copilot at f9c45a8`

Summary

🗑️🛠️🧪

This pull request updates the radius project to use the MongoDB driver module, refactor the kubernetes handler and the container and gateway renderers, and remove unused code and resources related to the dynamic Kubernetes client and the httproute resource. It also updates the manual tests and the test data to reflect the changes.

httproute gone now
simpler code for datastores
autumn leaves falling

Walkthrough

Add MongoDB driver dependency and remove indirect dependency (link, link)
Remove unused k8s dynamic client from worker, backend, and application model packages (link, link, link, link, link, link, link, link, link)
Replace resource waiter logic with deployment waiter logic in kubernetes handler (link, link, link, link, link, link, link, link)
Refactor container renderer to use corev1.ServicePort type and fix typo (link, link, link, link)
Update container port and service port for DNS service generation test in container renderer test (link, link, link)
Rename gateway renderer functions and update comments to reflect gateway and httproute resources (link, link, link, link)
Remove route dependencies from gateway output resource in gateway renderer (link)
Remove httproute resources from expected resources and validations in datastoresrp manual tests (link, link, link, link, link, link, link, link)
Update container and service ports and connection strings for datastoresrp manual test bicep files (link, link, link, link, link, link, link, link, link)

github-actions · 2023-09-13T19:20:15Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	refs/pull/6267/merge
Unique ID	387b998efd
Image tag	pr-387b998efd

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.11.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location radiusdev.azurecr.io/test/functional/shared/recipes/<name>:pr-387b998efd
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-387b998efd
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-387b998efd
deployment-engine test image location: radius.azurecr.io/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
❌ Container images build failed
❌ Test recipe publishing failed

github-actions · 2023-09-13T19:23:04Z

Test Results

2 967 tests - 4 2 958 ✔️ - 4 2m 2s ⏱️ -14s
  252 suites ±0       9 💤 ±0
      1 files ±0       0 ❌ ±0

Results for commit 9dbfe51. ± Comparison against base commit 456dafc.

This pull request removes 9 and adds 5 tests. Note that renamed tests count towards both.

github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/3cd570be-5ec7-4f6c-b465-04a0812003be
github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/3cd570be-5ec7-4f6c-b465-04a0812003be#01
github.com/radius-project/radius/pkg/corerp/handlers ‑ TestCheckHTTPProxyStatus_InvalidStatusForRootProxy
github.com/radius-project/radius/pkg/corerp/handlers ‑ TestCheckHTTPProxyStatus_InvalidStatusForRouteProxy
github.com/radius-project/radius/pkg/corerp/handlers ‑ TestCheckHTTPProxyStatus_ValidStatus
github.com/radius-project/radius/pkg/corerp/handlers ‑ TestCheckHTTPProxyStatus_WrongSelector
github.com/radius-project/radius/pkg/corerp/handlers ‑ TestWaitUntilReady_DifferentResourceName
github.com/radius-project/radius/pkg/corerp/handlers ‑ TestWaitUntilReady_NewResource
github.com/radius-project/radius/pkg/corerp/handlers ‑ TestWaitUntilReady_Timeout

github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/b7deaeca-7932-4c3d-9059-562bbb751985
github.com/radius-project/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/b7deaeca-7932-4c3d-9059-562bbb751985#01
github.com/radius-project/radius/pkg/corerp/handlers ‑ TestWaitUntilDeploymentIsReady_DifferentResourceName
github.com/radius-project/radius/pkg/corerp/handlers ‑ TestWaitUntilDeploymentIsReady_NewResource
github.com/radius-project/radius/pkg/corerp/handlers ‑ TestWaitUntilDeploymentIsReady_Timeout

♻️ This comment has been updated with latest results.

refactoring nit

This reverts commit 6a9173f.

github-actions · 2023-09-13T20:37:50Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	radius-project/radius
Commit ref	refs/pull/6267/merge
Unique ID	e51e0ddea4
Image tag	pr-e51e0ddea4

Click here to see the list of tools in the current test run

gotestsum 1.10.0
KinD: v0.20.0
Dapr: 1.11.0
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.1.0
Bicep recipe location radiusdev.azurecr.io/test/functional/shared/recipes/<name>:pr-e51e0ddea4
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-e51e0ddea4
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-e51e0ddea4
deployment-engine test image location: radius.azurecr.io/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting samples functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting shared functional tests...
⌛ Starting msgrp functional tests...
✅ datastoresrp functional tests succeeded
✅ ucp functional tests succeeded
✅ samples functional tests succeeded
✅ msgrp functional tests succeeded
✅ daprrp functional tests succeeded
✅ shared functional tests succeeded

github-actions · 2023-09-13T20:56:10Z

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

Your PR branch coverage: 66.4 %
main branch coverage: 66.3 %
diff coverage: .1 %

The coverage result does not include the functional test coverage.

github-actions · 2023-09-13T22:47:26Z

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

Your PR branch coverage: 66.4 %
main branch coverage: 66.3 %
diff coverage: .1 %

The coverage result does not include the functional test coverage.

github-actions · 2023-09-13T22:49:29Z

⌛ Building Radius and pushing container images for functional tests...

✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting datastoresrp functional tests...
⌛ Starting ucp functional tests...
⌛ Starting daprrp functional tests...
⌛ Starting msgrp functional tests...
⌛ Starting samples functional tests...
⌛ Starting shared functional tests...
✅ msgrp functional tests succeeded
✅ samples functional tests succeeded
✅ daprrp functional tests succeeded
✅ datastoresrp functional tests succeeded
✅ ucp functional tests succeeded
✅ shared functional tests succeeded

nithyatsu force-pushed the experiment branch from f9c45a8 to a164c1d Compare September 13, 2023 19:19

nithyatsu added 3 commits September 13, 2023 13:07

support servicePort different from containerPort

9b2cbd3

refactoring nit

Revert "Detect deployment failures with gateway (#6126)"

f6c7d64

This reverts commit 6a9173f.

fix

6507943

nithyatsu force-pushed the experiment branch from a164c1d to 6507943 Compare September 13, 2023 20:37

sd

9dbfe51

This comment has been minimized.

Sign in to view

nithyatsu closed this Sep 14, 2023

youngbupark deleted the experiment branch February 27, 2024 01:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

clean up routes from tests #6267

clean up routes from tests #6267

nithyatsu commented Sep 13, 2023 •

edited by ghost

Loading

github-actions bot commented Sep 13, 2023 •

edited

Loading

github-actions bot commented Sep 13, 2023 •

edited

Loading

github-actions bot commented Sep 13, 2023 •

edited

Loading

github-actions bot commented Sep 13, 2023

This comment has been minimized.

github-actions bot commented Sep 13, 2023

github-actions bot commented Sep 13, 2023 •

edited

Loading

clean up routes from tests #6267

clean up routes from tests #6267

Conversation

nithyatsu commented Sep 13, 2023 • edited by ghost Loading

Description

Type of change

Auto-generated summary

🤖 Generated by Copilot at f9c45a8

Summary

Walkthrough

github-actions bot commented Sep 13, 2023 • edited Loading

Radius functional test overview

Test Status

github-actions bot commented Sep 13, 2023 • edited Loading

Test Results

github-actions bot commented Sep 13, 2023 • edited Loading

Radius functional test overview

Test Status

github-actions bot commented Sep 13, 2023

This comment has been minimized.

github-actions bot commented Sep 13, 2023

github-actions bot commented Sep 13, 2023 • edited Loading

nithyatsu commented Sep 13, 2023 •

edited by ghost

Loading

`🤖 Generated by Copilot at f9c45a8`

github-actions bot commented Sep 13, 2023 •

edited

Loading

github-actions bot commented Sep 13, 2023 •

edited

Loading

github-actions bot commented Sep 13, 2023 •

edited

Loading

github-actions bot commented Sep 13, 2023 •

edited

Loading