Add AWS creation timestamp to test resources #6262
Conversation
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Test Results2 976 tests ±0 2 967 ✔️ ±0 2m 37s ⏱️ +23s Results for commit 3b7d40d. ± Comparison against base commit cf80402. This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
For the detailed report, please go to
|
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
|
For the detailed report, please go to
|
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
|
For the detailed report, please go to
|
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
|
For the detailed report, please go to
|
| @@ -1473,6 +1474,10 @@ func validateHTTPProxy(t *testing.T, outputResources []rpv1.OutputResource, expe | |||
| } | |||
| } | |||
|
|
|||
| // Sort the dependencies so that tests aren't flaky | |||
There was a problem hiding this comment.
separate issue, not related to the rest of the PR: #6263
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
|
For the detailed report, please go to
|
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
|
For the detailed report, please go to
|
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
|
For the detailed report, please go to
|
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
|
For the detailed report, please go to
|
Description
Today we blindly delete all AWS resources created by our tests at midnight every day. This could cause functional tests to fail around this time. This PR adds a
creationTimestampto each AWS test resource that we create as well as logic to delete them by timestamp in the GitHub workflow.Type of change
Fixes: #6263
Auto-generated summary
🤖 Generated by Copilot at adea799
Summary
🧹🕒🛠️
This pull request improves the cleanup of AWS resources created by functional tests. It adds a
creationTimestampparameter to the bicep templates and tags the resources with their creation time. It also refactors the workflow to use a common script that deletes old resources based on their tags. It renames a test file and adds some helper functions to the functional package.Walkthrough
test/functional/shared/resources/kubmetadata_cascade_test.gototest/functional/shared/resources/kubemetadata_cascade_test.go(link)