-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code review documentation #6250
Conversation
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
|
||
Since we automate most matters of Style, and try to resolve matters of Behavior and Scope before a pull-request then that means the focus of most reviews should be on the Correctness and Design. | ||
|
||
## How to give good feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like more input and feedback from the team on this section. @nicolejms has scheduled a team discussion on the topic of code reviews. I plan to update this again after that meeting.
Test Results2 971 tests ±0 2 962 ✔️ ±0 2m 1s ⏱️ -12s Results for commit da98ae1. ± Comparison against base commit c0cd383. This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.
|
❌ Container images build failed ❌ Test recipe publishing failed |
|
||
We welcome **any contributor or community-member** to engage with any **any pull-request** on our repository as a reviewer. | ||
|
||
This page some contains guidance for: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"contains some"
Description
First cut of code review documentation
Type of change
Auto-generated summary
🤖 Generated by Copilot at da98ae1
Summary
📝🔗👀
This pull request adds a new document
./docs/contributing/contributing-code/contributing-code-reviewing/README.md
that explains the code review process and best practices for Radius. It also updates the existing documentation on pull requests and how to contribute to include code reviews as a form of participation and quality assurance. The goal of this pull request is to improve the code review culture and standards for the project.Walkthrough
[link](https://github.com/radius-project/radius/pull/6250/files?diff=unified&w=0#diff-197beededa4d4635e30d5c9f2261671669816f2f79a661239c6e719adae5245cR1-R189)
)