-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tests to remove httpRoutes since services can now be deployed as part of container rendering. #6241
Conversation
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Test Results2 958 tests ±0 2 946 ✔️ ±0 2m 43s ⏱️ ±0s Results for commit ac5fc10. ± Comparison against base commit 51fe742. This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
17f12a1
to
f980220
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
This comment has been minimized.
This comment has been minimized.
⌛ Building Radius and pushing container images for functional tests... ✅ Container images build succeeded |
a59b055
to
8d94315
Compare
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
68ad425
to
c4c3ba5
Compare
/ok-to-test |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
/ok-to-test |
This comment has been minimized.
This comment has been minimized.
c4c3ba5
to
4dc2d1c
Compare
⌛ Building Radius and pushing container images for functional tests... ✅ Container images build succeeded |
This reverts commit a93854169188c65825d98fd17259016efa52bf61.
4dc2d1c
to
ac5fc10
Compare
Description
We now have the ability to deploy k8s services as part of container rendering (ref #6375)
This PR updates all the radius repo tests and samples
Type of change
Fixes: #6099
Auto-generated summary
🤖 Generated by Copilot at e22a126
Summary
🌐🛠️🗑️
This pull request simplifies the service generation logic for datastores and containers in the radius project. It removes the dependency on httpRoutes resources for datastores, and allows specifying different port and target port values for containers. It updates the renderers, test cases, and test data files accordingly.
Walkthrough
render_test.go
to use different container and service port numbers and add port field to container port definition (link, link, link)render.go
(link)mongodb_test.go
,redis_test.go
, andsql_test.go
(link, link, link, link, link, link)datastoresrp-rs-mongodb-manual.bicep
anddatastoresrp-resources-sqldb-manual.bicep
(link, link)datastoresrp-resources-redis-manual.bicep
(link)datastoresrp-rs-mongodb-manual.bicep
,datastoresrp-resources-redis-manual.bicep
, anddatastoresrp-resources-sqldb-manual.bicep
to use container name and port instead of httpRoutes hostname and port (link, link, link)datastoresrp-rs-mongodb-manual.bicep
,datastoresrp-resources-redis-manual.bicep
, anddatastoresrp-resources-sqldb-manual.bicep
(link, link, link)