Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checked in copy of bicep types #5630

Closed
wants to merge 1 commit into from
Closed

Conversation

rynowak
Copy link
Contributor

@rynowak rynowak commented Jun 2, 2023

Description

This checked in copy of the bicep types for Radius and the tools for making them isn't necessary. Removing it so it doesn't confuse contributors trying to browse the repo.

Auto-generated summary

🤖 Generated by Copilot at 330ea11

Summary

📱🛠️🌐

Removed autorest.bicep package and its related files from hack/bicep-types-radius folder. This package was no longer needed as the project switched to using bicep-types-az for generating Bicep types from Azure Resource Manager schemas.

is_valid checks
refactored for clarity
autumn leaves falling

Walkthrough

  • Delete the entire hack/bicep-types-radius/src/autorest.bicep directory and all its contents (link-link)
  • Remove the code and tests for generating bicep types from autorest specifications (link-link)
  • Remove the configuration files for eslint, prettier, jest, npm, and git in the deleted directory (link-link)

@rynowak rynowak requested a review from a team as a code owner June 2, 2023 16:24
@rynowak rynowak added the do-not-merge Don't merge this PR until open discussion items or isssues are complete label Jun 2, 2023
@rynowak
Copy link
Contributor Author

rynowak commented Jun 2, 2023

This isn't quite ready to go yet, I will need to update this workflow https://github.com/project-radius/radius/blob/main/.github/workflows/publish-bicep.yaml#L21

@youngbupark
Copy link

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Radius functional test overview

🔍 Go to test action run

Name Value
Repository project-radius/radius
Commit ref 330ea11
Unique ID b4ba745093
Image tag pr-b4ba745093
Click here to see the list of tools in the current test run
  • KinD: v0.18.0
  • Dapr: 1.10.0
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.0.0
  • recipe location radiusdev.azurecr.io/test/functional/corerp/recipes/<name>:pr-b4ba745093
  • appcore-rp test image location: radiusdev.azurecr.io/appcore-rp:pr-b4ba745093
  • ucp test image location: radiusdev.azurecr.io/ucpd:pr-b4ba745093

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting samples functional tests...
⌛ Starting ucp functional tests...
⌛ Starting corerp functional tests...
✅ samples functional tests succeeded
✅ ucp functional tests succeeded
✅ corerp functional tests succeeded

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Test Results

2 748 tests  ±0   2 741 ✔️ ±0   2m 8s ⏱️ +11s
   242 suites ±0          7 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit 330ea11. ± Comparison against base commit 2228304.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.
github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/3ead4c9e-c77d-4a95-a87a-70db9d46cace
github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/3ead4c9e-c77d-4a95-a87a-70db9d46cace#01
github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/5b3127b3-4494-4559-a750-5f3c19f1dfdf
github.com/project-radius/radius/pkg/armrpc/frontend/controller ‑ TestValidateEtag_IfMatch/5b3127b3-4494-4559-a750-5f3c19f1dfdf#01

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

64.9

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

  • Your PR branch coverage: 64.9 %
  • main branch coverage: 64.9 %
  • diff coverage: 0 %

The coverage result does not include the functional test coverage.

@rynowak
Copy link
Contributor Author

rynowak commented Jun 2, 2023

Per offline discussion, this change is bigger than initially thought. Using https://github.com/project-radius/radius/issues/5631 to track.

@rynowak rynowak closed this Jun 2, 2023
@youngbupark youngbupark deleted the rynowak/remove-cruft branch February 27, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge Don't merge this PR until open discussion items or isssues are complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants