Make TemplateKind required #5580
Conversation
|
You are editing files which require a docs update. Please ensure you've made the appropriate changes to the docs and submitted a PR.
For more information on contributing to docs please visit https://docs.radapp.dev/contributing/docs/. |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
Test Results2 722 tests +5 2 715 ✔️ +5 1m 55s ⏱️ -1s Results for commit c20accd. ± Comparison against base commit d8cce54. This pull request removes 6 and adds 11 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
For the detailed report, please go to
|
|
You are editing files which require a docs update. Please ensure you've made the appropriate changes to the docs and submitted a PR.
For more information on contributing to docs please visit https://docs.radapp.dev/contributing/docs/. |
This comment has been minimized.
This comment has been minimized.
|
For the detailed report, please go to
|
| "required": [ | ||
| "templateKind", |
There was a problem hiding this comment.
@AaronCrawfis Just a heads up - templateKind will be a required parameter after this is merged
|
You are editing files which require a docs update. Please ensure you've made the appropriate changes to the docs and submitted a PR.
For more information on contributing to docs please visit https://docs.radapp.dev/contributing/docs/. |
This comment has been minimized.
This comment has been minimized.
|
For the detailed report, please go to
|
|
⌛ Building Radius and pushing container images for functional tests... ✅ Container images build succeeded |
| }) | ||
| } | ||
| // TODO Check to ensure backwards compatibility with existing environments. | ||
| // Remove this in next release once users have migrated their existing environments. |
There was a problem hiding this comment.
If there's work to do in the next release can we use an issue to track this? I think the TODO in code is fine and helpful, but ideally it will reference an issue as well so we can find the relevant code.
There was a problem hiding this comment.
Sure, will create an issue and update the comment. I was planning to delete it myself next week after the release so that it doesn't linger around that's why just left it at TODO.
| @@ -36,13 +36,13 @@ You can specify parameters using the '--parameter' flag ('-p' for short). Parame | |||
| `, | |||
| Example: ` | |||
| # Add a recipe to an environment | |||
| rad recipe register cosmosdb -e env_name -w workspace --template-path template_path --link-type Applications.Link/mongoDatabases | |||
| rad recipe register cosmosdb -e env_name -w workspace --template-kind bicep --template-path template_path --link-type Applications.Link/mongoDatabases | |||
There was a problem hiding this comment.
Rando question for both @kachawla @jasonviviano @AaronCrawfis - would it be possible to infer the template kind in the CLI based on the template path? Non-blocking for this PR.
There was a problem hiding this comment.
I thought about that in general for env authoring experience. We could technically do this for current point in time requirements - if the path points to a container registry then it is Bicep else Terraform, but I don't think it is a reliable solution if we plan to support combination of different formats and multiple storage options for recipes in every format. Would like to hear from Aaron/Jason on what do we envision adding support for in the future based on customer asks so far.
There was a problem hiding this comment.
Created https://github.com/project-radius/radius/issues/5801 to track this discussion.
pkg/corerp/api/v20220315privatepreview/environment_conversion.go
Outdated
Show resolved
Hide resolved
kachawla
force-pushed
the
kachawla/recipe-templatekind-required
branch
from
155122e to
a6d0b1c
Compare
|
You are editing files which require a docs update. Please ensure you've made the appropriate changes to the docs and submitted a PR.
For more information on contributing to docs please visit https://docs.radapp.dev/contributing/docs/. |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
|
For the detailed report, please go to
|
|
You are editing files which require a docs update. Please ensure you've made the appropriate changes to the docs and submitted a PR.
For more information on contributing to docs please visit https://docs.radapp.dev/contributing/docs/. |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
|
For the detailed report, please go to
|
|
You are editing files which require a docs update. Please ensure you've made the appropriate changes to the docs and submitted a PR.
For more information on contributing to docs please visit https://docs.radapp.dev/contributing/docs/. |
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
|
For the detailed report, please go to
|
Description
Added a new property for recipe templateKind in here #5575. Switching the property from optional to required and updating functional test templates.
Issue reference
Fixes Support multiple template types user story under https://github.com/project-radius/radius/issues/4446.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: