-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable long-running Azure tests if the workflow file is changed in PR #6497
Labels
triaged
This issue has been reviewed and triaged
Comments
Merged
shalabhms
pushed a commit
that referenced
this issue
Oct 23, 2023
#6547) # Description This PR fixes the YAML syntax error in https://github.com/radius-project/radius/actions/workflows/long-running-azure.yaml and re-enables running the workflow on pull requests whenever the workflow file is itself edited. ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional). <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: #6497 ## Auto-generated summary <!-- GitHub Copilot for docs will auto-generate a summary of the PR --> <!-- copilot:all --> ### <samp>🤖 Generated by Copilot at 552ebbc</samp> ### Summary 🚀🧪🔒 <!-- 1. 🚀 This emoji represents the pull_request trigger, which enables the workflow to run on pull requests and launch the CI/CD pipeline. 2. 🧪 This emoji represents the testing and reviewing of the workflow changes, which can help catch and fix any errors or bugs before merging. 3. 🔒 This emoji represents the security and protection of the main branch, which can prevent unwanted or harmful changes from being deployed. --> Enable pull request trigger for long-running Azure workflow. This allows testing the `.github/workflows/long-running-azure.yaml` file changes before merging. > _`pull_request` runs_ > _workflow on branch changes_ > _autumn leaves falling_ ### Walkthrough * Enable workflow to run on pull requests that modify it ([link](https://github.com/radius-project/radius/pull/6547/files?diff=unified&w=0#diff-85cd86e7ae6da973e4808fe57f4fea7892ab78a499ba5aec72c0b3751a2cc226L44-R46)) Signed-off-by: Shubham Sharma <[email protected]> Co-authored-by: Ryan Nowak <[email protected]>
willdavsmith
pushed a commit
to willdavsmith/radius
that referenced
this issue
Nov 3, 2023
radius-project#6547) # Description This PR fixes the YAML syntax error in https://github.com/radius-project/radius/actions/workflows/long-running-azure.yaml and re-enables running the workflow on pull requests whenever the workflow file is itself edited. ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional). <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: radius-project#6497 ## Auto-generated summary <!-- GitHub Copilot for docs will auto-generate a summary of the PR --> <!-- copilot:all --> ### <samp>🤖 Generated by Copilot at 552ebbc</samp> ### Summary 🚀🧪🔒 <!-- 1. 🚀 This emoji represents the pull_request trigger, which enables the workflow to run on pull requests and launch the CI/CD pipeline. 2. 🧪 This emoji represents the testing and reviewing of the workflow changes, which can help catch and fix any errors or bugs before merging. 3. 🔒 This emoji represents the security and protection of the main branch, which can prevent unwanted or harmful changes from being deployed. --> Enable pull request trigger for long-running Azure workflow. This allows testing the `.github/workflows/long-running-azure.yaml` file changes before merging. > _`pull_request` runs_ > _workflow on branch changes_ > _autumn leaves falling_ ### Walkthrough * Enable workflow to run on pull requests that modify it ([link](https://github.com/radius-project/radius/pull/6547/files?diff=unified&w=0#diff-85cd86e7ae6da973e4808fe57f4fea7892ab78a499ba5aec72c0b3751a2cc226L44-R46)) Signed-off-by: Shubham Sharma <[email protected]> Co-authored-by: Ryan Nowak <[email protected]> Signed-off-by: willdavsmith <[email protected]>
willdavsmith
pushed a commit
that referenced
this issue
Nov 6, 2023
#6547) # Description This PR fixes the YAML syntax error in https://github.com/radius-project/radius/actions/workflows/long-running-azure.yaml and re-enables running the workflow on pull requests whenever the workflow file is itself edited. ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional). <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: #6497 ## Auto-generated summary <!-- GitHub Copilot for docs will auto-generate a summary of the PR --> <!-- copilot:all --> ### <samp>🤖 Generated by Copilot at 552ebbc</samp> ### Summary 🚀🧪🔒 <!-- 1. 🚀 This emoji represents the pull_request trigger, which enables the workflow to run on pull requests and launch the CI/CD pipeline. 2. 🧪 This emoji represents the testing and reviewing of the workflow changes, which can help catch and fix any errors or bugs before merging. 3. 🔒 This emoji represents the security and protection of the main branch, which can prevent unwanted or harmful changes from being deployed. --> Enable pull request trigger for long-running Azure workflow. This allows testing the `.github/workflows/long-running-azure.yaml` file changes before merging. > _`pull_request` runs_ > _workflow on branch changes_ > _autumn leaves falling_ ### Walkthrough * Enable workflow to run on pull requests that modify it ([link](https://github.com/radius-project/radius/pull/6547/files?diff=unified&w=0#diff-85cd86e7ae6da973e4808fe57f4fea7892ab78a499ba5aec72c0b3751a2cc226L44-R46)) Signed-off-by: Shubham Sharma <[email protected]> Co-authored-by: Ryan Nowak <[email protected]> Signed-off-by: willdavsmith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Overview of feature request
#6478 disables the long-running azure tests on PR. We should re-enable this for PRs that change this workflow.
Acceptance criteria
Additional context
AB#9833
The text was updated successfully, but these errors were encountered: