rename rad app connections to rad app graph
#6473
Labels
triaged
This issue has been reviewed and triaged
Comments
rynowak
changed the title
rad app connections to `rad app graphrad app connections to rad app graph
AaronCrawfis
added a commit
that referenced
this issue
Oct 17, 2023
# Description This PR adds an alias for `rad app graph` that points to `rad app connections`. It is a temporary update until we permanently update the command. ## Type of change - This pull request fixes a bug in Radius and has an approved issue (issue link required). Partially addresses: #6473 ## Auto-generated summary <!-- GitHub Copilot for docs will auto-generate a summary of the PR --> <!-- copilot:all --> ### <samp>🤖 Generated by Copilot at b5b8f0c</samp> ### Summary :sparkles::recycle::memo: <!-- 1. :sparkles: This emoji represents the addition of a new feature or enhancement, and can be used to highlight the main purpose of the pull request, which is to implement a graphical view of the connections. 2. :recycle: This emoji represents the refactoring or improvement of existing code, and can be used to indicate the modification of the `NewCommand` function to add an alias for the existing command. 3. :memo: This emoji represents the addition or update of documentation, and can be used to indicate the changes to the command help text and the README file that explain the new alias and feature. --> Add "graph" alias for "connections" command in `pkg/cli/cmd/app/connections/connections.go`. This enables users to view a graphical representation of the connections for an application. > _`NewCommand` adds_ > _alias for connections_ > _graph in the spring_ ### Walkthrough * Add an alias "graph" for the "connections" command ([link](https://github.com/radius-project/radius/pull/6489/files?diff=unified&w=0#diff-eb0083d8df9479acb2d5b36bf150aa410e371a26a01619d09c933a73994aa563L27-R31)) --------- Signed-off-by: Aaron Crawfis <[email protected]>
sk593
pushed a commit
that referenced
this issue
Oct 17, 2023
# Description This PR adds an alias for `rad app graph` that points to `rad app connections`. It is a temporary update until we permanently update the command. ## Type of change - This pull request fixes a bug in Radius and has an approved issue (issue link required). Partially addresses: #6473 ## Auto-generated summary <!-- GitHub Copilot for docs will auto-generate a summary of the PR --> <!-- copilot:all --> ### <samp>🤖 Generated by Copilot at b5b8f0c</samp> ### Summary :sparkles::recycle::memo: <!-- 1. :sparkles: This emoji represents the addition of a new feature or enhancement, and can be used to highlight the main purpose of the pull request, which is to implement a graphical view of the connections. 2. :recycle: This emoji represents the refactoring or improvement of existing code, and can be used to indicate the modification of the `NewCommand` function to add an alias for the existing command. 3. :memo: This emoji represents the addition or update of documentation, and can be used to indicate the changes to the command help text and the README file that explain the new alias and feature. --> Add "graph" alias for "connections" command in `pkg/cli/cmd/app/connections/connections.go`. This enables users to view a graphical representation of the connections for an application. > _`NewCommand` adds_ > _alias for connections_ > _graph in the spring_ ### Walkthrough * Add an alias "graph" for the "connections" command ([link](https://github.com/radius-project/radius/pull/6489/files?diff=unified&w=0#diff-eb0083d8df9479acb2d5b36bf150aa410e371a26a01619d09c933a73994aa563L27-R31)) --------- Signed-off-by: Aaron Crawfis <[email protected]> (cherry picked from commit 047da70)
sk593
pushed a commit
that referenced
this issue
Oct 18, 2023
# Description This PR adds an alias for `rad app graph` that points to `rad app connections`. It is a temporary update until we permanently update the command. ## Type of change - This pull request fixes a bug in Radius and has an approved issue (issue link required). Partially addresses: #6473 ## Auto-generated summary <!-- GitHub Copilot for docs will auto-generate a summary of the PR --> <!-- copilot:all --> ### <samp>🤖 Generated by Copilot at b5b8f0c</samp> ### Summary :sparkles::recycle::memo: <!-- 1. :sparkles: This emoji represents the addition of a new feature or enhancement, and can be used to highlight the main purpose of the pull request, which is to implement a graphical view of the connections. 2. :recycle: This emoji represents the refactoring or improvement of existing code, and can be used to indicate the modification of the `NewCommand` function to add an alias for the existing command. 3. :memo: This emoji represents the addition or update of documentation, and can be used to indicate the changes to the command help text and the README file that explain the new alias and feature. --> Add "graph" alias for "connections" command in `pkg/cli/cmd/app/connections/connections.go`. This enables users to view a graphical representation of the connections for an application. > _`NewCommand` adds_ > _alias for connections_ > _graph in the spring_ ### Walkthrough * Add an alias "graph" for the "connections" command ([link](https://github.com/radius-project/radius/pull/6489/files?diff=unified&w=0#diff-eb0083d8df9479acb2d5b36bf150aa410e371a26a01619d09c933a73994aa563L27-R31)) --------- Signed-off-by: Aaron Crawfis <[email protected]> (cherry picked from commit 047da70)
6 tasks
kachawla
pushed a commit
that referenced
this issue
Mar 4, 2024
# Description Change "default" command to rad app graph, so that the auto-generated docs use that instead of rad app connections. ## Type of change - This pull request fixes a bug in Radius and has an approved issue (issue link required). Fixes: #6473 --------- Signed-off-by: nithyatsu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Overview of feature request
We've gotten feedback that
rad app connectionsis a confusing name. What we're really showing is the application graph, not just the connections. Since we're using the term application graph more often to talk about Radius this also makes a good command name.Since this is coming in late for public release we should add an alias for now and rename the command in v0.27.
Acceptance criteria
Public Release
rad app graph. This has no risk andrad app connectionswill still work.v0.27
rad app graph. Add an alias back torad app connectionsso that it will still work.Additional context
We want to add this alias in time for the demo.
AB#9727
The text was updated successfully, but these errors were encountered: