Simplify API Registration - DatastoresRP, DaprRP, MessagingRP #6269
Labels
triaged
This issue has been reviewed and triaged
Comments
This was referenced Oct 19, 2023
shalabhms
pushed a commit
that referenced
this issue
Oct 27, 2023
# Description Updating API routes for messagingrp ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request adds or changes features of Radius and has an approved issue #6269 . <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: partially fixes #6269 ## Auto-generated summary <!-- GitHub Copilot for docs will auto-generate a summary of the PR --> <!-- copilot:all --> ### <samp>🤖 Generated by Copilot at 0e1a373</samp> ### Summary 🔄🚀🗑️ <!-- 1. 🔄 - This emoji represents the changes that update the configuration files and the documentation to reflect the new port assignments and the new resource provider for messaging features. This emoji conveys the idea of changing or updating something to match the current situation. 2. 🚀 - This emoji represents the changes that add the new operations.go, setup_test.go, and setup.go files for the messaging resource provider, and enable the applications resource provider to support messaging resources. This emoji conveys the idea of launching or introducing a new feature or functionality. 3. 🗑️ - This emoji represents the changes that remove obsolete operations from the getoperations.go file and the messaging-related code from the routes_test.go and routes.go files. This emoji conveys the idea of deleting or discarding something that is no longer needed or relevant. --> This pull request refactors the codebase to move the messaging functionality from the `portableresources` resource provider to the `applications` resource provider. It adds new files for the `messagingrp` package, which defines the operations and setup for the messaging resource provider. It also updates the configuration files and the documentation to reflect the new port and resource provider for the messaging feature. It removes the obsolete code and tests related to messaging from the `portableresources` package. > _`portableresources`_ > _No longer handles messaging_ > _Spring cleaning is done_ ### Walkthrough * Add messaging resource provider to applications resource provider ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-667f05aa16f6dfd1d55d0ca1392411a09981560434524889a6dfe768679673fcR46), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-667f05aa16f6dfd1d55d0ca1392411a09981560434524889a6dfe768679673fcR161), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-b30407415dd2a84746f6d50dd44a5cbad71eb44630df88c735e715edfb852ac4R1-R84), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-d5a626f9259dd5b3c41f58ce71fdc82afd0c54be8a9835bf80e1a54fa2011f04R1-R92)) * Import messagingrp/setup package in `cmd/applications-rp/main.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-667f05aa16f6dfd1d55d0ca1392411a09981560434524889a6dfe768679673fcR46)) * Add messaging namespace builder to applications resource provider builder in `cmd/applications-rp/main.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-667f05aa16f6dfd1d55d0ca1392411a09981560434524889a6dfe768679673fcR161)) * Define setup function for messaging namespace in `pkg/messagingrp/setup/setup.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-b30407415dd2a84746f6d50dd44a5cbad71eb44630df88c735e715edfb852ac4R1-R84)) * Register messaging resource types and operations with builder and async job controller in `pkg/messagingrp/setup/setup.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-b30407415dd2a84746f6d50dd44a5cbad71eb44630df88c735e715edfb852ac4R1-R84)) * Define operations for messaging resource provider in `pkg/messagingrp/setup/operations.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-d5a626f9259dd5b3c41f58ce71fdc82afd0c54be8a9835bf80e1a54fa2011f04R1-R92)) * Update configuration files and documentation for messaging resource provider port changes ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-ceba0600c7e49ffd65b0a2fd7bf1798d9f6f6f531db64e051bb00ff29c7dcd93L42-R42), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-be9c0b61a26165c87503e667cec005520aea94da66f0dd1eedfff863efd266acL40-R40), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-c5a6e900bac29ec26476b731e62862ee9afb8f9f67225da0aa8fd1d052f8183fL235-R235)) * Use port 8080 for both Applications.Core and Applications.Messaging resource providers in ucp-self-hosted-dev environment in `cmd/ucpd/ucp-self-hosted-dev.yaml` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-ceba0600c7e49ffd65b0a2fd7bf1798d9f6f6f531db64e051bb00ff29c7dcd93L42-R42)) * Use port 5443 for Applications.Messaging resource provider in ucp deployment in `deploy/Chart/templates/ucp/configmaps.yaml` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-be9c0b61a26165c87503e667cec005520aea94da66f0dd1eedfff863efd266acL40-R40)) * Update documentation for ucp configuration settings to reflect new port for Applications.Messaging resource provider in `docs/contributing/contributing-code/contributing-code-control-plane/configSettings.md` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-c5a6e900bac29ec26476b731e62862ee9afb8f9f67225da0aa8fd1d052f8183fL235-R235)) * Remove messaging operations and routes from portableresources resource provider ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-72c62c901d96d8731589a498aa8646bb01aeefafd5dbcc0b56781120b151b14aL78-L87), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-72c62c901d96d8731589a498aa8646bb01aeefafd5dbcc0b56781120b151b14aL148-L157), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-72c62c901d96d8731589a498aa8646bb01aeefafd5dbcc0b56781120b151b14aL178-L187), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-72c62c901d96d8731589a498aa8646bb01aeefafd5dbcc0b56781120b151b14aL258-L297), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-56d7c0ab8720204bebac59bab3fcfadd0edfac6944a88c61d3188285a57d3c80L42-L45), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-56d7c0ab8720204bebac59bab3fcfadd0edfac6944a88c61d3188285a57d3c80L80-R80), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-56d7c0ab8720204bebac59bab3fcfadd0edfac6944a88c61d3188285a57d3c80L98-L235)) * Remove operation for reading messaging operations from `pkg/portableresources/frontend/handler/getoperations.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-72c62c901d96d8731589a498aa8646bb01aeefafd5dbcc0b56781120b151b14aL78-L87)) * Remove operation for registering messaging resource provider from `pkg/portableresources/frontend/handler/getoperations.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-72c62c901d96d8731589a498aa8646bb01aeefafd5dbcc0b56781120b151b14aL148-L157)) * Remove operation for unregistering messaging resource provider from `pkg/portableresources/frontend/handler/getoperations.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-72c62c901d96d8731589a498aa8646bb01aeefafd5dbcc0b56781120b151b14aL178-L187)) * Remove operations for managing rabbitMQQueues from `pkg/portableresources/frontend/handler/getoperations.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-72c62c901d96d8731589a498aa8646bb01aeefafd5dbcc0b56781120b151b14aL258-L297)) * Remove imports for messagingrp packages from `pkg/portableresources/frontend/handler/routes.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-56d7c0ab8720204bebac59bab3fcfadd0edfac6944a88c61d3188285a57d3c80L42-L45)) * Remove call to AddMessagingRoutes function from `pkg/portableresources/frontend/handler/routes.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-56d7c0ab8720204bebac59bab3fcfadd0edfac6944a88c61d3188285a57d3c80L80-R80)) * Remove definition of AddMessagingRoutes function from `pkg/portableresources/frontend/handler/routes.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-56d7c0ab8720204bebac59bab3fcfadd0edfac6944a88c61d3188285a57d3c80L98-L235)) * Update and add unit tests for messaging resource provider and portableresources resource provider ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-d98a4356c6f2a78c5c9723a3306ff155039b5b2e69e156c91e738de0a7deb7aeR1-R88), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-935e98a3e7f642c3133e7514a00b6b326bc1a321b9a266fac3912ca49fbd4ca5L50-R50), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L31), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L38-L65), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L221-L228), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L264-L270)) * Add unit tests for setup function for messaging namespace in `pkg/messagingrp/setup/setup_test.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-d98a4356c6f2a78c5c9723a3306ff155039b5b2e69e156c91e738de0a7deb7aeR1-R88)) * Update expected number of operations in test for getoperations.go in `pkg/portableresources/frontend/handler/getoperations_test.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-935e98a3e7f642c3133e7514a00b6b326bc1a321b9a266fac3912ca49fbd4ca5L50-R50)) * Remove import for messagingrp controller from `pkg/portableresources/frontend/handler/routes_test.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L31)) * Remove test cases for messaging routes from `pkg/portableresources/frontend/handler/routes_test.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L38-L65)) * Remove test cases for messaging operation statuses and results from `pkg/portableresources/frontend/handler/routes_test.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L221-L228)) * Remove test case for messaging operations from `pkg/portableresources/frontend/handler/routes_test.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L264-L270)) --------- Signed-off-by: sk593 <[email protected]>
shalabhms
pushed a commit
that referenced
this issue
Oct 27, 2023
# Description Updating API routes for datastorerp ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request adds or changes features of Radius and has an approved issue #6269 <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: part of #6269 ## Auto-generated summary <!-- GitHub Copilot for docs will auto-generate a summary of the PR --> <!-- copilot:all --> ### <samp>🤖 Generated by Copilot at 4666003</samp> ### Summary 🚪📝🧹 <!-- 1. 🚪 - This emoji represents the change of ports for Applications.Datastores, which is like opening or closing a door to a different port number. 2. 📝 - This emoji represents the addition of the operations.go, setup.go, and setup_test.go files, as well as the update of the configSettings.md file, which are all related to writing or documenting code. 3. 🧹 - This emoji represents the removal or cleanup of redundant or unused code, such as the operations for Applications.Datastores/* from the getoperations handler and the handler test specs. --> This pull request removes the redundant operations for Applications.Datastores from the getoperations handler and the handler tests, and updates the port for Applications.Datastores in the configuration files and the documentation. It also adds a new package `pkg/datastoresrp/setup` that defines the operations, setup function, and unit tests for the Applications.Datastores resource provider. > _`Datastores` port changed_ > _To avoid conflict and error_ > _Winter of bugs ends_ ### Walkthrough * Change the port for Applications.Datastores from 8081 to 8080 in the `ucp-self-hosted-dev.yaml` file to fix a port conflict issue ([link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-ceba0600c7e49ffd65b0a2fd7bf1798d9f6f6f531db64e051bb00ff29c7dcd93L44-R44)) * Change the port for Applications.Datastores from 5444 to 5443 in the `configmaps.yaml` file and the `configSettings.md` file to align with the previous change and update the documentation ([link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-be9c0b61a26165c87503e667cec005520aea94da66f0dd1eedfff863efd266acL39-R39), [link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-c5a6e900bac29ec26476b731e62862ee9afb8f9f67225da0aa8fd1d052f8183fL234-R234)) * Add the `operations.go` file to the `pkg/datastoresrp/setup` package to define the available operations for the Applications.Datastores resource provider ([link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-038ee92ede58f35d8401332288f5068780baac643f71ed0671b493bcd38ac4d0R1-R172)) * Add the `setup.go` file to the `pkg/datastoresrp/setup` package to define the setup function for the Applications.Datastores resource provider, which builds the namespace and the resource options for each datastore type ([link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-dac7ca2c8cbe7fd5eab5fd3fe83ed18ddd07d7f6d55ba46b8917b24e7b24bfa1R1-R167)) * Add the `setup_test.go` file to the `pkg/datastoresrp/setup` package to define the unit tests for the setup function, using mock objects and the rpctest package ([link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-1270518f609b8ce321ca0dd5f5cda6979baa5b0dd4dc70f616f655be1e70bd3cR1-R146)) * Remove the operations for Applications.Datastores/* from the `getoperations.go` file in the `pkg/portableresources/frontend/handler` package, as they are now defined in the `operations.go` file in the `pkg/datastoresrp/setup` package ([link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-72c62c901d96d8731589a498aa8646bb01aeefafd5dbcc0b56781120b151b14aL68-L77), [link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-72c62c901d96d8731589a498aa8646bb01aeefafd5dbcc0b56781120b151b14aL88-L137), [link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-72c62c901d96d8731589a498aa8646bb01aeefafd5dbcc0b56781120b151b14aL158-L257)) * Change the expected length of the pagination value in the `getoperations_test.go` file in the `pkg/portableresources/frontend/handler` package to reflect the removal of the operations for Applications.Datastores/* ([link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-935e98a3e7f642c3133e7514a00b6b326bc1a321b9a266fac3912ca49fbd4ca5L50-R50)) * Remove the import statement for the ds_ctrl package and comment out or remove the handler test specs for the operation types for Applications.Datastores/* in the `routes_test.go` file in the `pkg/portableresources/frontend/handler` package, as they are no longer defined or used in this file ([link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L30), [link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L137-R136), [link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L221-R220), [link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L277-L283)) --------- Signed-off-by: sk593 <[email protected]>
willdavsmith
pushed a commit
to willdavsmith/radius
that referenced
this issue
Nov 3, 2023
# Description Updating API routes for messagingrp ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request adds or changes features of Radius and has an approved issue radius-project#6269 . <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: partially fixes radius-project#6269 ## Auto-generated summary <!-- GitHub Copilot for docs will auto-generate a summary of the PR --> <!-- copilot:all --> ### <samp>🤖 Generated by Copilot at 0e1a373</samp> ### Summary 🔄🚀🗑️ <!-- 1. 🔄 - This emoji represents the changes that update the configuration files and the documentation to reflect the new port assignments and the new resource provider for messaging features. This emoji conveys the idea of changing or updating something to match the current situation. 2. 🚀 - This emoji represents the changes that add the new operations.go, setup_test.go, and setup.go files for the messaging resource provider, and enable the applications resource provider to support messaging resources. This emoji conveys the idea of launching or introducing a new feature or functionality. 3. 🗑️ - This emoji represents the changes that remove obsolete operations from the getoperations.go file and the messaging-related code from the routes_test.go and routes.go files. This emoji conveys the idea of deleting or discarding something that is no longer needed or relevant. --> This pull request refactors the codebase to move the messaging functionality from the `portableresources` resource provider to the `applications` resource provider. It adds new files for the `messagingrp` package, which defines the operations and setup for the messaging resource provider. It also updates the configuration files and the documentation to reflect the new port and resource provider for the messaging feature. It removes the obsolete code and tests related to messaging from the `portableresources` package. > _`portableresources`_ > _No longer handles messaging_ > _Spring cleaning is done_ ### Walkthrough * Add messaging resource provider to applications resource provider ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-667f05aa16f6dfd1d55d0ca1392411a09981560434524889a6dfe768679673fcR46), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-667f05aa16f6dfd1d55d0ca1392411a09981560434524889a6dfe768679673fcR161), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-b30407415dd2a84746f6d50dd44a5cbad71eb44630df88c735e715edfb852ac4R1-R84), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-d5a626f9259dd5b3c41f58ce71fdc82afd0c54be8a9835bf80e1a54fa2011f04R1-R92)) * Import messagingrp/setup package in `cmd/applications-rp/main.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-667f05aa16f6dfd1d55d0ca1392411a09981560434524889a6dfe768679673fcR46)) * Add messaging namespace builder to applications resource provider builder in `cmd/applications-rp/main.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-667f05aa16f6dfd1d55d0ca1392411a09981560434524889a6dfe768679673fcR161)) * Define setup function for messaging namespace in `pkg/messagingrp/setup/setup.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-b30407415dd2a84746f6d50dd44a5cbad71eb44630df88c735e715edfb852ac4R1-R84)) * Register messaging resource types and operations with builder and async job controller in `pkg/messagingrp/setup/setup.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-b30407415dd2a84746f6d50dd44a5cbad71eb44630df88c735e715edfb852ac4R1-R84)) * Define operations for messaging resource provider in `pkg/messagingrp/setup/operations.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-d5a626f9259dd5b3c41f58ce71fdc82afd0c54be8a9835bf80e1a54fa2011f04R1-R92)) * Update configuration files and documentation for messaging resource provider port changes ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-ceba0600c7e49ffd65b0a2fd7bf1798d9f6f6f531db64e051bb00ff29c7dcd93L42-R42), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-be9c0b61a26165c87503e667cec005520aea94da66f0dd1eedfff863efd266acL40-R40), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-c5a6e900bac29ec26476b731e62862ee9afb8f9f67225da0aa8fd1d052f8183fL235-R235)) * Use port 8080 for both Applications.Core and Applications.Messaging resource providers in ucp-self-hosted-dev environment in `cmd/ucpd/ucp-self-hosted-dev.yaml` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-ceba0600c7e49ffd65b0a2fd7bf1798d9f6f6f531db64e051bb00ff29c7dcd93L42-R42)) * Use port 5443 for Applications.Messaging resource provider in ucp deployment in `deploy/Chart/templates/ucp/configmaps.yaml` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-be9c0b61a26165c87503e667cec005520aea94da66f0dd1eedfff863efd266acL40-R40)) * Update documentation for ucp configuration settings to reflect new port for Applications.Messaging resource provider in `docs/contributing/contributing-code/contributing-code-control-plane/configSettings.md` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-c5a6e900bac29ec26476b731e62862ee9afb8f9f67225da0aa8fd1d052f8183fL235-R235)) * Remove messaging operations and routes from portableresources resource provider ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-72c62c901d96d8731589a498aa8646bb01aeefafd5dbcc0b56781120b151b14aL78-L87), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-72c62c901d96d8731589a498aa8646bb01aeefafd5dbcc0b56781120b151b14aL148-L157), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-72c62c901d96d8731589a498aa8646bb01aeefafd5dbcc0b56781120b151b14aL178-L187), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-72c62c901d96d8731589a498aa8646bb01aeefafd5dbcc0b56781120b151b14aL258-L297), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-56d7c0ab8720204bebac59bab3fcfadd0edfac6944a88c61d3188285a57d3c80L42-L45), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-56d7c0ab8720204bebac59bab3fcfadd0edfac6944a88c61d3188285a57d3c80L80-R80), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-56d7c0ab8720204bebac59bab3fcfadd0edfac6944a88c61d3188285a57d3c80L98-L235)) * Remove operation for reading messaging operations from `pkg/portableresources/frontend/handler/getoperations.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-72c62c901d96d8731589a498aa8646bb01aeefafd5dbcc0b56781120b151b14aL78-L87)) * Remove operation for registering messaging resource provider from `pkg/portableresources/frontend/handler/getoperations.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-72c62c901d96d8731589a498aa8646bb01aeefafd5dbcc0b56781120b151b14aL148-L157)) * Remove operation for unregistering messaging resource provider from `pkg/portableresources/frontend/handler/getoperations.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-72c62c901d96d8731589a498aa8646bb01aeefafd5dbcc0b56781120b151b14aL178-L187)) * Remove operations for managing rabbitMQQueues from `pkg/portableresources/frontend/handler/getoperations.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-72c62c901d96d8731589a498aa8646bb01aeefafd5dbcc0b56781120b151b14aL258-L297)) * Remove imports for messagingrp packages from `pkg/portableresources/frontend/handler/routes.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-56d7c0ab8720204bebac59bab3fcfadd0edfac6944a88c61d3188285a57d3c80L42-L45)) * Remove call to AddMessagingRoutes function from `pkg/portableresources/frontend/handler/routes.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-56d7c0ab8720204bebac59bab3fcfadd0edfac6944a88c61d3188285a57d3c80L80-R80)) * Remove definition of AddMessagingRoutes function from `pkg/portableresources/frontend/handler/routes.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-56d7c0ab8720204bebac59bab3fcfadd0edfac6944a88c61d3188285a57d3c80L98-L235)) * Update and add unit tests for messaging resource provider and portableresources resource provider ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-d98a4356c6f2a78c5c9723a3306ff155039b5b2e69e156c91e738de0a7deb7aeR1-R88), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-935e98a3e7f642c3133e7514a00b6b326bc1a321b9a266fac3912ca49fbd4ca5L50-R50), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L31), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L38-L65), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L221-L228), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L264-L270)) * Add unit tests for setup function for messaging namespace in `pkg/messagingrp/setup/setup_test.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-d98a4356c6f2a78c5c9723a3306ff155039b5b2e69e156c91e738de0a7deb7aeR1-R88)) * Update expected number of operations in test for getoperations.go in `pkg/portableresources/frontend/handler/getoperations_test.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-935e98a3e7f642c3133e7514a00b6b326bc1a321b9a266fac3912ca49fbd4ca5L50-R50)) * Remove import for messagingrp controller from `pkg/portableresources/frontend/handler/routes_test.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L31)) * Remove test cases for messaging routes from `pkg/portableresources/frontend/handler/routes_test.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L38-L65)) * Remove test cases for messaging operation statuses and results from `pkg/portableresources/frontend/handler/routes_test.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L221-L228)) * Remove test case for messaging operations from `pkg/portableresources/frontend/handler/routes_test.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L264-L270)) --------- Signed-off-by: sk593 <[email protected]> Signed-off-by: willdavsmith <[email protected]>
willdavsmith
pushed a commit
to willdavsmith/radius
that referenced
this issue
Nov 3, 2023
# Description Updating API routes for datastorerp ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request adds or changes features of Radius and has an approved issue radius-project#6269 <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: part of radius-project#6269 ## Auto-generated summary <!-- GitHub Copilot for docs will auto-generate a summary of the PR --> <!-- copilot:all --> ### <samp>🤖 Generated by Copilot at 4666003</samp> ### Summary 🚪📝🧹 <!-- 1. 🚪 - This emoji represents the change of ports for Applications.Datastores, which is like opening or closing a door to a different port number. 2. 📝 - This emoji represents the addition of the operations.go, setup.go, and setup_test.go files, as well as the update of the configSettings.md file, which are all related to writing or documenting code. 3. 🧹 - This emoji represents the removal or cleanup of redundant or unused code, such as the operations for Applications.Datastores/* from the getoperations handler and the handler test specs. --> This pull request removes the redundant operations for Applications.Datastores from the getoperations handler and the handler tests, and updates the port for Applications.Datastores in the configuration files and the documentation. It also adds a new package `pkg/datastoresrp/setup` that defines the operations, setup function, and unit tests for the Applications.Datastores resource provider. > _`Datastores` port changed_ > _To avoid conflict and error_ > _Winter of bugs ends_ ### Walkthrough * Change the port for Applications.Datastores from 8081 to 8080 in the `ucp-self-hosted-dev.yaml` file to fix a port conflict issue ([link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-ceba0600c7e49ffd65b0a2fd7bf1798d9f6f6f531db64e051bb00ff29c7dcd93L44-R44)) * Change the port for Applications.Datastores from 5444 to 5443 in the `configmaps.yaml` file and the `configSettings.md` file to align with the previous change and update the documentation ([link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-be9c0b61a26165c87503e667cec005520aea94da66f0dd1eedfff863efd266acL39-R39), [link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-c5a6e900bac29ec26476b731e62862ee9afb8f9f67225da0aa8fd1d052f8183fL234-R234)) * Add the `operations.go` file to the `pkg/datastoresrp/setup` package to define the available operations for the Applications.Datastores resource provider ([link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-038ee92ede58f35d8401332288f5068780baac643f71ed0671b493bcd38ac4d0R1-R172)) * Add the `setup.go` file to the `pkg/datastoresrp/setup` package to define the setup function for the Applications.Datastores resource provider, which builds the namespace and the resource options for each datastore type ([link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-dac7ca2c8cbe7fd5eab5fd3fe83ed18ddd07d7f6d55ba46b8917b24e7b24bfa1R1-R167)) * Add the `setup_test.go` file to the `pkg/datastoresrp/setup` package to define the unit tests for the setup function, using mock objects and the rpctest package ([link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-1270518f609b8ce321ca0dd5f5cda6979baa5b0dd4dc70f616f655be1e70bd3cR1-R146)) * Remove the operations for Applications.Datastores/* from the `getoperations.go` file in the `pkg/portableresources/frontend/handler` package, as they are now defined in the `operations.go` file in the `pkg/datastoresrp/setup` package ([link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-72c62c901d96d8731589a498aa8646bb01aeefafd5dbcc0b56781120b151b14aL68-L77), [link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-72c62c901d96d8731589a498aa8646bb01aeefafd5dbcc0b56781120b151b14aL88-L137), [link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-72c62c901d96d8731589a498aa8646bb01aeefafd5dbcc0b56781120b151b14aL158-L257)) * Change the expected length of the pagination value in the `getoperations_test.go` file in the `pkg/portableresources/frontend/handler` package to reflect the removal of the operations for Applications.Datastores/* ([link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-935e98a3e7f642c3133e7514a00b6b326bc1a321b9a266fac3912ca49fbd4ca5L50-R50)) * Remove the import statement for the ds_ctrl package and comment out or remove the handler test specs for the operation types for Applications.Datastores/* in the `routes_test.go` file in the `pkg/portableresources/frontend/handler` package, as they are no longer defined or used in this file ([link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L30), [link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L137-R136), [link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L221-R220), [link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L277-L283)) --------- Signed-off-by: sk593 <[email protected]> Signed-off-by: willdavsmith <[email protected]>
willdavsmith
pushed a commit
that referenced
this issue
Nov 6, 2023
# Description Updating API routes for messagingrp ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request adds or changes features of Radius and has an approved issue #6269 . <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: partially fixes #6269 ## Auto-generated summary <!-- GitHub Copilot for docs will auto-generate a summary of the PR --> <!-- copilot:all --> ### <samp>🤖 Generated by Copilot at 0e1a373</samp> ### Summary 🔄🚀🗑️ <!-- 1. 🔄 - This emoji represents the changes that update the configuration files and the documentation to reflect the new port assignments and the new resource provider for messaging features. This emoji conveys the idea of changing or updating something to match the current situation. 2. 🚀 - This emoji represents the changes that add the new operations.go, setup_test.go, and setup.go files for the messaging resource provider, and enable the applications resource provider to support messaging resources. This emoji conveys the idea of launching or introducing a new feature or functionality. 3. 🗑️ - This emoji represents the changes that remove obsolete operations from the getoperations.go file and the messaging-related code from the routes_test.go and routes.go files. This emoji conveys the idea of deleting or discarding something that is no longer needed or relevant. --> This pull request refactors the codebase to move the messaging functionality from the `portableresources` resource provider to the `applications` resource provider. It adds new files for the `messagingrp` package, which defines the operations and setup for the messaging resource provider. It also updates the configuration files and the documentation to reflect the new port and resource provider for the messaging feature. It removes the obsolete code and tests related to messaging from the `portableresources` package. > _`portableresources`_ > _No longer handles messaging_ > _Spring cleaning is done_ ### Walkthrough * Add messaging resource provider to applications resource provider ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-667f05aa16f6dfd1d55d0ca1392411a09981560434524889a6dfe768679673fcR46), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-667f05aa16f6dfd1d55d0ca1392411a09981560434524889a6dfe768679673fcR161), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-b30407415dd2a84746f6d50dd44a5cbad71eb44630df88c735e715edfb852ac4R1-R84), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-d5a626f9259dd5b3c41f58ce71fdc82afd0c54be8a9835bf80e1a54fa2011f04R1-R92)) * Import messagingrp/setup package in `cmd/applications-rp/main.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-667f05aa16f6dfd1d55d0ca1392411a09981560434524889a6dfe768679673fcR46)) * Add messaging namespace builder to applications resource provider builder in `cmd/applications-rp/main.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-667f05aa16f6dfd1d55d0ca1392411a09981560434524889a6dfe768679673fcR161)) * Define setup function for messaging namespace in `pkg/messagingrp/setup/setup.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-b30407415dd2a84746f6d50dd44a5cbad71eb44630df88c735e715edfb852ac4R1-R84)) * Register messaging resource types and operations with builder and async job controller in `pkg/messagingrp/setup/setup.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-b30407415dd2a84746f6d50dd44a5cbad71eb44630df88c735e715edfb852ac4R1-R84)) * Define operations for messaging resource provider in `pkg/messagingrp/setup/operations.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-d5a626f9259dd5b3c41f58ce71fdc82afd0c54be8a9835bf80e1a54fa2011f04R1-R92)) * Update configuration files and documentation for messaging resource provider port changes ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-ceba0600c7e49ffd65b0a2fd7bf1798d9f6f6f531db64e051bb00ff29c7dcd93L42-R42), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-be9c0b61a26165c87503e667cec005520aea94da66f0dd1eedfff863efd266acL40-R40), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-c5a6e900bac29ec26476b731e62862ee9afb8f9f67225da0aa8fd1d052f8183fL235-R235)) * Use port 8080 for both Applications.Core and Applications.Messaging resource providers in ucp-self-hosted-dev environment in `cmd/ucpd/ucp-self-hosted-dev.yaml` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-ceba0600c7e49ffd65b0a2fd7bf1798d9f6f6f531db64e051bb00ff29c7dcd93L42-R42)) * Use port 5443 for Applications.Messaging resource provider in ucp deployment in `deploy/Chart/templates/ucp/configmaps.yaml` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-be9c0b61a26165c87503e667cec005520aea94da66f0dd1eedfff863efd266acL40-R40)) * Update documentation for ucp configuration settings to reflect new port for Applications.Messaging resource provider in `docs/contributing/contributing-code/contributing-code-control-plane/configSettings.md` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-c5a6e900bac29ec26476b731e62862ee9afb8f9f67225da0aa8fd1d052f8183fL235-R235)) * Remove messaging operations and routes from portableresources resource provider ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-72c62c901d96d8731589a498aa8646bb01aeefafd5dbcc0b56781120b151b14aL78-L87), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-72c62c901d96d8731589a498aa8646bb01aeefafd5dbcc0b56781120b151b14aL148-L157), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-72c62c901d96d8731589a498aa8646bb01aeefafd5dbcc0b56781120b151b14aL178-L187), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-72c62c901d96d8731589a498aa8646bb01aeefafd5dbcc0b56781120b151b14aL258-L297), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-56d7c0ab8720204bebac59bab3fcfadd0edfac6944a88c61d3188285a57d3c80L42-L45), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-56d7c0ab8720204bebac59bab3fcfadd0edfac6944a88c61d3188285a57d3c80L80-R80), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-56d7c0ab8720204bebac59bab3fcfadd0edfac6944a88c61d3188285a57d3c80L98-L235)) * Remove operation for reading messaging operations from `pkg/portableresources/frontend/handler/getoperations.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-72c62c901d96d8731589a498aa8646bb01aeefafd5dbcc0b56781120b151b14aL78-L87)) * Remove operation for registering messaging resource provider from `pkg/portableresources/frontend/handler/getoperations.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-72c62c901d96d8731589a498aa8646bb01aeefafd5dbcc0b56781120b151b14aL148-L157)) * Remove operation for unregistering messaging resource provider from `pkg/portableresources/frontend/handler/getoperations.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-72c62c901d96d8731589a498aa8646bb01aeefafd5dbcc0b56781120b151b14aL178-L187)) * Remove operations for managing rabbitMQQueues from `pkg/portableresources/frontend/handler/getoperations.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-72c62c901d96d8731589a498aa8646bb01aeefafd5dbcc0b56781120b151b14aL258-L297)) * Remove imports for messagingrp packages from `pkg/portableresources/frontend/handler/routes.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-56d7c0ab8720204bebac59bab3fcfadd0edfac6944a88c61d3188285a57d3c80L42-L45)) * Remove call to AddMessagingRoutes function from `pkg/portableresources/frontend/handler/routes.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-56d7c0ab8720204bebac59bab3fcfadd0edfac6944a88c61d3188285a57d3c80L80-R80)) * Remove definition of AddMessagingRoutes function from `pkg/portableresources/frontend/handler/routes.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-56d7c0ab8720204bebac59bab3fcfadd0edfac6944a88c61d3188285a57d3c80L98-L235)) * Update and add unit tests for messaging resource provider and portableresources resource provider ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-d98a4356c6f2a78c5c9723a3306ff155039b5b2e69e156c91e738de0a7deb7aeR1-R88), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-935e98a3e7f642c3133e7514a00b6b326bc1a321b9a266fac3912ca49fbd4ca5L50-R50), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L31), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L38-L65), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L221-L228), [link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L264-L270)) * Add unit tests for setup function for messaging namespace in `pkg/messagingrp/setup/setup_test.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-d98a4356c6f2a78c5c9723a3306ff155039b5b2e69e156c91e738de0a7deb7aeR1-R88)) * Update expected number of operations in test for getoperations.go in `pkg/portableresources/frontend/handler/getoperations_test.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-935e98a3e7f642c3133e7514a00b6b326bc1a321b9a266fac3912ca49fbd4ca5L50-R50)) * Remove import for messagingrp controller from `pkg/portableresources/frontend/handler/routes_test.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L31)) * Remove test cases for messaging routes from `pkg/portableresources/frontend/handler/routes_test.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L38-L65)) * Remove test cases for messaging operation statuses and results from `pkg/portableresources/frontend/handler/routes_test.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L221-L228)) * Remove test case for messaging operations from `pkg/portableresources/frontend/handler/routes_test.go` ([link](https://github.com/radius-project/radius/pull/6586/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L264-L270)) --------- Signed-off-by: sk593 <[email protected]> Signed-off-by: willdavsmith <[email protected]>
willdavsmith
pushed a commit
that referenced
this issue
Nov 6, 2023
# Description Updating API routes for datastorerp ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request adds or changes features of Radius and has an approved issue #6269 <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: part of #6269 ## Auto-generated summary <!-- GitHub Copilot for docs will auto-generate a summary of the PR --> <!-- copilot:all --> ### <samp>🤖 Generated by Copilot at 4666003</samp> ### Summary 🚪📝🧹 <!-- 1. 🚪 - This emoji represents the change of ports for Applications.Datastores, which is like opening or closing a door to a different port number. 2. 📝 - This emoji represents the addition of the operations.go, setup.go, and setup_test.go files, as well as the update of the configSettings.md file, which are all related to writing or documenting code. 3. 🧹 - This emoji represents the removal or cleanup of redundant or unused code, such as the operations for Applications.Datastores/* from the getoperations handler and the handler test specs. --> This pull request removes the redundant operations for Applications.Datastores from the getoperations handler and the handler tests, and updates the port for Applications.Datastores in the configuration files and the documentation. It also adds a new package `pkg/datastoresrp/setup` that defines the operations, setup function, and unit tests for the Applications.Datastores resource provider. > _`Datastores` port changed_ > _To avoid conflict and error_ > _Winter of bugs ends_ ### Walkthrough * Change the port for Applications.Datastores from 8081 to 8080 in the `ucp-self-hosted-dev.yaml` file to fix a port conflict issue ([link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-ceba0600c7e49ffd65b0a2fd7bf1798d9f6f6f531db64e051bb00ff29c7dcd93L44-R44)) * Change the port for Applications.Datastores from 5444 to 5443 in the `configmaps.yaml` file and the `configSettings.md` file to align with the previous change and update the documentation ([link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-be9c0b61a26165c87503e667cec005520aea94da66f0dd1eedfff863efd266acL39-R39), [link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-c5a6e900bac29ec26476b731e62862ee9afb8f9f67225da0aa8fd1d052f8183fL234-R234)) * Add the `operations.go` file to the `pkg/datastoresrp/setup` package to define the available operations for the Applications.Datastores resource provider ([link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-038ee92ede58f35d8401332288f5068780baac643f71ed0671b493bcd38ac4d0R1-R172)) * Add the `setup.go` file to the `pkg/datastoresrp/setup` package to define the setup function for the Applications.Datastores resource provider, which builds the namespace and the resource options for each datastore type ([link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-dac7ca2c8cbe7fd5eab5fd3fe83ed18ddd07d7f6d55ba46b8917b24e7b24bfa1R1-R167)) * Add the `setup_test.go` file to the `pkg/datastoresrp/setup` package to define the unit tests for the setup function, using mock objects and the rpctest package ([link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-1270518f609b8ce321ca0dd5f5cda6979baa5b0dd4dc70f616f655be1e70bd3cR1-R146)) * Remove the operations for Applications.Datastores/* from the `getoperations.go` file in the `pkg/portableresources/frontend/handler` package, as they are now defined in the `operations.go` file in the `pkg/datastoresrp/setup` package ([link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-72c62c901d96d8731589a498aa8646bb01aeefafd5dbcc0b56781120b151b14aL68-L77), [link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-72c62c901d96d8731589a498aa8646bb01aeefafd5dbcc0b56781120b151b14aL88-L137), [link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-72c62c901d96d8731589a498aa8646bb01aeefafd5dbcc0b56781120b151b14aL158-L257)) * Change the expected length of the pagination value in the `getoperations_test.go` file in the `pkg/portableresources/frontend/handler` package to reflect the removal of the operations for Applications.Datastores/* ([link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-935e98a3e7f642c3133e7514a00b6b326bc1a321b9a266fac3912ca49fbd4ca5L50-R50)) * Remove the import statement for the ds_ctrl package and comment out or remove the handler test specs for the operation types for Applications.Datastores/* in the `routes_test.go` file in the `pkg/portableresources/frontend/handler` package, as they are no longer defined or used in this file ([link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L30), [link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L137-R136), [link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L221-R220), [link](https://github.com/radius-project/radius/pull/6522/files?diff=unified&w=0#diff-2792dae138ce1d90b14d02d5f207e29a4a144886ca9ece6faab8e8effc47e851L277-L283)) --------- Signed-off-by: sk593 <[email protected]> Signed-off-by: willdavsmith <[email protected]>
|
Reopening so we can finish out some cleanup |
sk593
added a commit
that referenced
this issue
Nov 14, 2023
# Description This removes references to the old portable resource API route registration ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius #6269 <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: #6269 ## Auto-generated summary <!-- GitHub Copilot for docs will auto-generate a summary of the PR --> <!-- copilot:all --> ### <samp>🤖 Generated by Copilot at 07ad71e</samp> ### Summary 🗑️📦🛠️ <!-- 1. 🗑️ - This emoji represents the removal of unused or unnecessary code or files, such as the flag and the configmap. 2. 📦 - This emoji represents the packaging or embedding of the portable resource configuration in the host options, making it easier to deploy and manage the service. 3. 🛠️ - This emoji represents the improvement or simplification of the service by using the new configuration mechanism. --> This pull request embeds the portable resource configuration in the host options of the applications-rp service. It removes the `--portableresource-config` flag and the `portableresource-*.yaml` files from the code, the launch configuration, and the Helm chart templates. This simplifies the service configuration and deployment. > _No more flags of doom, no more files of despair_ > _We embed the power in the host, we unleash the portable resource_ > _We simplify the service, we remove the obsolete code_ > _We are the applications-rp, we are the masters of the helm_ ### Walkthrough * Remove `--portableresource-config` flag and related variables from applications-rp service ([link](https://github.com/radius-project/radius/pull/6687/files?diff=unified&w=0#diff-bd5430ee7c51dc892a67b3f2829d1f5b6d223f0fd48b82322cfd45baf9f5e945L17-L18), [link](https://github.com/radius-project/radius/pull/6687/files?diff=unified&w=0#diff-667f05aa16f6dfd1d55d0ca1392411a09981560434524889a6dfe768679673fcL58-L62), [link](https://github.com/radius-project/radius/pull/6687/files?diff=unified&w=0#diff-92bd08c7c2302e12d2ceb2f7bf0a5bdd0016bb8e2eb2639588e994366e9ee841L35)) * Remove loading and assignment of portable resource configuration from environment and ETCD client in `main.go` ([link](https://github.com/radius-project/radius/pull/6687/files?diff=unified&w=0#diff-667f05aa16f6dfd1d55d0ca1392411a09981560434524889a6dfe768679673fcL92-L97), [link](https://github.com/radius-project/radius/pull/6687/files?diff=unified&w=0#diff-667f05aa16f6dfd1d55d0ca1392411a09981560434524889a6dfe768679673fcL108-L111)) * Remove portableresource-self-host.yaml file from configmaps template in Helm chart ([link](https://github.com/radius-project/radius/pull/6687/files?diff=unified&w=0#diff-58d6d96c3a9a74e33fc72e9a458a3e9f4c463287d906985725fddb0398081126L59-L108)) * Delete unused portable resource configuration files ([link](https://github.com/radius-project/radius/pull/6687/files?diff=unified&w=0#diff-5b57e9314a18299dc316a8cfec855ae859078a6b3baaf8a9d9205f4d1e26e665), [link](https://github.com/radius-project/radius/pull/6687/files?diff=unified&w=0#diff-a9312f9d13becb76eeb2cba6b9a0f78cc182ae1c203e3f3db5899f3aec534940)) --------- Signed-off-by: sk593 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Overview of feature request
Ref: #5851
@youngbupark and @rynowak helped update current service, httproutes, operations and api registration for corerp.
The remaining RPs (DatastoresRP, DaprRP, MessagingRP) will need to have code updated to conform to updated api registration and merging of 'applications.datastores' service into now updated 'radius' service.
Acceptance criteria
Code updated in DatastoresRP, DaprRP, MessagingRP for updated API registration using as reference updates done in pkg/corerp/setup and associated files in corerp.
Single service 'radius' will serve all resource providers in radius.
Additional context
AB#9362
The text was updated successfully, but these errors were encountered: