Skip to content

Commit

Permalink
Restore AWS S3 tests (#6993)
Browse files Browse the repository at this point in the history
# Description

AWS CloudFormation seems to have reverted the spec changes to S3 buckets
to make them non-idempotent resources. We should now be able to
re-enable our tests.

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: #6948

Signed-off-by: willdavsmith <[email protected]>
  • Loading branch information
willdavsmith authored Jan 8, 2024
1 parent 16011a5 commit fcd096e
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/purge-aws-test-resources.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,4 @@ jobs:
aws-region: ${{ env.AWS_REGION }}
- name: Delete old AWS resources
run: |
./.github/scripts/delete_aws_resources.sh ${{ env.AWS_RESOURCE_TYPES }}
./.github/scripts/delete-aws-resources.sh ${{ env.AWS_RESOURCE_TYPES }}
1 change: 0 additions & 1 deletion test/functional/shared/mechanics/aws_mechanics_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ import (
)

func Test_AWSRedeployWithUpdatedResourceUpdatesResource(t *testing.T) {
t.Skip("Skipping until we resolve https://github.com/radius-project/radius/issues/6535")
templateFmt := "testdata/aws-mechanics-redeploy-withupdatedresource.step%d.bicep"
name := "radiusfunctionaltestbucket-" + uuid.New().String()
creationTimestamp := functional.GetCreationTimestamp()
Expand Down
2 changes: 0 additions & 2 deletions test/functional/shared/resources/aws_s3_bucket_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import (
)

func Test_AWS_S3Bucket(t *testing.T) {
t.Skip("Skipping until we resolve https://github.com/radius-project/radius/issues/6535")
template := "testdata/aws-s3-bucket.bicep"
name := functional.GenerateS3BucketName()
creationTimestamp := functional.GetCreationTimestamp()
Expand Down Expand Up @@ -65,7 +64,6 @@ func Test_AWS_S3Bucket(t *testing.T) {
}

func Test_AWS_S3Bucket_Existing(t *testing.T) {
t.Skip("Skipping until we resolve https://github.com/radius-project/radius/issues/6535")
template := "testdata/aws-s3-bucket.bicep"
templateExisting := "testdata/aws-s3-bucket-existing.bicep"
name := functional.GenerateS3BucketName()
Expand Down
1 change: 0 additions & 1 deletion test/functional/shared/resources/extender_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ func Test_Extender_Recipe(t *testing.T) {
}

func Test_Extender_RecipeAWS(t *testing.T) {
t.Skip("Skipping until we resolve https://github.com/radius-project/radius/issues/6535")
awsAccountID := os.Getenv("AWS_ACCOUNT_ID")
awsRegion := os.Getenv("AWS_REGION")
// Error the test if the required environment variables are not set
Expand Down
2 changes: 0 additions & 2 deletions test/functional/ucp/aws_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ var (
)

func Test_AWS_DeleteResource(t *testing.T) {
t.Skip("Skipping until we resolve https://github.com/radius-project/radius/issues/6535")
ctx := context.Background()

bucketName := generateS3BucketName()
Expand Down Expand Up @@ -106,7 +105,6 @@ func Test_AWS_DeleteResource(t *testing.T) {
}

func Test_AWS_ListResources(t *testing.T) {
t.Skip("Skipping until we resolve https://github.com/radius-project/radius/issues/6535")
ctx := context.Background()

var bucketName = generateS3BucketName()
Expand Down

0 comments on commit fcd096e

Please sign in to comment.