Skip to content

Commit

Permalink
Add missing async job controller for corerp and delete dead code. (#6243
Browse files Browse the repository at this point in the history
)

# Description

* Add deployment processor for corerp resource deletion
* Delete dead code in corerp

## Type of change

- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

## Auto-generated summary

<!--
GitHub Copilot for docs will auto-generate a summary of the PR
-->

<!--
copilot:all
-->
### <samp>🤖 Generated by Copilot at 0c13b30</samp>

### Summary
🗑️🛣️📦

<!--
1. 🗑️ - This emoji represents the deletion or removal of something,
which is the main purpose of the added operations.
2. 🛣️ - This emoji represents the HTTPRoute resource type, which is used
to define how requests are routed to different services or endpoints in
Radius.
3. 📦 - This emoji represents the ContainerResource and VolumeResource
resource types, which are used to define the containers and volumes that
run the applications and store the data in Radius.
-->
This pull request implements delete functionality for custom resources
in the Radius core package. It also removes two unused files from the
`pkg/corerp/backend` directory.

> _Oh, we're the crew of the Radius ship, and we sail the code sea_
> _We create and update our resources, but sometimes we must delete_
> _So we pull on the rope and we sing this song, as we heave on the
count of three_
> _`HTTPRoute`, `ContainerResource`, `Gateway`, and `VolumeResource`,
goodbye to ye_

### Walkthrough
* Add delete operations for custom resources
([link](https://github.com/radius-project/radius/pull/6243/files?diff=unified&w=0#diff-1dfecb9519c9002f569daea7fb61bbb0b1f22e34d49ac2d03eeb3bc64e858c8fR92-R94),
[link](https://github.com/radius-project/radius/pull/6243/files?diff=unified&w=0#diff-1dfecb9519c9002f569daea7fb61bbb0b1f22e34d49ac2d03eeb3bc64e858c8fR115-R117),
[link](https://github.com/radius-project/radius/pull/6243/files?diff=unified&w=0#diff-1dfecb9519c9002f569daea7fb61bbb0b1f22e34d49ac2d03eeb3bc64e858c8fR138-R140),
[link](https://github.com/radius-project/radius/pull/6243/files?diff=unified&w=0#diff-1dfecb9519c9002f569daea7fb61bbb0b1f22e34d49ac2d03eeb3bc64e858c8fR161-R163))
* Remove unused files
([link](https://github.com/radius-project/radius/pull/6243/files?diff=unified&w=0#diff-5d6b976ca1401aa4b4ea6fdaf8142700ada0d6ddd9690bb7eed8797f91d33466),
[link](https://github.com/radius-project/radius/pull/6243/files?diff=unified&w=0#diff-0fb3b9f2c9139180171c66e076eacdb9f6ea1b44e8a3356a8dbc688436614535))
  • Loading branch information
youngbupark authored Sep 11, 2023
1 parent 2606ade commit eaee260
Show file tree
Hide file tree
Showing 6 changed files with 48 additions and 1,696 deletions.
183 changes: 0 additions & 183 deletions pkg/corerp/backend/service.go

This file was deleted.

86 changes: 0 additions & 86 deletions pkg/corerp/backend/systemservice.go

This file was deleted.

Loading

0 comments on commit eaee260

Please sign in to comment.