Merge branch 'main' into fix_7070

.github/workflows/close-stale-prs.yml

@@ -0,0 +1,27 @@
+# This workflow warns and then closes PRs that have had no activity for 90 days.
+#
+# For more information, see:
+# https://github.com/actions/stale
+name: Close stale pull requests
+
+on:
+  schedule:
+  - cron: '0 18 * * *' # Run the workflow every day at 6PM UTC (10AM PST).
+
+jobs:
+  stale:
+
+    runs-on: ubuntu-latest
+    permissions:
+      pull-requests: write
+
+    steps:
+    - uses: actions/stale@v5
+      with:
+        repo-token: ${{ secrets.GITHUB_TOKEN }}
+        stale-pr-message: 'This pull request has been automatically marked as stale because it has been inactive for 90 days. Remove stale label or comment or this PR will be closed in 7 days.'
+        stale-pr-label: 'stale'
+        days-before-pr-stale: 90 # 3 months
+        days-before-pr-close: 7
+        days-before-issue-stale: -1
+        days-before-issue-close: -1

docs/contributing/contributing-pull-requests/README.md

@@ -102,4 +102,8 @@ If you are the code reviewer, it's your responsibility to follow up (politely) i
 
 We welcome **any contributor or community member** to engage with **any pull request** on our repository. Feel free to make suggestions for improvements and ask questions that are relevant. If you're asking questions for your learning, please make it clear that your questions are "non-blocking" for the pull request.
 
-See the [code reviewing documentation](../contributing-code/contributing-code-reviewing/README.md) for guidance on code reviewing.
+See the [code reviewing documentation](../contributing-code/contributing-code-reviewing/README.md) for guidance on code reviewing.
+
+## Inactive Pull Requests
+
+Pull requests that have been inactive for 90 days will be marked with a stale label. They will automatically be closed after a subsequent 7 days of inactivity. This timeframe may be adjusted in the future based on project needs.

test/functional/shared/resources/testdata/corerp-resources-terraform-azurestorage.bicep

@@ -27,7 +27,6 @@ resource env 'Applications.Core/environments@2023-10-01-preview' = {
           templateKind: 'terraform'
           templatePath: '${moduleServer}/azure-storage.zip'
           parameters: {
-            name: 'blob${uniqueString(resourceGroup().id)}'
             resource_group_name: resourceGroup().name
             location: location
           }

test/functional/shared/resources/testdata/recipes/test-terraform-recipes/azure-storage/main.tf

@@ -7,21 +7,25 @@ terraform {
   }
 }
 
+resource "random_id" "unique_name" {
+  byte_length = 8
+}
+
 resource "azurerm_storage_account" "test_storage_account" {
-  name = var.name
+  name = "acct${random_id.unique_name.hex}"
   resource_group_name = var.resource_group_name
   location = var.location
   account_tier = "Standard"
   account_replication_type = "LRS"
 }
 
 resource "azurerm_storage_container" "test_container" {
-  name = "test-container"
+  name = "ctr${random_id.unique_name.hex}"
   storage_account_name = azurerm_storage_account.test_storage_account.name
 }
 
 resource "azurerm_storage_blob" "test_blob" {
-  name = "test-blob"
+  name = "blob${random_id.unique_name.hex}"
   storage_account_name = azurerm_storage_account.test_storage_account.name
   storage_container_name = azurerm_storage_container.test_container.name
   type = "Block"

test/functional/shared/resources/testdata/recipes/test-terraform-recipes/azure-storage/variables.tf

@@ -1,7 +1,3 @@
-variable "name" {
-  type = string
-}
-
 variable "resource_group_name" {
   type = string
 }