Skip to content

Commit

Permalink
fix rad app delete issue
Browse files Browse the repository at this point in the history
  • Loading branch information
nithyatsu committed Jan 26, 2024
1 parent c262df7 commit 830a111
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions pkg/corerp/backend/deployment/deploymentprocessor.go
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,15 @@ func (dp *deploymentProcessor) Deploy(ctx context.Context, id resources.ID, rend

err := dp.deployOutputResource(ctx, id, rendererOutput, computedValues, &handlers.PutOptions{Resource: &outputResource, DependencyProperties: deployedOutputResourceProperties})
if err != nil {
// add the last deployed resource which was deployed with error to deployed list
// cleanup all deployed output resources in reverse order since app deployment has failed
outputResource := rpv1.OutputResource{
LocalID: outputResource.LocalID,
ID: outputResource.ID,
}
deployedOutputResources = append(deployedOutputResources, outputResource)
dp.Delete(ctx, id, deployedOutputResources)

Check failure on line 297 in pkg/corerp/backend/deployment/deploymentprocessor.go

View workflow job for this annotation

GitHub Actions / Lint

Error return value of `dp.Delete` is not checked (errcheck)

return rpv1.DeploymentOutput{}, err
}

Expand Down

0 comments on commit 830a111

Please sign in to comment.