Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifications, fixes and whitespace consistency #967

Closed
wants to merge 9 commits into from
Closed

Clarifications, fixes and whitespace consistency #967

wants to merge 9 commits into from

Conversation

PalmEmanuel
Copy link
Contributor

@PalmEmanuel PalmEmanuel commented Nov 19, 2023

A mix of typo and text fixes, clarifications, trailing whitespace removal and added missing definitions for words such as CRD.

Disclaimer: The commits were made offline on my phone using Termux, GitHub CLI and Markor on the flight home from Ignite, so hopefully the formatting looks right 😁

@PalmEmanuel PalmEmanuel requested review from a team as code owners November 19, 2023 13:38
@PalmEmanuel PalmEmanuel changed the title Clarifications, fixes and consistency Clarifications, fixes and whitespace consistency Nov 19, 2023
@jasonviviano
Copy link
Contributor

@PalmEmanuel Hey Emanuel thanks for the PR, will take a look and get back to you!

@jasonviviano
Copy link
Contributor

@PalmEmanuel
Hello Emanuel,

Thanks so much for your interest and contribution to the Radius project. We appreciate your efforts in improving the documentation. Your attention to detail is impressive and highly valued!

Note that due to the size and the range of changes it this PR, it will be challenging to effectively review and merge in its current form. To streamline the process and ensure each modification is given the attention it deserves, we suggest breaking the PR into smaller, more focused submissions.

Perhaps we could start with a PR dedicated solely to removing unnecessary whitespaces. This would be a more manageable size for review and would also help us maintain a clear history of changes. Once we've merged that, a separate PR for the grammatical and conceptual changes to specific sentences would be the next step. This approach will not only make the review process more efficient but also allow us to discuss and integrate each type of change more effectively.

Again, your contribution is valuable to the project, and we want to ensure it's integrated effectively. Please let us know if you need any assistance in splitting the PR, and feel free to reach out if you have any questions or need further clarification.
Thank you for your commitment to improving Radius. We're excited to see your ongoing contributions shape the project!

@PalmEmanuel
Copy link
Contributor Author

I completely understand! I felt a bit bad about the huge bump once I realized. I'll break it up into a few reasonable pieces in separate PRs and close this one for now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants