-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling feedback mechanism for doc pages #930
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonviviano
changed the title
Adding Feedback mechanism that Dapr docs use
Enabling Feedback mechanism for doc pages
Nov 6, 2023
jasonviviano
changed the title
Enabling Feedback mechanism for doc pages
Enabling feedback mechanism for doc pages
Nov 6, 2023
jasonviviano
force-pushed
the
jasonviviano/feedback-component
branch
from
November 6, 2023 18:55
a4c6bd6
to
da0d028
Compare
willtsai
reviewed
Nov 6, 2023
jasonviviano
commented
Nov 6, 2023
jasonviviano
commented
Nov 6, 2023
Signed-off-by: jasonviviano <[email protected]>
Signed-off-by: jasonviviano <[email protected]>
Signed-off-by: jasonviviano <[email protected]>
jasonviviano
force-pushed
the
jasonviviano/feedback-component
branch
from
November 6, 2023 21:06
cd415a1
to
1052960
Compare
AaronCrawfis
reviewed
Nov 6, 2023
Signed-off-by: jasonviviano <[email protected]>
jasonviviano
commented
Nov 7, 2023
Signed-off-by: jasonviviano <[email protected]>
jasonviviano
commented
Nov 7, 2023
Signed-off-by: jasonviviano <[email protected]>
AaronCrawfis
reviewed
Nov 7, 2023
Co-authored-by: Aaron Crawfis <[email protected]> Signed-off-by: jasonviviano <[email protected]>
AaronCrawfis
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for helping make the Radius documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Adds feedback mechanism for individual pages.
Auto-generated description
🤖 Generated by Copilot at a4c6bd6
Summary
📝🎨📊
This pull request adds a feedback UI component to the documentation site that allows users to rate each page as helpful or not. It modifies the
config.toml
file and adds a new template filefeedback.html
to implement the feature.Walkthrough
config.toml
file, such as enable flag and messages (link)feedback.html
that renders the feedback buttons and messages using the parameters (link)feedback.html
that handle the button clicks, hide the buttons, and send feedback data to Google Analytics (link)Issue reference
#929