Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore triple-backtick code blocks in spellcheck #919

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

rynowak
Copy link
Contributor

@rynowak rynowak commented Oct 30, 2023

Thank you for helping make the Radius documentation better!

Please follow this checklist before submitting:

  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

This change teaches our spellcheck plugin to ignore triple-backtick style code blocks. Without this, spellcheck is trying to process the code samples in markdown as if they were not code.

This is a port of the fix already applied to radius-project/design-notes.

The typo in the branch name was not intentional, and adds an extra layer of irony to this change.

Auto-generated description

🤖 Generated by Copilot at 09da2ba

Summary

🌟📝🎨

Enable syntax highlighting for code blocks in documentation. Update .pyspelling.yml to use fenced_code extension for markdown parsing.

Triple backticks fence
Code blocks with colors bright
Autumn leaves of text

Walkthrough

  • Enable syntax highlighting for code blocks in markdown files (link)

Issue reference

This change teaches our spellcheck plugin to ignore triple-backtick style code blocks. Without this, spellcheck is trying to process the code samples in markdown as if they were not code.

This is a port of the fix already applied to radius-project/design-notes.

The typo in the branch name was not intentional, and adds an extra layer of irony to this change.

Signed-off-by: Ryan Nowak <[email protected]>
@rynowak rynowak requested review from a team as code owners October 30, 2023 20:35
@rynowak rynowak temporarily deployed to latest October 30, 2023 20:35 — with GitHub Actions Inactive
@AaronCrawfis AaronCrawfis merged commit 0009784 into edge Oct 31, 2023
9 of 10 checks passed
@AaronCrawfis AaronCrawfis deleted the rynowak/impove-spellcheck branch October 31, 2023 15:26
@AaronCrawfis AaronCrawfis temporarily deployed to edge October 31, 2023 15:26 — with GitHub Actions Inactive
jasonviviano pushed a commit that referenced this pull request Nov 6, 2023
This change teaches our spellcheck plugin to ignore triple-backtick style code blocks. Without this, spellcheck is trying to process the code samples in markdown as if they were not code.

This is a port of the fix already applied to radius-project/design-notes.

The typo in the branch name was not intentional, and adds an extra layer of irony to this change.

Signed-off-by: Ryan Nowak <[email protected]>
Signed-off-by: jasonviviano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants