Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to concepts on docs home page #905

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Fix link to concepts on docs home page #905

merged 2 commits into from
Oct 23, 2023

Conversation

mattmazzola
Copy link
Contributor

@mattmazzola mattmazzola commented Oct 23, 2023

Thank you for helping make the Radius documentation better!

Please follow this checklist before submitting:

  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

There seem to be copy/paste error. The link for the "Concepts" was actually directing to the "Tutorials" section

Updated the reference to concepts and tested locally.

I would also add that the links do not work on the Codespace, but do work Locally.

When starting server on code space, the docs will be at a url such as
https://effective-space-computing-machine-q966j4q5x6c9wrx-1313.app.github.dev/

Clinking a reference attempts to direct to http://localhost:1313/tutorials/ but that doesn't exist.

There is probably a way to configure Hugo to use absolute urls and supply the base as environment variable when setting up the container / code space, but that would be out of scope.

Auto-generated description

🤖 Generated by Copilot at 58fe6df

Summary

🛠️📚🔗

Fixed a broken footer link in the Concepts card on the homepage. The link now points to the concepts/_index.md page instead of the tutorials/_index.md page.

Concepts card fixed
Footer link was not correct
Now it points to fall

Walkthrough

  • Fix the footer link for Concepts card to point to the correct page (link)

Issue reference

@mattmazzola mattmazzola requested review from a team as code owners October 23, 2023 21:55
Copy link
Contributor

@AaronCrawfis AaronCrawfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for finding this!

@mattmazzola mattmazzola temporarily deployed to latest October 23, 2023 22:09 — with GitHub Actions Inactive
@mattmazzola mattmazzola temporarily deployed to latest October 23, 2023 22:11 — with GitHub Actions Inactive
@AaronCrawfis AaronCrawfis temporarily deployed to latest October 23, 2023 22:14 — with GitHub Actions Inactive
@AaronCrawfis AaronCrawfis temporarily deployed to latest October 23, 2023 22:16 — with GitHub Actions Inactive
@AaronCrawfis AaronCrawfis merged commit 29bfb3f into radius-project:v0.26 Oct 23, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants