Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed azurecr references to ghcr #893

Merged
merged 7 commits into from
Oct 24, 2023
Merged

Changed azurecr references to ghcr #893

merged 7 commits into from
Oct 24, 2023

Conversation

jasonviviano
Copy link
Contributor

@jasonviviano jasonviviano commented Oct 19, 2023 •
edited
Loading

Thank you for helping make the Radius documentation better!

Please follow this checklist before submitting:

  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Tested out packages by running the following command: docker pull ghcr.io/......

Following packages are still missing possibly:

  • radius.azurecr.io/helm/v1/repo
  • radius.azurecr.io/appcore-rp

Pulling the ghcr.io/radius-project/recipes/local-dev/ packages all result in the following output:
unable to fetch descriptor (sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855) which reports content size of zero: invalid argument

Auto-generated description

🤖 Generated by Copilot at 5cb6d26

Summary

🚚📝🆕

This pull request updates the documentation and code snippets to use the new public registry radius.ghcr.io instead of the old one radius.azurecr.io. This change affects the guides for installing Radius on Kubernetes, authoring and registering custom recipes, authoring apps with various resources and networking options, and deploying apps with environments.

Oh, we're the crew of the radius ship
And we sail the cloud with skill and wit
We've changed our registry from azurecr to ghcr
So pull the ropes and update the docs, me hearties!

Walkthrough

  • Update image URLs for demo app, AWS app, and volumes app from radius.azurecr.io to radius.ghcr.io in various code snippets and guides (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Update image URL for Azure workload identity app from ghcr.io to radius.ghcr.io in container-wi.bicep code snippet (link)
  • Update template paths for MongoDB and Redis recipes from radius.azurecr.io to radius.ghcr.io in rad recipe list output (link)
  • Update Helm repository URL from radius.azurecr.io to radius.ghcr.io in Kubernetes installation instructions (link)
  • Update image URLs for Radius resource provider, deployment engine, and universal control plane from radius.azurecr.io to radius.ghcr.io in Helm configuration options (link)
  • Update target path and template path for custom recipe from myregistry.azurecr.io to myregistry.ghcr.io in recipe authoring instructions (link, link)

Issue reference

#889

@jasonviviano jasonviviano requested review from a team as code owners October 19, 2023 18:27
@jasonviviano jasonviviano temporarily deployed to latest October 19, 2023 18:27 — with GitHub Actions Inactive
@jasonviviano jasonviviano temporarily deployed to latest October 19, 2023 18:28 — with GitHub Actions Inactive
@jasonviviano jasonviviano added the do-not-merge Do not merge this PR label Oct 19, 2023
@AaronCrawfis
Copy link
Contributor

Thanks for finding these! Our new registry is ghcr.io/radius-project instead of radius.ghcr.io. Could you update this PR to use ghcr.io/radius-project please?

@github-actions
Copy link

github-actions bot commented Oct 19, 2023 •
edited
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-bush-0cc2a4f1e-893.westus2.3.azurestaticapps.net
Password: Radiu$1234

@jasonviviano jasonviviano temporarily deployed to latest October 22, 2023 19:00 — with GitHub Actions Inactive
@jasonviviano jasonviviano temporarily deployed to latest October 22, 2023 19:03 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 22, 2023 •
edited
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-bush-0cc2a4f1e-893.westus2.3.azurestaticapps.net
Password: Radiu$1234

jasonviviano
jasonviviano commented Oct 22, 2023
View reviewed changes
.../content/reference/resource-schema/core-schema/container-schema/snippets/base-container.yaml Outdated
image: radiusdev.ghcr.io/magpie:latest
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need help identifying if this package called magpie maps to magpieo, ghcr.io/radius-project/magpiego:latest.

@jasonviviano jasonviviano temporarily deployed to latest October 22, 2023 20:41 — with GitHub Actions Inactive
@jasonviviano jasonviviano temporarily deployed to latest October 22, 2023 20:44 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 22, 2023 •
edited
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-bush-0cc2a4f1e-893.westus2.3.azurestaticapps.net
Password: Radiu$1234

@jasonviviano jasonviviano temporarily deployed to latest October 23, 2023 20:21 — with GitHub Actions Inactive
@jasonviviano jasonviviano temporarily deployed to latest October 23, 2023 20:22 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 23, 2023 •
edited
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-bush-0cc2a4f1e-893.westus2.3.azurestaticapps.net
Password: Radiu$1234

@AaronCrawfis AaronCrawfis removed the do-not-merge Do not merge this PR label Oct 23, 2023
@jasonviviano jasonviviano merged commit fd026c6 into edge Oct 24, 2023
8 of 9 checks passed
@jasonviviano jasonviviano deleted the jasonv/ACR-scrub branch October 24, 2023 17:43
@jasonviviano jasonviviano temporarily deployed to edge October 24, 2023 17:43 — with GitHub Actions Inactive
jasonviviano added a commit that referenced this pull request Nov 6, 2023
@jasonviviano @AaronCrawfis
Changed azurecr references to ghcr (#893)
79c07dc 
* Change  references to

* Fixed paths of GHCR

* GHCR fixes

* Fixed GHCR

* Apply suggestions from code review

Co-authored-by: Aaron Crawfis <[email protected]>

---------

Co-authored-by: Aaron Crawfis <[email protected]>
Signed-off-by: jasonviviano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronCrawfis AaronCrawfis AaronCrawfis approved these changes

@willdavsmith willdavsmith Awaiting requested review from willdavsmith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonviviano @AaronCrawfis