Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all image blocks to use new shortcode #886

Merged
merged 49 commits into from
Oct 23, 2023
Merged

Update all image blocks to use new shortcode #886

merged 49 commits into from
Oct 23, 2023

Conversation

Reshrahim
Copy link
Contributor

@Reshrahim Reshrahim commented Oct 19, 2023

Thank you for helping make the Radius documentation better!

Please follow this checklist before submitting:

  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

This PR fixes the images not getting rendered when urls are navigated without trailing slash eg: https://docs.radapp.dev/getting-started

Auto-generated description

🤖 Generated by Copilot at 7bd145d

Summary

🖼️🛠️📄

Fixed image source paths in getting-started guide. Used relative paths instead of absolute paths to avoid broken links.

image src paths
now relative, not absolute
a winter upgrade

Walkthrough

  • Update image source paths to use relative paths instead of absolute paths for compatibility and reliability (link, link, link)

Issue reference

Fixes: #885
Fixes: #882

AaronCrawfis and others added 30 commits October 12, 2023 09:51
* Add how-to guide on local dev recipes  (#822)

* Add supported resource types

* Add how-to guideto use local dev recipes

* Apply suggestions from code review

Co-authored-by: Jonathan Smith <[email protected]>

* Update docs/content/guides/recipes/howto-dev-recipes/index.md

* Adddress feedback

* Address feedback

* Apply suggestions from code review

Co-authored-by: Aaron Crawfis <[email protected]>

* Minor tweaks

* minor tweaks

---------

Co-authored-by: Jonathan Smith <[email protected]>
Co-authored-by: Aaron Crawfis <[email protected]>

* Standardize pre-reqs for all how-tos (#836)

* Standardixe pre-reqs for all how-tos

* Update docs/content/guides/author-apps/azure/howto-azure-resources/index.md

---------

Co-authored-by: Jonathan Smith <[email protected]>
Co-authored-by: Aaron Crawfis <[email protected]>
* Add how-to guide on local dev recipes  (#822)

* Add supported resource types

* Add how-to guideto use local dev recipes

* Apply suggestions from code review

Co-authored-by: Jonathan Smith <[email protected]>

* Update docs/content/guides/recipes/howto-dev-recipes/index.md

* Adddress feedback

* Address feedback

* Apply suggestions from code review

Co-authored-by: Aaron Crawfis <[email protected]>

* Minor tweaks

* minor tweaks

---------

Co-authored-by: Jonathan Smith <[email protected]>
Co-authored-by: Aaron Crawfis <[email protected]>

* Sanitize docs for release references

* Revert spelling fix

* Apply suggestions from code review

Co-authored-by: Aaron Crawfis <[email protected]>

---------

Co-authored-by: Jonathan Smith <[email protected]>
Co-authored-by: Aaron Crawfis <[email protected]>
Signed-off-by: Aaron Crawfis <[email protected]>
Update steps after port forward to view the contents of /tmpdir

Co-authored-by: Aaron Crawfis <[email protected]>
In commend to 'inspect container logs' update current value 'frontend' with a more generic '<container_name>' similar to other commands in the document
* 1st draft of multi-cloud and OSS concept doc

* Fixing spelling errors

* Apply suggestions from code review

Co-authored-by: Aaron Crawfis <[email protected]>

* Update to correct open-source spelling

Co-authored-by: Aaron Crawfis <[email protected]>

* Changing doc weight to 100 per Aaron.

Co-authored-by: Aaron Crawfis <[email protected]>

* Apply break after header

Co-authored-by: Aaron Crawfis <[email protected]>

* Correct spelling error for "application"

Co-authored-by: Ryan Nowak <[email protected]>

* Add blank line after heading

Co-authored-by: Aaron Crawfis <[email protected]>

* Add blank line after heading

Co-authored-by: Aaron Crawfis <[email protected]>

* Include Helm charts in description of deployment assets

Co-authored-by: Ryan Nowak <[email protected]>

* Amazon S3 is not valid Dapr state store, so use DynamoDB instead

Co-authored-by: Ryan Nowak <[email protected]>

* More substantial changes based on Nowak's feedback

* Updating en-custom.txt spelling

* Put the "Concept:" in quotes to prevent build errors

Co-authored-by: Ryan Nowak <[email protected]>

* Get more specific about publicly available

Co-authored-by: Ryan Nowak <[email protected]>

* Update docs/content/concepts/multi-cloud-concept/index.md

Co-authored-by: Aaron Crawfis <[email protected]>

* Spellcheck

---------

Co-authored-by: Aaron Crawfis <[email protected]>
Co-authored-by: Ryan Nowak <[email protected]>
Signed-off-by: Aaron Crawfis <[email protected]>
Updating local dev recipes docs to use correct pod name
* Update link

Signed-off-by: Aaron Crawfis <[email protected]>

* Update vscode link

Signed-off-by: Aaron Crawfis <[email protected]>

---------

Signed-off-by: Aaron Crawfis <[email protected]>
Signed-off-by: Aaron Crawfis <[email protected]>
* Add supported resource types

* Add how-to secret store

* Split into two howto-s

* Fix ref

* Updates

* Apply suggestions from code review

Co-authored-by: Aaron Crawfis <[email protected]>

* Adddress feedback

* Address feedback

---------

Co-authored-by: Aaron Crawfis <[email protected]>
Signed-off-by: Aaron Crawfis <[email protected]>
Signed-off-by: Aaron Crawfis <[email protected]>
* Update index.md

Update to verify Helm installation

* nit

Co-authored-by: Aaron Crawfis <[email protected]>

* Spellcheck

Signed-off-by: Aaron Crawfis <[email protected]>

---------

Signed-off-by: Aaron Crawfis <[email protected]>
Co-authored-by: Aaron Crawfis <[email protected]>
Signed-off-by: Aaron Crawfis <[email protected]>
Signed-off-by: Aaron Crawfis <[email protected]>
Signed-off-by: Aaron Crawfis <[email protected]>
)

* Add docs to install Radius Bicep extension from VSCode marketplace

* Revert wrong upd

* Revert upd to initialize

* Update docs/shared-content/installation/install-radius/initialize-radius.md

* Update docs/shared-content/installation/vscode-bicep/install-vscode-bicep.md

Co-authored-by: Aaron Crawfis <[email protected]>

---------

Co-authored-by: Aaron Crawfis <[email protected]>
@Reshrahim Reshrahim temporarily deployed to latest October 19, 2023 18:21 — with GitHub Actions Inactive
@Reshrahim Reshrahim temporarily deployed to latest October 19, 2023 18:22 — with GitHub Actions Inactive
@Reshrahim Reshrahim changed the base branch from v0.26 to edge October 19, 2023 18:23
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-bush-0cc2a4f1e-886.westus2.3.azurestaticapps.net

@Reshrahim Reshrahim temporarily deployed to latest October 19, 2023 18:29 — with GitHub Actions Inactive
@Reshrahim Reshrahim temporarily deployed to latest October 19, 2023 18:30 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 19, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-bush-0cc2a4f1e-886.westus2.3.azurestaticapps.net
Password: Radiu$1234

@Reshrahim Reshrahim temporarily deployed to latest October 19, 2023 20:21 — with GitHub Actions Inactive
@Reshrahim Reshrahim changed the title Fix broken getting-started images Update all image blocks to use new shortcode Oct 19, 2023
@Reshrahim Reshrahim temporarily deployed to latest October 19, 2023 20:24 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 19, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-bush-0cc2a4f1e-886.westus2.3.azurestaticapps.net
Password: Radiu$1234

@Reshrahim Reshrahim temporarily deployed to latest October 19, 2023 20:30 — with GitHub Actions Inactive
@Reshrahim Reshrahim temporarily deployed to latest October 19, 2023 20:33 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 19, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-bush-0cc2a4f1e-886.westus2.3.azurestaticapps.net
Password: Radiu$1234

@Reshrahim Reshrahim temporarily deployed to latest October 23, 2023 16:05 — with GitHub Actions Inactive
@Reshrahim Reshrahim temporarily deployed to latest October 23, 2023 16:06 — with GitHub Actions Inactive
@Reshrahim Reshrahim enabled auto-merge (squash) October 23, 2023 16:06
@Reshrahim Reshrahim merged commit 1512bd4 into edge Oct 23, 2023
8 checks passed
@Reshrahim Reshrahim deleted the re/getst branch October 23, 2023 16:07
@Reshrahim Reshrahim temporarily deployed to edge October 23, 2023 16:07 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 23, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-bush-0cc2a4f1e-886.westus2.3.azurestaticapps.net
Password: Radiu$1234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diagram of the application and its resources is missing on the getting started page