-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Helm and Kubernetes tutorial #864
Conversation
ffba503
to
3fd29bc
Compare
3fd29bc
to
ec7286f
Compare
ec7286f
to
0df1ea5
Compare
0df1ea5
to
631fa03
Compare
631fa03
to
d12bb63
Compare
d12bb63
to
bde97de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks really great! A couple of high-level points:
- Should the headers for each step include the word "step" in them to be consistent with other tutorials? e.g. "## Step 7. Add Connection"
- I worry that this tutorial is very long, maybe covering too much ground. Would it be a good idea to show only one of Steps 6 and 7? and then at the end you can refer the reader to the other how-tos for adding Radius features to their k8s helm app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flow is looking really good. The steps seems like the right set, in the right order, and the way to "see" each effect seems spot on. Only major concern is how we can handle the Kubernetes secret before Radius. Left a comment there.
Co-authored-by: Reshma Abdul Rahim <[email protected]>
Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-bush-0cc2a4f1e-864.westus2.3.azurestaticapps.net |
Signed-off-by: Will Tsai <[email protected]>
…com/project-radius/docs into rynowak/kubernetes-interop-tutorial
regarding the opening in new tabs, we will have to make an adjustment to the overall website configs as this is the same behavior as the getting started guide. |
Signed-off-by: Will Tsai <[email protected]>
Co-authored-by: Reshma Abdul Rahim <[email protected]>
Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-bush-0cc2a4f1e-864.westus2.3.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-bush-0cc2a4f1e-864.westus2.3.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-bush-0cc2a4f1e-864.westus2.3.azurestaticapps.net |
addressed |
I have addressed the feedback and gotten approval from another docs maintainer.
Thank you for helping make the Radius documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Auto-generated description
🤖 Generated by Copilot at ffba503
Summary
🔄🚀📝
Updated the resourceType names in the
rad_resource_list
command reference to include thedapr
prefix. This improves the clarity and consistency of the documentation for users who want to use dapr resources with radius-cli.Walkthrough
dapr
prefix to resourceType names for pubSubBrokers, stateStores, and secretStores to indicate compatibility with dapr runtime (link)Issue reference