Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disclaimer note for users in both Grafana and Prometheus how-tos #862

Closed
wants to merge 3 commits into from

Conversation

jasonviviano
Copy link
Contributor

@jasonviviano jasonviviano commented Oct 17, 2023

Thank you for helping make the Radius documentation better!

Please follow this checklist before submitting:

  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Auto-generated description

🤖 Generated by Copilot at 3d45744

Summary

🚨📊🌐

This pull request adds warning alerts to the Grafana and Prometheus guides, informing users of potential issues when running these tools in non-local clusters. The alerts also provide links to the official documentation of Grafana and Prometheus for troubleshooting.

Grafana, Prometheus
Non-local clusters may fail
Read docs in winter

Walkthrough

  • Add warning alerts to Grafana and Prometheus guides about potential issues in non-local clusters (link, link)

Issue reference

#860

@jasonviviano jasonviviano requested review from a team as code owners October 17, 2023 17:05
@jasonviviano jasonviviano temporarily deployed to latest October 17, 2023 17:05 — with GitHub Actions Inactive
@jasonviviano jasonviviano changed the title Warning note for users in both Grafana and Prometheus how-tos Disclaimer note for users in both Grafana and Prometheus how-tos Oct 17, 2023
@jasonviviano
Copy link
Contributor Author

Issue to investigate further the How-To guide issues found: #918

Comment on lines +13 to +16
{{% alert color="primary" %}}
This how-to article has been validated only on a local Kubernetes cluster. If you test in other configurations and have questions, please review [Grafana](https://grafana.com/).
{{% /alert %}}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{% alert color="primary" %}}
This how-to article has been validated only on a local Kubernetes cluster. If you test in other configurations and have questions, please review [Grafana](https://grafana.com/).
{{% /alert %}}

Since the issue is in Prometheus we don't need to list the note on the Grafana guide

@@ -10,6 +10,11 @@ tags: ["metrics", "observability"]

[Prometheus](https://prometheus.io/) collects and stores metrics as time series data. This guide will show you how to collect Radius control plane metrics to then be visualized and queried.


{{% alert color="primary" %}}
This how-to article has been validated only on a local Kubernetes cluster. If you test in other configurations and have questions, please review [Prometheus](https://prometheus.io/) docs for help on debugging.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This how-to article has been validated only on a local Kubernetes cluster. If you test in other configurations and have questions, please review [Prometheus](https://prometheus.io/) docs for help on debugging.
This how-to article has been validated only on local Kubernetes clusters (_Docker Desktop, k3s_). If you run on other clusters please visit the [Prometheus docs](https://prometheus.io/) for help on setting up Prometheus.

@AaronCrawfis
Copy link
Contributor

Just tested on AKS and everything works as expected. I think we can close this PR until we get reproduction steps of it not working

@AaronCrawfis
Copy link
Contributor

Closing as not applicable. Please reopen if you hit any issues on cloud-based AKS clusters

@jasonviviano jasonviviano deleted the jasonviviano/add-note-to-metric-howtos branch February 12, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants