Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update references to sample images #828

Merged
merged 5 commits into from
Oct 12, 2023
Merged

Update references to sample images #828

merged 5 commits into from
Oct 12, 2023

Conversation

AaronCrawfis
Copy link
Contributor

This PR follows up on radius-project/samples#588

It:

  • Updates all the sample image paths to the new '/samples/'
  • Switches from 'edge' to 'latest' to fix image caching issues

@AaronCrawfis AaronCrawfis requested review from a team as code owners October 10, 2023 18:52
@github-actions
Copy link

github-actions bot commented Oct 10, 2023 •
edited
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://wonderful-plant-020417a1e-828.westus2.azurestaticapps.net
Password: Radiu$1234

@AaronCrawfis AaronCrawfis temporarily deployed to latest October 12, 2023 16:22 — with GitHub Actions Inactive
@AaronCrawfis AaronCrawfis temporarily deployed to latest October 12, 2023 16:24 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 12, 2023 •
edited
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-bush-0cc2a4f1e-828.westus2.3.azurestaticapps.net
Password: Radiu$1234

Reshrahim
Reshrahim approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@Reshrahim Reshrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One minor suggestion

docs/content/getting-started/index.md Outdated Show resolved Hide resolved
@AaronCrawfis AaronCrawfis temporarily deployed to latest October 12, 2023 16:46 — with GitHub Actions Inactive
@AaronCrawfis AaronCrawfis temporarily deployed to latest October 12, 2023 16:48 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 12, 2023 •
edited
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-bush-0cc2a4f1e-828.westus2.3.azurestaticapps.net
Password: Radiu$1234

@AaronCrawfis AaronCrawfis merged commit 7af2cc8 into edge Oct 12, 2023
8 checks passed
@AaronCrawfis AaronCrawfis deleted the aacrawfi/samples-images branch October 12, 2023 16:50
@AaronCrawfis AaronCrawfis temporarily deployed to edge October 12, 2023 16:50 — with GitHub Actions Inactive
jasonviviano pushed a commit that referenced this pull request Nov 6, 2023
@AaronCrawfis @Reshrahim @jasonviviano
Update references to sample images (#828)
afd016b 
* Remove env-var howto guide

* Rename sample references

* Update docs/content/getting-started/index.md

Co-authored-by: Reshma Abdul Rahim <[email protected]>

---------

Co-authored-by: Reshma Abdul Rahim <[email protected]>
Signed-off-by: jasonviviano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reshrahim Reshrahim Reshrahim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AaronCrawfis @Reshrahim