Add "Tooling" guides section #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Reshrahim
previously requested changes
Sep 25, 2023
| {{< alert title="Note" color="secondary" >}} | ||
| The Radius Bicep extension is a temporary extension that exists in order to extend the set of Bicep types with the Radius types. When the Bicep project adds extensibility support to their tooling the Radius Bicep extension will be deprecated. Stay tuned for updates. | ||
|
|
||
| **The Radius Bicep extension is not compatible with the official Bicep extension.** If you have the official Bicep extension installed you will need to disable or uninstall it before installing the Radius Bicep extension. |
There was a problem hiding this comment.
Can this be a separate warning instead of a note? It can also be part of the how-to guide
| @@ -20,9 +20,9 @@ Visit the [rad CLI how-to guide]({{< ref howto-rad-cli >}}) for more information | |||
|
|
|||
| ## Step 2: Install the Radius-Bicep VS Code extension | |||
There was a problem hiding this comment.
We do surface terraform extensions for terraform recipes in vscode tooling overview page. Should that be included here?
There was a problem hiding this comment.
I don't think so, since it's an optional experience only needed if creating Terraform Recipes. Versus the Radius-Bicep extension that is required in 99% of cases.
jonvsm
reviewed
Sep 26, 2023
jonvsm
reviewed
Sep 26, 2023
| type: docs | ||
| title: "rad CLI" | ||
| linkTitle: "rad CLI" | ||
| description: "Documentation on the rad CLI" |
There was a problem hiding this comment.
Suggested change
| description: "Documentation on the rad CLI" | |
| description: "rad CLI" |
jonvsm
reviewed
Sep 26, 2023
jonvsm
reviewed
Sep 26, 2023
jonvsm
reviewed
Sep 26, 2023
jonvsm
reviewed
Sep 26, 2023
jonvsm
reviewed
Sep 26, 2023
jonvsm
reviewed
Sep 26, 2023
jonvsm
reviewed
Sep 26, 2023
jonvsm
approved these changes
Sep 26, 2023
Co-authored-by: Jonathan Smith <[email protected]> Co-authored-by: Reshma Abdul Rahim <[email protected]>
AaronCrawfis
dismissed
Reshrahim’s stale review
Added comments to review. Always appreciate the feedback and we can definitely address some of the deeper details in follow-up PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a section under guides called "Tooling" where the rad CLI and VS Code sections can live. It also adds an overview page for VSCode and renames some of the links to better label the pages.