Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update resource methods #1218

Merged
merged 1 commit into from
Sep 10, 2024
Merged

update resource methods #1218

merged 1 commit into from
Sep 10, 2024

Conversation

sk593
Copy link
Contributor

@sk593 sk593 commented Sep 3, 2024

Thank you for helping make the Radius documentation better!

Please follow this checklist before submitting:

  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

We recently updated our methods on resources to be accessed using .listSecrets().<values> as opposed to .value(). This PR updates the docs to reflect that changes

Issue reference

Copy link
Contributor

@kachawla kachawla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sk593 could you please update the PR description with some context on why this is changing? Just makes it easier for anyone in the community to get understand the PR better

@sk593
Copy link
Contributor Author

sk593 commented Sep 4, 2024

@sk593 could you please update the PR description with some context on why this is changing? Just makes it easier for anyone in the community to get understand the PR better

my bad, just updated!

| connectionString() | Get the connection string for the Redis cache. |
| password() | Get the password for the Redis cache. |
| Method | Description | Example |
|--------|-------------|---------|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we expand on .value in the description, since it might not obvious until someone takes a closer look at the example?

@Reshrahim Reshrahim merged commit b652f1f into edge Sep 10, 2024
8 of 9 checks passed
@Reshrahim Reshrahim deleted the update-resource-methods branch September 10, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants