Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added small blurb on storing env variables as secrets for connections. #1042

Merged
merged 11 commits into from
Mar 4, 2024
Merged

Added small blurb on storing env variables as secrets for connections. #1042

merged 11 commits into from
Mar 4, 2024

Conversation

jasonviviano
Copy link
Contributor

Thank you for helping make the Radius documentation better!

Please follow this checklist before submitting:

  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Added small blurb on env variables being secrets stored in the Rad env

Issue reference

#987

@jasonviviano jasonviviano requested review from a team as code owners February 12, 2024 19:06
@jasonviviano
Blurb on environment variables being stored as secrets in Kubernetes …
c1bc9fb 
…env with a generic blurb on secure storing for the container overview.

Signed-off-by: jasonviviano <[email protected]>
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-bush-0cc2a4f1e-1042.westus2.3.azurestaticapps.net

2 similar comments
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-bush-0cc2a4f1e-1042.westus2.3.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-bush-0cc2a4f1e-1042.westus2.3.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-bush-0cc2a4f1e-1042.westus2.3.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-bush-0cc2a4f1e-1042.westus2.3.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-bush-0cc2a4f1e-1042.westus2.3.azurestaticapps.net

@jasonviviano
Rephrased sentence.
7817c59 
Signed-off-by: jasonviviano <[email protected]>
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-bush-0cc2a4f1e-1042.westus2.3.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-bush-0cc2a4f1e-1042.westus2.3.azurestaticapps.net

@jasonviviano @AaronCrawfis
Apply suggestions from code review
e032075 
Co-authored-by: Aaron Crawfis <[email protected]>
Signed-off-by: jasonviviano <[email protected]>
@jasonviviano jasonviviano changed the base branch from v0.30 to v0.31 March 1, 2024 20:52
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-bush-0cc2a4f1e-1042.westus2.3.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-bush-0cc2a4f1e-1042.westus2.3.azurestaticapps.net

@jasonviviano jasonviviano enabled auto-merge (squash) March 4, 2024 14:34
@jasonviviano jasonviviano merged commit 25d84c2 into v0.31 Mar 4, 2024
9 checks passed
@jasonviviano jasonviviano deleted the jasonviviano/container-connection-info branch March 4, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronCrawfis AaronCrawfis AaronCrawfis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonviviano @AaronCrawfis