Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Container Connection Env Variables Documentation #987

Closed
kachawla opened this issue Nov 30, 2023 · 0 comments
Closed

Enhance Container Connection Env Variables Documentation #987

kachawla opened this issue Nov 30, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request triaged

Comments

@kachawla
Copy link
Contributor

kachawla commented Nov 30, 2023

What content needs to be created or modified?

We currently have documentation on the format of environment variables that are injected for connections from Radius container: https://docs.radapp.io/guides/author-apps/containers/overview/#connections. However, it lacks information on how we store these environment variables securely.

Describe the solution you'd like

We should document that we use secret to store the values https://github.com/radius-project/radius/blob/main/pkg/corerp/renderers/container/render.go#L722, https://kubernetes.io/docs/concepts/configuration/secret/#using-secrets-as-environment-variables.

Where should the new material be placed?

https://docs.radapp.io/guides/author-apps/containers/overview/#connections

The associated pull request from the Radius code repo, if applicable

Not a pull request, but existing relevant code is here: https://github.com/radius-project/radius/blob/main/pkg/corerp/renderers/container/render.go#L722

AB#10599

@kachawla kachawla added the enhancement New feature or request label Nov 30, 2023
@Reshrahim Reshrahim self-assigned this Dec 7, 2023
@Reshrahim Reshrahim removed their assignment Feb 6, 2024
@jasonviviano jasonviviano self-assigned this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged
Projects
None yet
Development

No branches or pull requests

5 participants