Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Threat Model for the UCP Component of Radius #73

Merged
merged 6 commits into from
Dec 13, 2024
Merged

Threat Model for the UCP Component of Radius #73

merged 6 commits into from
Dec 13, 2024

Conversation

ytimocin
Copy link
Contributor

@ytimocin ytimocin commented Nov 3, 2024

Threat Model for the UCP Component of Radius

@ytimocin ytimocin force-pushed the ytimocin/tms/ucp branch 9 times, most recently from 77392cc to e205a1e Compare November 5, 2024 06:07
@ytimocin ytimocin force-pushed the ytimocin/tms/ucp branch 2 times, most recently from d8aa313 to 61f464f Compare November 15, 2024 20:16
brooke-hamilton
brooke-hamilton approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@brooke-hamilton brooke-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This threat model is very clear and detailed. 🚀 I especially like the simple descriptions of the architecture and how UCP fits into the overall system.

@ytimocin ytimocin force-pushed the ytimocin/tms/ucp branch 8 times, most recently from 4bc32b1 to 50d60b1 Compare November 24, 2024 18:59
rynowak
rynowak reviewed Nov 26, 2024
View reviewed changes
architecture/2024-11-ucp-component-threat-model.md Outdated Show resolved Hide resolved
architecture/2024-11-ucp-component-threat-model.md Outdated Show resolved Hide resolved
architecture/2024-11-ucp-component-threat-model.md Outdated Show resolved Hide resolved
architecture/2024-11-ucp-component-threat-model.md Show resolved Hide resolved
architecture/2024-11-ucp-component-threat-model.md Outdated Show resolved Hide resolved
architecture/2024-11-ucp-component-threat-model.md Outdated Show resolved Hide resolved
architecture/2024-11-ucp-component-threat-model.md Outdated Show resolved Hide resolved
architecture/2024-11-ucp-component-threat-model.md Outdated Show resolved Hide resolved
architecture/2024-11-ucp-component-threat-model.md Outdated Show resolved Hide resolved
architecture/2024-11-ucp-component-threat-model.md Outdated Show resolved Hide resolved
@ytimocin ytimocin requested review from a team as code owners November 26, 2024 19:52
@ytimocin ytimocin force-pushed the ytimocin/tms/ucp branch 2 times, most recently from 5478b11 to 1df91f9 Compare December 2, 2024 19:07
@ytimocin ytimocin force-pushed the ytimocin/tms/ucp branch 2 times, most recently from 7482de9 to 497f438 Compare December 9, 2024 17:13
rynowak
rynowak reviewed Dec 9, 2024
View reviewed changes
architecture/2024-11-ucp-component-threat-model.md Outdated

#### Threat: A Malicious Actor Could Exploit SHA-1 Weaknesses to Generate Hash Collisions

**Description:** A malicious actor could exploit the known vulnerabilities of the SHA-1 hashing algorithm to generate hash collisions. The UCP currently uses SHA-1 for hashing resource IDs and generating ETags. Although SHA-1 is not used in security-sensitive contexts, its vulnerabilities could still be exploited to create hash collisions, potentially leading to data integrity issues.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why this is a security threat. It's too vague.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be more specific. A malicious user could do X to achieve Y. Y should be grounded in one of these: https://en.wikipedia.org/wiki/STRIDE_model

@rynowak rynowak merged commit 78fd8fe into radius-project:main Dec 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brooke-hamilton brooke-hamilton brooke-hamilton approved these changes

@rynowak rynowak rynowak approved these changes

@lakshmimsft lakshmimsft Awaiting requested review from lakshmimsft

@nithyatsu nithyatsu Awaiting requested review from nithyatsu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ytimocin @rynowak @brooke-hamilton @nithyatsu @lakshmimsft