fix(smc-output): close ftp sessions properly (#561)

radiorabe · Dec 11, 2023 · fc0d2d0 · fc0d2d0
1 parent 8dceed3
commit fc0d2d0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/nowplaying/track/observers/smc_ftp.py b/nowplaying/track/observers/smc_ftp.py
@@ -68,6 +68,7 @@ def track_started(self, track: Track):
         ftp.storlines("STOR /dls/nowplaying.dls", dls)
         ftp.storlines("STOR /dlplus/nowplaying.dls", dlplus)
 
+        ftp.quit()
         ftp.close()
 
         logger.info(

diff --git a/tests/test_track_observer_smc_ftp.py b/tests/test_track_observer_smc_ftp.py
@@ -48,6 +48,7 @@ def test_track_started(mock_ftp, track_factory, show_factory):
                 "STOR /dlplus/nowplaying.dls",
                 ANY,
             ),
+            call.quit(),
             call.close(),
         ]
     )
@@ -75,6 +76,7 @@ def test_track_started(mock_ftp, track_factory, show_factory):
                 ANY,
             ),
             call.storlines("STOR /dlplus/nowplaying.dls", ANY),
+            call.quit(),
             call.close(),
         ]
     )