This repository has been archived by the owner on Jul 31, 2019. It is now read-only.
Add support for -1 parameters. General cleanup. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamja
commented
Oct 23, 2017
grahamja
commented
- Added provider support for '-1' value in the sp_expire and sp_inact parameters.
- Changed value validation to regex.
- Updated Development Gems (updated Gemfile.lock).
- Added cookstyle Gem for a sane set of Rubocop rules.
- Updated guard config to use cookstyle rules with Rubocop.
- Overall re-formatting/refactoring to make code more readable (specifically the super long lines, now limited to 80 characters).
- Updated kitchen config to latest patch version of each platform.
- Added Centos 5.11 kitchen config.
- Added Ubuntu 16.04
- Updated fauxhi versions to match.
…added tests for it. Updated Gems in Gemfile.lock. Added cookstyle for a sane set of Rubocop rules. Fixed Rubocop and Foodcritic (most of them) violations. Refactored a lot of code to make it easier to read (like no more 300 character long lines).
|
Is anyone still maintaining this cookbook? I'd love to see this feature added (sp_expire). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.