feat: create a single images overlay #582
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudnull
force-pushed
the
images-base
branch
2 times, most recently
from
929e58f
to
2f46fc8
Compare
cloudnull
force-pushed
the
images-base
branch
5 times, most recently
from
0484d2e
to
d0af8a7
Compare
With this change all of the images that we use across our charts will now be defined in a single place. This will better allow an automated pipeline to control our image usage and ensure that we're maintaining a unified set of images for a given release, branch, or deployment. * All images are using the builtin kustomize image replacement solution. * The default base image set is now defined as 2024.1 * The helm values are defining the `image-<name>` string within them, permitting the override to take place * The kustomization files have been updated to all use the updated resources defined in the image overlay Signed-off-by: Kevin Carter <[email protected]>
cloudnull
force-pushed
the
images-base
branch
from
d0af8a7
to
957a112
Compare
|
due to upstream feature gap, this can't go in for now. But we can circle back on this at a later date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change all of the images that we use across our charts will now be defined in a single place. This will better allow an automated pipeline to control our image usage and ensure that we're maintaining a unified set of images for a given release, branch, or deployment.
image-<name>string within them, permitting the override to take place