fix: OSPC-613 mariadb cleanup old backups #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mariadb-backup init container already runs as root and tries to
chmod `777` the backup files, but they get changed back to `0644` at some
point later on. This results in the mariadb-operator pod running into a
permission denied situation during its cleanup for the desired retention
setting.
The fix herein simply runs the pod as root so that the mariadb-operator
container in the pod has access to cleanup the old backups as needed.
This change fixes **NEW** backups, existing ones need to have the
corresponding `CronJob` modified (see below).
While re-applying the `mariadb-backup` will update the existing `Backup`,
the mariadb-operator does not seem to reconcile the `CronJob` for the
securityContext attribute. One must update the `CronJob` manually or
apply a patch to fix existing jobs without deleting and re-creating them.
This patch has been tested and does just that to add the needed
securityContext to the existing `CronJob`:
```shell
kubectl patch cronjob mariadb-backup -n openstack --type='json' \
-p='[{"op": "add", "path": "/spec/jobTemplate/spec/template/spec/securityContext/runAsUser", "value": 0}]'
```
Ref: OSPC-613
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mariadb-backup init container already runs as root and tries to chmod
777the backup files, but they get changed back to0644at some point later on. This results in the mariadb-operator pod running into a permission denied situation during its cleanup for the desired retention setting.The fix herein simply runs the pod as root so that the mariadb-operator container in the pod has access to cleanup the old backups as needed.
This change fixes NEW backups, existing ones need to have the corresponding
CronJobmodified (see below).While re-applying the
mariadb-backupwill update the existingBackup, the mariadb-operator does not seem to reconcile theCronJobfor the securityContext attribute. One must update theCronJobmanually or apply a patch to fix existing jobs without deleting and re-creating them.This patch has been tested and does just that to add the needed securityContext to the existing
CronJob:Ref: OSPC-613