Skip to content

Commit

Permalink
On CRAN 0.4.1 passed early tests, but on deployment it
Browse files Browse the repository at this point in the history
turned out that a dependency is not available for  i386-pc-solaris2.10 (32-bit). This dependency is `magick`, which was supposed to help printing vignettes in Word (a very rare case) for `kableExtra` is not available on Solaris.  I removed this dependency.
  • Loading branch information
antaldaniel committed Jan 18, 2019
1 parent 55f083b commit 75cf282
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 22 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: iotables
Type: Package
Title: Importing and Manipulating Symmetric Input-Output Tables
Version: 0.4.1
Version: 0.4.2
Authors@R: person("Daniel", "Antal", role = c("aut", "cre"), email = "[email protected]", comment = c(ORCID = "0000-0001-7513-6760"))
Maintainer: Daniel Antal <[email protected]>
Description: Pre-processing and basic analytical tasks related to working with Eurostat's symmetric input-output
Expand Down
1 change: 0 additions & 1 deletion NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ importFrom(eurostat,get_eurostat)
importFrom(eurostat,label_eurostat)
importFrom(forcats,fct_reorder)
importFrom(kableExtra,column_spec)
importFrom(kableExtra,kable_as_image)
importFrom(kableExtra,kable_styling)
importFrom(knitr,is_html_output)
importFrom(knitr,is_latex_output)
Expand Down
4 changes: 3 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -125,4 +125,6 @@ New vignette *United Kingdom Input-Output Analyitcal Tables* to compare analytic
# iotables 0.4.1
A small formatting error in the documentation of `netherlands_2006` threw up a note on CRAN.

This is a CRAN Release candidate.
# iotables 0.4.2
On CRAN 0.4.1 passed early tests, but on deployment it
turned out that a dependency is not available for i386-pc-solaris2.10 (32-bit). This dependency is `magick`, which was supposed to help printing vignettes in Word (a very rare case) for `kableExtra` is not available on Solaris. I removed this dependency.
16 changes: 5 additions & 11 deletions R/create_knitr_table.R
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,17 @@
#' @param bootstrap_options Defaults to \code{c("striped", "hover", "condensed")} and
#' only used for \code{output_format = "html"}.
#' @param latex_options Defaults to \code{NULL)}.
#' @param output_format Defaults to \code{'html'}. Alternatives are \code{'latex'} and
#' \code{'image'}, recommended for Word files.
#' @param output_format Defaults to \code{'html'}. Alternatives are \code{'latex'}.
#' \code{'image'}, recommended for Word files, is removed because it depends
#' on magick which is not available on all R platforms.
#' @param keep_pdf Defaults to \code{FALSE} and only used if \code{output_format = 'image'}.
#' @param latex_header_includes Currently defaults to \code{c(
#' "\\usepackage[magyar]{babel}",
#' "\\usepackage[utf8]{inputenc}")}
#' It can be any valid latex option setting, but if packages are used, the
#' packages must be installed on your Latex engine.
#' @importFrom knitr kable is_latex_output is_html_output
#' @importFrom kableExtra kable_as_image kable_styling column_spec
#' @importFrom kableExtra kable_styling column_spec
#' @examples
#' foo = data.frame (
#' observation = c("indicator1", "indicator2", "indicator3"),
Expand Down Expand Up @@ -161,14 +162,7 @@ create_knitr_table <- function (
)
i = i + 1
} #end of while loop

if ( output_format == 'image') {
knitr_table <- kableExtra::kable_as_image(
kable_input = knitr_table,
keep_pdf = keep_pdf,
latex_header_includes = latex_header_includes)
}



knitr_table

Expand Down
8 changes: 2 additions & 6 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,5 @@ with devtools::check_rhub() on https://builder.r-hub.io checked with
0 errors | 0 warnings | 0 notes

##Notes
I tried to submit the package, and there were 1 NOTE that did no appear
on during my testing. It was created an URL in sources which is malformatted
on Linux system. I removed the malformatted URL, because the problem was
persisent on Linux systems however I tried to overcome it.

I also modified a warning since 0.4.0 but it has no effect on tests.
On CRAN the earlier submission passed early tests, but on deployment it
turned out that a dependency is not available for i386-pc-solaris2.10 (32-bit). magick, which was supposed to help printing vignettes in Word (a very rare case) for kableExtra is not available on Solaris. I removed this dependency.
5 changes: 3 additions & 2 deletions man/create_knitr_table.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 75cf282

Please sign in to comment.