feat: wallet integration #371
clippy
112 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 112 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.83.0 (90b35a623 2024-11-26)
- cargo 1.83.0 (5ffbef321 2024-10-29)
- clippy 0.1.83 (90b35a6 2024-11-26)
Annotations
Check warning on line 13 in crates/pop-cli/src/commands/new/mod.rs
github-actions / clippy
missing documentation for a macro
warning: missing documentation for a macro
--> crates/pop-cli/src/commands/new/mod.rs:13:1
|
13 | macro_rules! enum_variants {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 57 in crates/pop-cli/src/main.rs
github-actions / clippy
missing documentation for a struct
warning: missing documentation for a struct
--> crates/pop-cli/src/main.rs:57:1
|
57 | pub struct Cli {
| ^^^^^^^^^^^^^^
Check warning on line 133 in crates/pop-cli/src/main.rs
github-actions / clippy
missing documentation for the crate
warning: missing documentation for the crate
--> crates/pop-cli/src/main.rs:3:1
|
3 | / #[cfg(not(any(feature = "contract", feature = "parachain")))]
4 | | compile_error!("feature \"contract\" or feature \"parachain\" must be enabled");
5 | |
6 | | use anyhow::{anyhow, Result};
... |
132 | | }
133 | | }
| |_^
|
= note: requested on the command line with `-W missing-docs`
Check warning on line 258 in crates/pop-cli/src/commands/up/parachain.rs
github-actions / clippy
using `map` over `inspect`
warning: using `map` over `inspect`
--> crates/pop-cli/src/commands/up/parachain.rs:258:5
|
258 | .map(|b| {
| ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect
= note: `#[warn(clippy::manual_inspect)]` on by default
help: try
|
258 ~ .inspect(|b| {
259 | if latest && b.stale() {
260 | b.use_latest()
261 ~ }
|
Check warning on line 43 in crates/pop-cli/src/commands/clean.rs
github-actions / clippy
the following explicit lifetimes could be elided: 'a
warning: the following explicit lifetimes could be elided: 'a
--> crates/pop-cli/src/commands/clean.rs:43:6
|
43 | impl<'a, CLI: Cli> CleanCacheCommand<'a, CLI> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
43 - impl<'a, CLI: Cli> CleanCacheCommand<'a, CLI> {
43 + impl<CLI: Cli> CleanCacheCommand<'_, CLI> {
|
Check warning on line 168 in crates/pop-cli/src/commands/call/contract.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> crates/pop-cli/src/commands/call/contract.rs:168:57
|
168 | .map(|p| p.is_dir() && !has_contract_been_built(Some(&p)))
| ^^ help: change this to: `p`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
Check warning on line 195 in crates/pop-cli/src/wallet_integration.rs
github-actions / clippy
function `terminate_handler` is never used
warning: function `terminate_handler` is never used
--> crates/pop-cli/src/wallet_integration.rs:195:22
|
195 | pub(super) async fn terminate_handler(
| ^^^^^^^^^^^^^^^^^
Check warning on line 186 in crates/pop-cli/src/wallet_integration.rs
github-actions / clippy
function `error_handler` is never used
warning: function `error_handler` is never used
--> crates/pop-cli/src/wallet_integration.rs:186:22
|
186 | pub(super) async fn error_handler(
| ^^^^^^^^^^^^^
Check warning on line 169 in crates/pop-cli/src/wallet_integration.rs
github-actions / clippy
function `submit_handler` is never used
warning: function `submit_handler` is never used
--> crates/pop-cli/src/wallet_integration.rs:169:22
|
169 | pub(super) async fn submit_handler(
| ^^^^^^^^^^^^^^
Check warning on line 158 in crates/pop-cli/src/wallet_integration.rs
github-actions / clippy
function `get_payload_handler` is never used
warning: function `get_payload_handler` is never used
--> crates/pop-cli/src/wallet_integration.rs:158:22
|
158 | pub(super) async fn get_payload_handler(
| ^^^^^^^^^^^^^^^^^^^
Check warning on line 233 in crates/pop-cli/src/wallet_integration.rs
github-actions / clippy
associated function `new` is never used
warning: associated function `new` is never used
--> crates/pop-cli/src/wallet_integration.rs:233:9
|
232 | impl FrontendFromString {
| ----------------------- associated function in this implementation
233 | pub fn new(content: String) -> Self {
| ^^^
Check warning on line 216 in crates/pop-cli/src/wallet_integration.rs
github-actions / clippy
associated function `new` is never used
warning: associated function `new` is never used
--> crates/pop-cli/src/wallet_integration.rs:216:9
|
215 | impl FrontendFromDir {
| -------------------- associated function in this implementation
216 | pub fn new(content: PathBuf) -> Self {
| ^^^
Check warning on line 202 in crates/pop-cli/src/wallet_integration.rs
github-actions / clippy
function `terminate_helper` is never used
warning: function `terminate_helper` is never used
--> crates/pop-cli/src/wallet_integration.rs:202:10
|
202 | async fn terminate_helper(handle: &Arc<Mutex<StateHandler>>) -> anyhow::Result<()> {
| ^^^^^^^^^^^^^^^^
Check warning on line 68 in crates/pop-cli/src/wallet_integration.rs
github-actions / clippy
associated items `new`, `new_with_address`, `terminate`, `is_running`, and `take_error` are never used
warning: associated items `new`, `new_with_address`, `terminate`, `is_running`, and `take_error` are never used
--> crates/pop-cli/src/wallet_integration.rs:68:9
|
58 | impl WalletIntegrationManager {
| ----------------------------- associated items in this implementation
...
68 | pub fn new<F: Frontend>(frontend: F, payload: TransactionData) -> Self {
| ^^^
...
73 | pub fn new_with_address<F: Frontend>(frontend: F, payload: TransactionData, rpc: &str) -> Self {
| ^^^^^^^^^^^^^^^^
...
113 | pub async fn terminate(&mut self) -> anyhow::Result<()> {
| ^^^^^^^^^
...
118 | pub fn is_running(&self) -> bool {
| ^^^^^^^^^^
...
123 | pub async fn take_error(&mut self) -> Option<String> {
| ^^^^^^^^^^
Check warning on line 49 in crates/pop-cli/src/wallet_integration.rs
github-actions / clippy
struct `WalletIntegrationManager` is never constructed
warning: struct `WalletIntegrationManager` is never constructed
--> crates/pop-cli/src/wallet_integration.rs:49:12
|
49 | pub struct WalletIntegrationManager {
| ^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 40 in crates/pop-cli/src/wallet_integration.rs
github-actions / clippy
fields `shutdown_tx`, `signed_payload`, and `error` are never read
warning: fields `shutdown_tx`, `signed_payload`, and `error` are never read
--> crates/pop-cli/src/wallet_integration.rs:40:2
|
38 | pub struct StateHandler {
| ------------ fields in this struct
39 | /// Channel to signal shutdown to the main app.
40 | shutdown_tx: Option<oneshot::Sender<()>>,
| ^^^^^^^^^^^
41 | /// Received from UI.
42 | pub signed_payload: Option<String>,
| ^^^^^^^^^^^^^^
...
45 | error: Option<String>,
| ^^^^^
Check warning on line 29 in crates/pop-cli/src/wallet_integration.rs
github-actions / clippy
associated function `new` is never used
warning: associated function `new` is never used
--> crates/pop-cli/src/wallet_integration.rs:29:9
|
28 | impl TransactionData {
| -------------------- associated function in this implementation
29 | pub fn new(chain_rpc: String, call_data: Vec<u8>) -> Self {
| ^^^
Check warning on line 17 in crates/pop-cli/src/wallet_integration.rs
github-actions / clippy
method `serve_content` is never used
warning: method `serve_content` is never used
--> crates/pop-cli/src/wallet_integration.rs:17:5
|
16 | pub trait Frontend {
| -------- method in this trait
17 | fn serve_content(&self) -> Router;
| ^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 249 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a method
warning: missing documentation for a method
--> crates/pop-parachains/src/templates.rs:249:2
|
249 | pub fn license(&self) -> Option<&str> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 245 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a method
warning: missing documentation for a method
--> crates/pop-parachains/src/templates.rs:245:2
|
245 | pub fn is_audited(&self) -> bool {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 239 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a method
warning: missing documentation for a method
--> crates/pop-parachains/src/templates.rs:239:2
|
239 | pub fn is_supported_version(&self, version: &str) -> bool {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 235 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a method
warning: missing documentation for a method
--> crates/pop-parachains/src/templates.rs:235:2
|
235 | pub fn supported_versions(&self) -> Option<Vec<&str>> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 196 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/templates.rs:196:2
|
196 | DeprecatedOpenZeppelinGeneric,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 153 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/templates.rs:153:2
|
153 | OpenZeppelinEVM,
| ^^^^^^^^^^^^^^^
Check warning on line 138 in crates/pop-parachains/src/templates.rs
github-actions / clippy
missing documentation for a variant
warning: missing documentation for a variant
--> crates/pop-parachains/src/templates.rs:138:2
|
138 | OpenZeppelinGeneric,
| ^^^^^^^^^^^^^^^^^^^