Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump zombienet version to v0.2.17 #352

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pepoviola
Copy link

Fix fn nodes() visibility.

Thanks!

@Daanvdplas
Copy link
Collaborator

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.52%. Comparing base (258a4b2) to head (fd45759).

@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
+ Coverage   70.47%   70.52%   +0.04%     
==========================================
  Files          54       51       -3     
  Lines        9250     9244       -6     
  Branches     9250     9244       -6     
==========================================
  Hits         6519     6519              
+ Misses       1737     1733       -4     
+ Partials      994      992       -2     

see 6 files with indirect coverage changes

@AlexD10S
Copy link
Collaborator

AlexD10S commented Nov 28, 2024

Thanks for that @pepoviola
We use cargo-deny https://embarkstudios.github.io/cargo-deny/cli/check.html to ensure that the dependencies we add are free of vulnerabilities. However, it seems that the check is currently failing in the CI pipeline: https://github.com/r0gue-io/pop-cli/actions/runs/12030329241/job/33588146318?pr=352

You can run it locally with cargo-deny check.

If the issue cannot be resolved within the library, you can address it by adding the following line to the deny.toml:
https://github.com/r0gue-io/pop-cli/blob/main/deny.toml#L8 with the ID is failing, in this case RUSTSEC-2024-0399

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants