Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: flag sudo to wrap extrinsic #349

Open
wants to merge 10 commits into
base: feat-call-extrinsic-call-data
Choose a base branch
from

Conversation

AlexD10S
Copy link
Collaborator

@AlexD10S AlexD10S commented Nov 25, 2024

This PR is part of the pop call parachain feature. It adds the ability to submit an extrinsic as a sudo operation using the --sudo flag, wrapping the selected extrinsic with sudo privileges.

For testing:
You can run pop call parachain interactively to select the extrinsic you want to execute and choose to run it as a sudo at the end.
Alternatively, you can specify it directly in the command line with:
pop call parachain --pallet System --extrinsic remark --args "0x11" --url ws://localhost:9944/ --suri //Alice --sudo

@AlexD10S AlexD10S force-pushed the feat-call-extrinsic-call-data branch from 44d2fd8 to dab1404 Compare November 28, 2024 16:38
@AlexD10S AlexD10S force-pushed the feat-call-extrinsic-sudo-wrap branch from 1e81daf to c99d069 Compare November 29, 2024 11:00
@AlexD10S AlexD10S marked this pull request as ready for review December 2, 2024 22:08
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 7 lines in your changes missing coverage. Please review.

Project coverage is 74.21%. Comparing base (aa42a5f) to head (0ab59b0).

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/call/parachain.rs 83.87% 2 Missing and 3 partials ⚠️
crates/pop-parachains/src/call/mod.rs 88.88% 0 Missing and 2 partials ⚠️
@@                        Coverage Diff                        @@
##           feat-call-extrinsic-call-data     #349      +/-   ##
=================================================================
+ Coverage                          74.16%   74.21%   +0.04%     
=================================================================
  Files                                 62       62              
  Lines                              11993    12041      +48     
  Branches                           11993    12041      +48     
=================================================================
+ Hits                                8895     8936      +41     
- Misses                              1910     1912       +2     
- Partials                            1188     1193       +5     
Files with missing lines Coverage Δ
crates/pop-parachains/src/call/mod.rs 57.72% <88.88%> (+5.34%) ⬆️
crates/pop-cli/src/commands/call/parachain.rs 78.42% <83.87%> (+0.21%) ⬆️

@AlexD10S AlexD10S added the ready-for-final-review The PR is ready for final review label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-final-review The PR is ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant