Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: submit extrinsic from call_data #348

Open
wants to merge 13 commits into
base: feat-call-ui-extrinsics-limited
Choose a base branch
from

Conversation

AlexD10S
Copy link
Collaborator

@AlexD10S AlexD10S commented Nov 25, 2024

This PR is part of the pop call parachain feature. It allows submitting an extrinsic by providing the call data with the flag --call.

Example for testing:
pop call parachain --call 0x00000410 --url ws://localhost:9944/ --suri //Alice

(In this example, the call data corresponds to a remark extrinsic.)

@AlexD10S AlexD10S force-pushed the feat-call-extrinsic-call-data branch from 44d2fd8 to dab1404 Compare November 28, 2024 16:38
@AlexD10S AlexD10S force-pushed the feat-call-ui-extrinsics-limited branch from 7e61b40 to f60c1e3 Compare November 30, 2024 17:57
@AlexD10S AlexD10S marked this pull request as ready for review December 2, 2024 21:57
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 39.65517% with 70 lines in your changes missing coverage. Please review.

Project coverage is 74.16%. Comparing base (b97f608) to head (8593779).

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/call/parachain.rs 47.56% 36 Missing and 7 partials ⚠️
crates/pop-parachains/src/call/mod.rs 0.00% 27 Missing ⚠️
@@                         Coverage Diff                         @@
##           feat-call-ui-extrinsics-limited     #348      +/-   ##
===================================================================
- Coverage                            74.38%   74.16%   -0.23%     
===================================================================
  Files                                   62       62              
  Lines                                11905    11993      +88     
  Branches                             11905    11993      +88     
===================================================================
+ Hits                                  8856     8895      +39     
- Misses                                1868     1910      +42     
- Partials                              1181     1188       +7     
Files with missing lines Coverage Δ
crates/pop-common/src/lib.rs 68.42% <100.00%> (+7.13%) ⬆️
crates/pop-contracts/src/call.rs 81.14% <ø> (ø)
crates/pop-contracts/src/node/mod.rs 64.62% <ø> (ø)
crates/pop-contracts/src/testing.rs 68.42% <ø> (-8.51%) ⬇️
crates/pop-contracts/src/up.rs 80.20% <ø> (ø)
crates/pop-parachains/src/errors.rs 100.00% <ø> (ø)
crates/pop-parachains/src/call/mod.rs 52.38% <0.00%> (-18.14%) ⬇️
crates/pop-cli/src/commands/call/parachain.rs 78.20% <47.56%> (-1.43%) ⬇️

@AlexD10S AlexD10S added the ready-for-final-review The PR is ready for final review label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-final-review The PR is ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant