Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hrmp #278

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

fix: hrmp #278

wants to merge 11 commits into from

Conversation

evilrobot-01
Copy link
Contributor

@evilrobot-01 evilrobot-01 commented Aug 7, 2024

Ensures hrmp channels work seamlessly via pop-cli.

Note that it currently requires a build of the chain-spec-generator from https://github.com/r0gue-io/paseo-network-runtimes. See open questions below.

Test using:
cargo run -- up parachain -f ./tests/networks/pop.toml --verbose

Open question:

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 5.12821% with 74 lines in your changes missing coverage. Please review.

Project coverage is 69.91%. Comparing base (258a4b2) to head (e50e3ce).

Files with missing lines Patch % Lines
crates/pop-parachains/src/relay.rs 0.00% 41 Missing ⚠️
crates/pop-cli/src/commands/up/parachain.rs 0.00% 27 Missing ⚠️
crates/pop-parachains/src/up/mod.rs 40.00% 6 Missing ⚠️
@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
- Coverage   70.47%   69.91%   -0.56%     
==========================================
  Files          54       55       +1     
  Lines        9250     9325      +75     
  Branches     9250     9325      +75     
==========================================
+ Hits         6519     6520       +1     
- Misses       1737     1811      +74     
  Partials      994      994              
Files with missing lines Coverage Δ
crates/pop-parachains/src/errors.rs 0.00% <ø> (ø)
crates/pop-parachains/src/utils/helpers.rs 79.77% <ø> (ø)
crates/pop-parachains/src/up/mod.rs 86.86% <40.00%> (-0.33%) ⬇️
crates/pop-cli/src/commands/up/parachain.rs 6.93% <0.00%> (-0.68%) ⬇️
crates/pop-parachains/src/relay.rs 0.00% <0.00%> (ø)

@evilrobot-01
Copy link
Contributor Author

Rebased.

@evilrobot-01 evilrobot-01 marked this pull request as ready for review November 27, 2024 14:41
@evilrobot-01 evilrobot-01 added the ready-for-high-level-review The PR needs a high level review label Nov 27, 2024
@Daanvdplas
Copy link
Collaborator

I noticed that when I build the chain-spec-generator and used it to spin up a local network the parachains were not producing blocks. Used the release binary and it worked. Not 100% sure I did something wrong or it is the chain spec generator. Just put it here so that we are aware.

@AlexD10S AlexD10S self-requested a review December 3, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-high-level-review The PR needs a high level review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants