Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ANSI sequences in index.md #2787

Merged
merged 6 commits into from
Nov 8, 2024
Merged

Support ANSI sequences in index.md #2787

merged 6 commits into from
Nov 8, 2024

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Sep 28, 2024

They are being stripped out immediately after converting Markdown to HTML. This works for me in duckplyr: https://github.com/tidyverse/duckplyr/actions/runs/11086444293/job/30803979684 is built using this branch, the result is in https://duckplyr.tidyverse.org/ .

Not sure how to add tests here.

@krlmlr krlmlr changed the title f readme tweak Spaces at EOL Sep 28, 2024
Copy link

github-actions bot commented Sep 28, 2024

@krlmlr krlmlr requested a review from maelle September 28, 2024 19:38
@krlmlr krlmlr changed the title Spaces at EOL Support ANSI sequences in index.md Sep 28, 2024
@krlmlr krlmlr force-pushed the f-readme-tweak branch 2 times, most recently from 1784d8c to 75d8ec2 Compare September 28, 2024 20:00
tests/testthat/test-markdown.R Outdated Show resolved Hide resolved
@maelle
Copy link
Collaborator

maelle commented Oct 4, 2024

@krlmlr I added two tests that fail on the main branch. 😸

Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Want to add a news bullet?

@krlmlr
Copy link
Member Author

krlmlr commented Oct 29, 2024

Done.

@jayhesselberth jayhesselberth merged commit c40ba2c into main Nov 8, 2024
17 checks passed
@jayhesselberth jayhesselberth deleted the f-readme-tweak branch November 8, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants